GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/4940
[FLINK-7959] [table] Split CodeGenerator into CodeGeneratorContext and
ExprCodeGenerator.
## What is the purpose of the change
Split current `CodeGenerator` into two dedicated
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3511
> So I think a simpler and better approach is to just make sure that most
types have a good implementation of putNormalizedKey, and then
NormalizedKeySorter.compareRecords would be called o
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3511
@heytitle @ggevay Great work!
We are working on a project to fully code generate the algorithm Flink
runtime used, and borrowed lots of idea of this PR, thanks! IMHO, in addition
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/4667
LGTM, @fhueske @twalthr can you also take a look?
---
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/4667#discussion_r139049572
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/PartitionableTableSource.scala
---
@@ -0,0 +1,193
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/4667#discussion_r139049316
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/PartitionableTableSource.scala
---
@@ -0,0 +1,193
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/4667#discussion_r139048604
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/PartitionableTableSource.scala
---
@@ -0,0 +1,193
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/4667#discussion_r139048337
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala
---
@@ -55,4 +55,9 @@ trait
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/4668
@fhueske sure
---
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/4668
Thanks @JingsongLi for your contribution
LGTM, +1 to merge
cc @fhueske @StephanEwen
---
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/4529
@zentol So the rationale behind this is when all netty's memory comes from
flink's managed memory, then this is not an issue, right?
---
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/4529
If I remember correctly, the reason we chose to do an extra copy inside
`extractFrame` is that we faced some memory problem when using `slice`. Is this
no longer an issue or have taken care
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/4445
I would bet on deserialization for it. And why sorter suffers more
regression than hash join is that sorter will cause more deserializations
during compare records than hash join.
Despite
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/4305#discussion_r127113118
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -843,11 +843,14 @@ private float convertToFloat(Object o
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/4305#discussion_r127107209
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -843,11 +843,14 @@ private float convertToFloat(Object o
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/4305
Hi @greghogan , thanks for the review, your comments have been addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/4305
[FLINK-7161] fix misusage of Float.MIN_VALUE and Double.MIN_VALUE
I already checked all places using Float.MIN_VALUE and Double.MIN_VALUE and
fixed all misusage.
You can merge this pull request
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3913#discussion_r117385333
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -37,25 +36,10 @@ import
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3913#discussion_r117201965
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -37,25 +36,10 @@ import
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3913#discussion_r116919339
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/exceptions.scala
---
@@ -128,7 +128,7 @@ case class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3913#discussion_r116919313
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/exceptions.scala
---
@@ -114,7 +114,7 @@ case class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3913#discussion_r116919169
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -37,25 +36,10 @@ import
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3803
Ok, do it right way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3803
Sorry i wasn't available in the last couple days, it seems the 1.3 branch
has been created, should i merge this PR in to 1.3 branch too?
---
If your project is set up for it, you can reply
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/3803
[FLINK-6394] [runtime] Respect object reuse configuration when executâ¦
â¦ing group combining function
You can merge this pull request into a Git repository by running:
$ git pull
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3394#discussion_r114070398
--- Diff: flink-runtime/src/test/resources/log4j-test.properties ---
@@ -16,7 +16,7 @@
# limitations under the License
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/3794
[FLINK-6398] RowSerializer's duplicate should always return a new instance
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KurtYoung/flink
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3594
Rebased to master and will merge after build check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3594
@fhueske I have rename the package and update the union description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111931445
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/TableEnvironmentTest.scala
---
@@ -335,7 +335,8 @@ class TableEnvironmentTest
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111930527
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalAggregate.scala
---
@@ -0,0 +1,92
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3594
Hi @fhueske , sorry for taking it so long to update this PR.
Looks like it has so many conflicts with master now, once you are ok with
all the changes, i will rebase it to master
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111861591
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetCorrelateRule.scala
---
@@ -18,58 +18,57
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111861037
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/cost/FlinkRelMdRowCount.scala
---
@@ -23,13 +23,17 @@ import
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111860657
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/TableEnvironmentTest.scala
---
@@ -335,7 +335,8 @@ class TableEnvironmentTest
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111860136
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalTableSourceScan.scala
---
@@ -0,0 +1,109
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111859756
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalSort.scala
---
@@ -0,0 +1,148
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111858923
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalAggregate.scala
---
@@ -0,0 +1,92
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111857813
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalAggregate.scala
---
@@ -0,0 +1,92
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111857715
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalJoin.scala
---
@@ -0,0 +1,130
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111856357
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
@@ -228,15 +229,24 @@ abstract class
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/3695
[FLINK-5545] [table] Remove FlinkAggregateExpandDistinctAggregatesRulâ¦
â¦e after bumping Calcite to v1.12.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/3689
[FLINK-5435] [table] Remove FlinkAggregateJoinTransposeRule and Flinkâ¦
â¦RelDecorrelator after calcite updated to 1.12
You can merge this pull request into a Git repository by running
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3623
Looks good to me, @twalthr @fhueske can you also take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108628810
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108628113
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/DeferredTypeFlinkTableFunction.scala
---
@@ -0,0 +1,64
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108625377
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108625307
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108624961
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108624874
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108624761
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108320480
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -86,12 +90,79 @@ abstract class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108320419
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala
---
@@ -27,52 +27,73 @@ import
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108319900
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala
---
@@ -27,52 +27,73 @@ import
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108318532
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -131,8 +202,10 @@ abstract class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108318419
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -86,12 +90,79 @@ abstract class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108318278
--- Diff: flink-core/src/test/java/org/apache/flink/types/RowTest.java ---
@@ -21,6 +21,7 @@
import org.junit.Test;
import static
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3553
Since `IF` is not sql standard, i think we could let java user just use
`case when`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3559#discussion_r106796945
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkPlannerImpl.scala
---
@@ -100,6 +101,7 @@ class FlinkPlannerImpl
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3406
Seems good to merge now, merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3560#discussion_r106772134
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala
---
@@ -227,18 +227,23 @@ object
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3560#discussion_r106669352
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala
---
@@ -227,18 +227,23 @@ object
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106606071
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -36,36
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3520
Sure, so the result is there will be 2 commits to master repository?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3520
Hi @fhueske, thanks for the review. I addressed all your comments and will
rebase to master to let travis check. Will merge this after build success.
---
If your project is set up for it, you can
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106568641
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/TableSourceTest.scala
---
@@ -0,0 +1,382 @@
+/*
+ * Licensed
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106566787
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/util/RexProgramTestBase.scala
---
@@ -16,106 +16,96
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106566599
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/util/RexProgramExtractorTest.scala
---
@@ -0,0 +1,347
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106566606
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/util/RexProgramExtractorTest.scala
---
@@ -0,0 +1,347
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106566042
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TestFilterableTableSource.scala
---
@@ -0,0 +1,142
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106565668
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -36,36
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106565688
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala
---
@@ -20,47 +20,40 @@ package
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3520
Hi @fhueske, you just pointed out a question i had when tonycox
implementing the first version. Why we are preventing `FilterableTableSource`
from modifying the expressions? I think it's totally
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3520
Hi @fhueske @godfreyhe, thanks for the review, i addressed most all your
comments.
@fhueske Except for letting `TableSourceScan` be aware of whether filter
has been pushed down. I'm
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106335718
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala
---
@@ -0,0 +1,66
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106335709
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala
---
@@ -0,0 +1,184
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106335660
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala
---
@@ -0,0 +1,184
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106329219
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/PushFilterIntoBatchTableSourceScanRule.scala
---
@@ -0,0
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106329225
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/PushFilterIntoStreamTableSourceScanRule.scala
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106328751
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/TableSourceTable.scala
---
@@ -25,6 +25,7 @@ import
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106329099
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala
---
@@ -0,0 +1,184
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106329079
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -0,0
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106327707
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -0,0
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106324883
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
@@ -58,16 +60,24 @@ class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106324868
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
---
@@ -39,4 +39,6 @@ trait TableSource[T
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106322568
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala
---
@@ -42,63 +41,40 @@ class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106321885
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/ProjectableTableSource.scala
---
@@ -24,7 +24,7 @@ package
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3530
looks good, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3530#discussion_r105869656
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/datastream/DataStreamUserDefinedFunctionITCase.scala
---
@@ -85,6
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3520
To address the problem of not reusing `TableSource` when we create a new
scan for table source, i changed some inheritance for current `BatchScan`,
`StreamScan`, `BatchTableSourceScan
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/3520
[FLINK-3849] [table] Add FilterableTableSource interface and rules for
pushing it
This PR is based on #3166 , and added following changes:
1. Refactor `RexProgramExpressionExtractor
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3510
Thanks @maocorte for the quick fix, looks good to merge now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105422108
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction<Tuple2<
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105419777
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction<Tuple2<
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105420103
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction<Tuple2<
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105420011
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction<Tuple2<
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105418830
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction<Tuple2<
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105417009
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction<Tuple2<
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3488
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3406
Hi @fhueske , i like your propose about moving the annotation from
`TableSource` to `TableSourceConverter`. Lets do it this way.
BTW, i noticed that you offered three possible methods
1 - 100 of 255 matches
Mail list logo
