Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5998
Thanks for the review @walterddr @fhueske , I've updated the PR.
---
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/6065
[FLINK-9420][TableAPI & SQL] Add tests for SQL IN sub-query operator in
streaming
## What is the purpose of the change
Add tests for SQL IN sub-query operator in strea
Github user Xpray commented on a diff in the pull request:
https://github.com/apache/flink/pull/5998#discussion_r190231602
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/setop/StreamIntersectCoProcessFunction.scala
---
@@ -0,0 +1,236
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/6027
@twalthr I've updated the PR.
Best.
---
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/6027
Thanks for the review @xccui , I've updated the PR.
Best.
---
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/6027
[FLINK-7814][TableAPI && SQL] Add BETWEEN and NOT BETWEEN expression to
Table API
## What is the purpose of the change
Add BETWEEN expression to Table API
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5998
[FLINK-9344] [TableAPI & SQL] Support INTERSECT and INTERSECT ALL for
streaming
[FLINK-9344] [TableAPI & SQL] Support INTERSECT and INTERSECT ALL for
streaming
## What is the
Github user Xpray commented on a diff in the pull request:
https://github.com/apache/flink/pull/5988#discussion_r187636663
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/CallGenerator.scala
---
@@ -64,17 +65,28 @@ object CallGenerator
Github user Xpray commented on a diff in the pull request:
https://github.com/apache/flink/pull/5988#discussion_r187636169
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/CallGenerator.scala
---
@@ -64,17 +65,28 @@ object CallGenerator
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5988
[FLINK-9332][TableAPI & SQL] Fix Codegen error of CallGenerator
## What is the purpose of the change
Fix bugs that nullTerm do not handle function call return value corre
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5878
@StephanEwen I've added a test case, please have a look. Best.
---
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5878
[FLINK-9216][Streaming] Fix comparator violation
## What is the purpose of the change
Fix Improper Comparator for sorting Operator Id.
## Brief change log
- if both ids are sink
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5613
@twalthr I'm fine with this PR.
Best
---
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5613
@twalthr yes that your PR have solved the urgent ones.
I have cases with huge unboxing code but we can still split it in this way.
As for large section codes of one field we may have to make
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5613
It looks great, how about splitting reuseInputUnboxCode as well? I found
UnboxingCode might be oversized and has to split.
---
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5608
@twalthr I've updated the PR, I think the new configuration in
`TableConfig` shall only be responsible for decimal division, other decimal
operations should have `UNLIMITED` context.
---
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5608
[FLINK-8821][TableAPI && SQL] Fix BigDecimal divide in AvgAggFunction
## What is the purpose of the change
fix BigDecimal divide issue in AvgAggFunction
## Brief ch
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5174
Thanks @twalthr, that's great, I'm also working on another issue trying to
move all local variables to class field, that'll make code split more
convenient.
---
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5438
@twalthr the PR has been updated, please have a look.
---
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5438
I've removed the ITCase and add some tests to
```org.apache.flink.table.expressions.MapTypeTest ```
---
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5438
[FLINK-8617][TableAPI & SQL] Fix code generation bug while accessing â¦
## What is the purpose of the change
fix code generation error in MapGet
## Brief change log
ha
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5409
[FLINK-8555][TableAPI & SQL] Fix TableFunction varargs length exceed 254
## What is the purpose of the change
*Support TableFunction parameters exceeds 254 with Varargs for
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5206
Hi, @sunjincheng121 , thanks for the comments, I've updated this PR.
---
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5203
Thanks to @sunjincheng121 , the PR has updated.
---
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5203
Thanks for @sunjincheng121 , I found another bug due to Expression Reduce
and fixed it, please have a look!
---
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5206
[FLINK-8312][TableAPI && SQL] Fix ScalarFunction varargs length exceeâ¦
## What is the purpose of the change
*Support parameters exceeds 254 with Varargs
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5203
[FLINK-8301] Support Unicode in codegen for SQL && TableAPI
## What is the purpose of the change
*support unicode literal in sql and handles code generation c
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5174
[FLINK-8274][TableAPI & SQL] Fix Java 64K method compiling limitationâ¦
[FLINK-8274][TableAPI & SQL] Fix Java 64K method compiling limitation for
CommonCalc'
## What is the
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5026
[FLINK-8095][TableAPI & SQL] Introduce ProjectSetOpTransposeRule to Fâ¦
## What is the purpose of the change
Introduce ProjectSetOpTransposeRule to Flink
## Brief ch
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4956
[FLINK-7986][TableAPI & SQL] Introduce FilterSetOpTransposeRule to Flink
## What is the purpose of the change
Introduce FilterSetOpTransposeRule to Flink
## B
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4941
[FLINK-7971][TableAPI & SQL] Fix potential NPE with inconsistent state
## What is the purpose of the change
fix potential NPE with inconsistent state
## Brief change
Github user Xpray commented on a diff in the pull request:
https://github.com/apache/flink/pull/4829#discussion_r145659580
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/stringexpr/StringExpressionTest.scala
---
@@ -0,0 +1,51
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4829
[FLINK-7759][TableAPI & SQL] Fix Bug that fieldName with Boolean prefâ¦
Fix Bug that fieldName with Boolean prefix can't be parsed by
ExpressionParser
## What is the purpose of the ch
Github user Xpray commented on a diff in the pull request:
https://github.com/apache/flink/pull/4785#discussion_r143430248
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
---
@@ -129,17 +129,19 @@ class
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4785
[FLINK-7776][TableAPI & SQL] remove duplicated records collecting in gâ¦
â¦roup aggregation
*Thank you very much for contributing to Apache Flink - we are happy that
you want to
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/4658
@twalthr , I've rewrite the methods, please have a look.
---
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/4658
what about overriding `leastRestrictiveSqlType` method in
`FlinkTypeFactory`?
---
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/4658
Thanks for your advice. I am considering a better way to solve this.
---
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4672
Flink 7621
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way
Github user Xpray commented on a diff in the pull request:
https://github.com/apache/flink/pull/4658#discussion_r137746521
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/type/SqlTypeFactoryImpl.java
---
@@ -0,0 +1,575 @@
+/*
+ * Licensed
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4658
Flink 7596
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/4496
I've moved the test case. @aljoscha
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Xpray commented on a diff in the pull request:
https://github.com/apache/flink/pull/4496#discussion_r131823239
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamOperatorChainingTest.java
---
@@ -37,7 +38,7 @@
import
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4496
[FLINK-7385] Fix ArrayIndexOutOfBoundsException when object-reuse is â¦
â¦enabled
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4308
[FLINK-7163] Make LogicalTableFunctionCall immutable
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/4200
I update the code, once calcite-1860 fixed, the ignored test case will pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Xpray commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124442541
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/datastream/DataStreamUserDefinedFunctionITCase.scala
---
@@ -230,6
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4200
[FLINK-7014] Expose isDeterministic interface to ScalarFunction and Tâ¦
â¦ableFunction
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/3502
I wondered when will this PR be merged? @DmytroShkvyra
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4077
[FLINK-6852] Fix misuse of GCD
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/3918
[FLINK-6593] Fix Bug in ProctimeAttribute or RowtimeAttribute with Coâ¦
â¦deGenerator
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/3880
[FLINK-6457] Clean up ScalarFunction and TableFunction interface
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user Xpray commented on a diff in the pull request:
https://github.com/apache/flink/pull/3791#discussion_r113855406
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/TableFunctionConversions.scala
---
@@ -0,0 +1,56
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/3791
[FLINK-6334] [table] Refactoring UDTF interface
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
54 matches
Mail list logo
