Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6373
Ran into this bug too.
+1 for the fix
---
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6300#discussion_r202199865
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6300#discussion_r202201507
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -330,4
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6319#discussion_r202198679
--- Diff: flink-container/docker/README.md ---
@@ -0,0 +1,44 @@
+# Apache Flink cluster deployment on docker using docker-compose
--- End diff
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6319#discussion_r202197686
--- Diff: flink-container/docker/README.md ---
@@ -0,0 +1,44 @@
+# Apache Flink cluster deployment on docker using docker-compose
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6109
cc @zentol
---
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6277#discussion_r201216406
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfiguration.java
---
@@ -93,4 +97,82 @@ public Time getTtl
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6290
+1, LGTM
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6195
Can you also add documentation to the Metrics page?
---
Github user bowenli86 closed the pull request at:
https://github.com/apache/flink/pull/6130
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6156
+1 LGTM
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6130
Not really. It's not about having n copies of data. One use case is
File-fed stream pipeline usually runs very fast with inadequate metrics, users
need to run it end-to-end for a longer time
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6130
@aljoscha
Motivation: We have the requirements to read a bunch files, each file to
read multiple times, to feed our streams
Specifically we need
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/6130
[FLINK-9545] Support read a file multiple times in Flink DataStream
## What is the purpose of the change
we need `StreamExecutionEnvironment.readFile/readTextFile` to read each
file
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r192834879
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/TimeoutLatch.java
---
@@ -0,0 +1,41
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r192837000
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -180,9
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6116
Will it lower the possibility of detecting lib version conflicts of Flink's
dependencies?
---
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6109#discussion_r192628940
--- Diff: docs/start/building.md ---
@@ -50,7 +50,11 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6109#discussion_r192535262
--- Diff: docs/start/building.md ---
@@ -50,7 +50,11 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/6109
[FLINK-9483] 'Building Flink' doc doesn't highlight quick build command
## What is the purpose of the change
The blue part isn't corrected highlighted as the red ones
![screen
Github user bowenli86 closed the pull request at:
https://github.com/apache/flink/pull/5649
---
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6104#discussion_r191858415
--- Diff: docs/dev/libs/cep.md ---
@@ -1524,7 +1524,52 @@ In `CEP` the order in which elements are processed
matters. To guarantee that el
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6104#discussion_r191857843
--- Diff: docs/dev/libs/cep.md ---
@@ -1524,7 +1524,52 @@ In `CEP` the order in which elements are processed
matters. To guarantee that el
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5649
When I was developing KeyedProcessFunction, I initially wondered why
there's no tests for KeyedStream, and researched and realized that they were
actually mixed with DataStream tests.
I
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6097
+1. I might forget to add the interfaces back then, would be good to have
them
---
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6066#discussion_r190342404
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperator.java
---
@@ -93,6 +93,20 @@
// state
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5978
Are there anything in `1.11.325` we desperately need?
If not, I would oppose upgrading AWS SDK too frequently. Highly likely that
we don't need any of the new changes in `1.11.325`. As you
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai adding docs to educate users on tuning KPL performance would be
good. I has quite some experience on it (as you may have know :) Ping me if
you start working on it before I do, and I'll
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189174902
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189175770
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189176708
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189176320
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5649
Hi @kl0u , can you pls take a look at this PR?
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5979
LGTM +1
---
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5979#discussion_r187255609
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBMapState.java
---
@@ -356,6
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5949#discussion_r185588020
--- Diff: docs/dev/event_time.md ---
@@ -35,30 +35,32 @@ Flink supports different notions of *time* in streaming
programs.
respective operation
Github user bowenli86 closed the pull request at:
https://github.com/apache/flink/pull/5937
---
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5937
[FLINK-9270] Upgrade RocksDB to 5.11.3, and resolve concurrent test
invocation problem of @RetryOnFailure
## What is the purpose of the change
- Upgrade RocksDB to 5.11.3 to take latest
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184831365
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,539 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184830451
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
---
@@ -455,4 +455,5 @@ public
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184831125
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java
---
@@ -190,4
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5887
@fhueske updated! let me know how it looks now
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5932
+1
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5910
+1
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5904
+1
---
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5887
[FLINK-6719] Add details about fault-tolerance of timers to ProcessFunction
docs
## What is the purpose of the change
The fault-tolerance of timers is a frequently asked questions
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5864
+1
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5864
does using Collections.EMPTY_MAP/EMPTY_SET lead to some warnings logging?
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5820
@zentol which scala checkstyle mvn plugin are you looking at? I didn't find
any available ones, and I'm afraid there might will not be one.
scalastyle explicitly said
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5820
[hotfix] removed unused scala imports
## What is the purpose of the change
removed unused scala imports
## Brief change log
removed unused scala imports
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5819
[FLINK-9140] [Build System] [scalastyle] simplify scalastyle configurations
## What is the purpose of the change
Simplifying `` to ``
## Brief change log
Simplifying
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5810
The original logging is correct - filesystem state backend is actually
memory state backend + filesystem checkpointing. No need to change the logging.
---
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5809
[FLINK-8697] [Kinesis Connector] Rename DummyFlinkKafkaConsumer in
KinesisDataFetcherTest
## What is the purpose of the change
`DummyFlinkKafkaConsumer` in `KinesisDataFetcherTest
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5800
cc @StephanEwen @tillrohrmann @zentol
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5760
cc @zentol
---
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5800
[FLINK-8837] add @Experimental annotation and properly annotate some
classes
## What is the purpose of the change
- add @Experimental annotation
- properly annotate some classes
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5760
[hotfix] [doc] fix maven version in building flink
## What is the purpose of the change
The maven version in `start/building` is inconsistent. Make it consistent
by changing the maven
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5702
Hi @zentol , can you take a look at this PR?
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5702
cc @zentol
---
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5702
[FLINK-8771] Upgrade scalastyle to 1.0.0
## What is the purpose of the change
Upgrade scalastyle from 0.8.0 to 1.0.0
## Brief change log
- Upgrade scalastyle from 0.8.0
Github user bowenli86 closed the pull request at:
https://github.com/apache/flink/pull/5356
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5649
cc @kl0u
---
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r174231064
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r174230739
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r174231142
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r174231173
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5680
shall we add a unit test?
---
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5677
[hotfix] update doc of InternalTimerService.registerEventTimeTimer()
## What is the purpose of the change
update doc of InternalTimerService.registerEventTimeTimer()
## Brief
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5663
Is your testing Flink job both reading from and writing to Kinesis, aka
both KCL and KPL are tested?
If so, +1
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5356
hmmm I think you are right, this actually might be a non-issue in the
first place
---
Github user bowenli86 closed the pull request at:
https://github.com/apache/flink/pull/5365
---
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r172935414
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapper.java
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r172935214
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapper.java
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r172934683
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapper.java
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5649
[FLINK-8873] [DataStream API] [Tests] move unit tests of KeyedStream from
DataStreamTest to KeyedStreamTest
## What is the purpose of the change
move unit tests of `KeyedStream` from
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5501
LGTM, +1 on merging to 1.6.0
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5481
@kl0u @aljoscha I added the scala example, and I believe the only build
failure in Travis is irrelevant
---
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r172306197
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java
---
@@ -0,0 +1,480
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r172303424
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/JoinedStreams.java
---
@@ -137,6 +158,151 @@ public EqualTo
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r172302147
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/JoinedStreams.java
---
@@ -137,6 +158,151 @@ public EqualTo
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r172302583
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/JoinedStreams.java
---
@@ -137,6 +158,151 @@ public EqualTo
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r172303671
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java
---
@@ -0,0 +1,480
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5616
need to add to java API as well
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5481
@kl0u I added the comments for `@deprecated` in the javadoc. Let me know if
you can merge the two related PRs. Thanks
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5500
@kl0u @aljoscha I've updated this PR, and its build is green
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5500
@tillrohrmann @kl0u Thanks for reviewing, guys
As @pnowojski mentioned, we three decided to expose timer keys in
`ProcessFunction` in [FLINK-8560](https://github.com/apache/flink/pull
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5500
Hi @aljoscha , can you take a look?
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5481
Thanks for the review and suggestions. And your comment on
`DataStream#process(KeyedProcessFunction)` makes sense, I've removed it.
(btw, I feel https://github.com/apache/flink/pull/5500
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5481
cc @pnowojski @aljoscha
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5522
cc @tillrohrmann
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5500
cc @pnowojski @aljoscha
---
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5537
[FLINK-8719] add module description for flink-contrib to clarify its purpose
## What is the purpose of the change
flink-contrib currently doesn't have any clarification or description
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5500
a irrelavent flaky unit test caused the error in travis build, and I've
filed [FLINK-8709](https://issues.apache.org/jira/browse/FLINK-8709) for it
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5522
the failure in travis build is irrelevant
---
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5522
[hotfix] [javadoc] fix wrong javadoc in AbstractYarnClusterDescriptor
## What is the purpose of the change
hotfix of javadoc in AbstractYarnClusterDescriptor
## Brief change log
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5500
@pnowojski @aljoscha I updated the code. Hopefully we can make this into
1.5.0! Thanks!
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5501
LGTM generally.
I still feel having all the `instanceof` in `notifyOfAddedMetric` and
`notifyOfRemovedMetric` is a bit inelegant. I'm fine with it since there'll
(hopefully) be only
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r168891314
--- Diff: docs/ops/state/large_state_tuning.md ---
@@ -234,4 +234,97 @@ Compression can be activated through the
`ExecutionConfig`:
**Notice
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5500#discussion_r168855562
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperator.java
---
@@ -324,6 +324,11
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5500
cc @aljoscha @pnowojski
---
1 - 100 of 497 matches
Mail list logo
