Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/2459
Hi @shijinkui, thanks for opening pull request. Unfortunately, this pull
request cause a problem with maven shading plugin
(https://issues.apache.org/jira/browse/MSHADE-200). Due to the problem
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76580310
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,286 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76552087
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -159,3 +183,68 @@ case class
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551557
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,286 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551568
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,286 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551191
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,286 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551144
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,286 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551077
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMapper.scala
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551066
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMapper.scala
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551085
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMapper.scala
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76550871
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/Block.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76550821
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/Block.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76550602
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/Block.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/2152
Sorry for long no response. Could you give me few days more? I'll review in
weekend. Sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68891682
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/math/distributed/BlockMatrixSuite.scala
---
@@ -0,0 +1,106
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/2152
This PR contains unnecessary code changes related to `DistributedRowMatrix`
(`DistributedRowMatrix.scala` and `DistributedRowMatrixSuite.scala`). Please
sync this PR with current master
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68885212
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696822
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696809
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696680
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696692
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696490
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696421
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/2152
Thanks for opening pull request @chobeat! I would like to shepherd this PR.
I'll review in weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/1985
Hi @skavulya, sorry for late response. I've checked the updated PR and
looks good to me. I wonder whether the name `RegularizationPenalty` is proper
because the class calculates lots of values
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/1996
Looks good to me, +1. I'll merge this in few hours.
But I think we should change the type of row index to `Long` in near
future. I think we can deal with the incompatibility problem
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r68041009
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,162
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/2076
Failing Travis is not related to this PR. Looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2076#discussion_r6588
--- Diff: flink-java/src/test/resources/logback-test.xml ---
@@ -0,0 +1,34 @@
+
+
+
+
+
+%d{HH:mm:ss.SSS
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2076#discussion_r6573
--- Diff: flink-java/src/test/resources/log4j-test.properties ---
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65688309
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,162
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65657170
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,166
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/1985
Okay, please ping me when the PR is updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65355487
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,166
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1996
@chobeat Okay. Then we should force user to calculate dimensionality of
matrix by changing type of number parameters in constructor.
---
If your project is set up for it, you can reply
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65311449
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,179
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1996
Hi @chobeat, thanks for update PR. After addressing comments on source
code, I think the last thing to merge this is adding documentation for this.
But you can add the documentation after
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65309988
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,179
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65309186
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,179
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65309134
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,182
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1985
Hi @skavulya, I just quickly reviewed your updated PR and left few
comments. They are not critical things but It would be better to fix them.
Other things are very good.
---
If your
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1985#discussion_r65291933
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/optimization/RegularizationPenaltyTest.scala
---
@@ -0,0 +1,65
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1985#discussion_r65291911
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/optimization/LossFunctionTest.scala
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1985#discussion_r65291552
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/RegularizationPenalty.scala
---
@@ -0,0 +1,215
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1985#discussion_r65291461
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/PartialLossFunction.scala
---
@@ -47,21 +47,106 @@ object SquaredLoss
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1985#discussion_r65291353
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/PartialLossFunction.scala
---
@@ -47,21 +47,106 @@ object SquaredLoss
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/2056
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/2056
Thanks for clarifying @StephanEwen! I'll merge this after Travis succeed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/2056
Thanks for guide @mxm. I'll set upper limit for the parallelism to 4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/2056
[FLINK-3994] [ml, tests] Fix flaky KNN integration tests
This PR is related to flaky KNN integration tests. The problem is caused by
sharing `ExecutionEnvironment` between test cases. I'm
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/2052#issuecomment-222644723
Hi @danielblazevski, thanks for opening pull request. But we need a related
JIRA issue for this. Could you create an issue and change title of this PR?
---
If your
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65145402
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,167
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/757#issuecomment-222599628
Any updates on this? If there is no update, I would like to push additional
effort based on this.
---
If your project is set up for it, you can reply to this email
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/2017#issuecomment-222577020
Thanks for review @StephanEwen! Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65102583
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,182
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65102444
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,167
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65076170
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,167
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1996#issuecomment-222488228
There are some public methods (`sum`, `subtract`, `byRowOperation`, etc.)
without scaladoc. Please add scaladoc for the methods.
---
If your project is set up
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65067628
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,167
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65066995
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,167
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-222482793
@danielblazevski I'm using a custom configuration of IntelliJ code
formatter. There is a pending [pull
request](https://github.com/apache/flink/pull/1963/files
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65064961
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,167
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65063499
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,167
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65060611
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,167
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65060576
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedMatrix.scala
---
@@ -0,0 +1,25
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r65060527
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedMatrix.scala
---
@@ -0,0 +1,25
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1996#issuecomment-222473905
Hi @chobeat, thanks for opening pull request. I would like to shepherd this
PR.
---
If your project is set up for it, you can reply to this email and have your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/2048#issuecomment-222397141
Hi @danielblazevski, thanks for opening pull request. I would like to split
approximative knn and exact knn. If the approximative method needs exact knn
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/2017#issuecomment-220833561
Failing Travis is not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/2017
[FLINK-2673] [type system] Add a comparator for Scala Option type
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r63815357
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r63712972
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-219702506
Great to hear that z-knn is almost done! If you think the implementation
has good shape, do not hesitate to open a pull request.
---
If your project is set up
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-219203934
I would like to merge this PR. I've checked the output of k-NN join (with,
without quadtree). Documentation looks good.
To maintainers (@tillrohrmann
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-215369160
@danielblazevski Sorry for late check. I check your PR and have few
comments. After addressing, I would like to merge this.
---
If your project is set up
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r61398228
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/classification/Classification.scala
---
@@ -131,3 +131,6 @@ object Classification
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r61398006
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala
---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r61397870
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r61397754
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r61397659
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r61397574
--- Diff: docs/libs/ml/knn.md ---
@@ -0,0 +1,146 @@
+---
+mathjax: include
+htmlTitle: FlinkML - k-nearest neighbors
+title: FlinkML - knn
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r61397472
--- Diff: docs/libs/ml/knn.md ---
@@ -0,0 +1,146 @@
+---
+mathjax: include
+htmlTitle: FlinkML - k-nearest neighbors
+title: FlinkML - knn
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r61397325
--- Diff: docs/libs/ml/knn.md ---
@@ -0,0 +1,146 @@
+---
+mathjax: include
+htmlTitle: FlinkML - k-nearest neighbors
+title: FlinkML - knn
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r61397260
--- Diff: docs/libs/ml/knn.md ---
@@ -0,0 +1,146 @@
+---
+mathjax: include
+htmlTitle: FlinkML - k-nearest neighbors
+title: FlinkML - knn
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r61397191
--- Diff: docs/libs/ml/knn.md ---
@@ -0,0 +1,146 @@
+---
+mathjax: include
+htmlTitle: FlinkML - k-nearest neighbors
+title: FlinkML - knn
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r61397153
--- Diff: docs/libs/ml/knn.md ---
@@ -0,0 +1,146 @@
+---
+mathjax: include
+htmlTitle: FlinkML - k-nearest neighbors
+title: FlinkML - knn
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-209854438
Hi @danielblazevski, sorry for late reply. I checked your updated PR but
your last commit (d6f90ce) seems wrong. The commit removes KNN.scala,
QuadTree.scala
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-206350336
Ah, right @rmetzger. We can go ahead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-206345431
I just found the author email is not same as @nikste's github account. It
is trivial but fixing email address would be better.
---
If your project is set up
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-206344388
Looks good to me. +1
I tested a simple streaming word count example with socket stream in
following configuration:
* Flink on Hadoop YARN 2.7.2 (both
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-205274226
I prefer `senv` and `benv` because it is shorter than `streamEnv` and
`batchEnv`. In shell, shorter variables would be better even though there is a
auto-complete
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1837#issuecomment-203323834
I tested this PR in local cluster. Looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1836#issuecomment-202022859
Nice catch. I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1500#issuecomment-200804302
Oh, thanks for pointing it @mxm. Then I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1500#issuecomment-199796720
Hi all, I would like to merge this. If there is no objection and travis
passes, I'll merge this to master in few days.
---
If your project is set up for it, you can
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1825#issuecomment-199775815
Merged. Thanks for review @aljoscha!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1786#issuecomment-199704337
+1, Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/1825
[FLINK-3645] [tests] HDFSCopyUtilitiesTest fails in a Hadoop cluster
Please check [JIRA](https://issues.apache.org/jira/browse/FLINK-3645).
`HDFSCopyUtilitiesTest` should use local file system
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-199648335
Hi @danielblazevski, thanks for update! Looks good to me for
implementation. (Some minor issues and rebasing will be addressed by me.)
About docs, I meant we
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1814#issuecomment-199640748
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
1 - 100 of 583 matches
Mail list logo
