Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4502
@twalthr Have updated the PR and looking forward to your comments.
---
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5141#discussion_r159149194
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java
---
@@ -191,22 +191,28 @@ public boolean isEmpty
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5141#discussion_r158909117
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java
---
@@ -82,9 +82,12 @@
private transient Map&l
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5141#discussion_r158908615
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java
---
@@ -82,9 +82,12 @@
private transient Map&l
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5141#discussion_r15833
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java
---
@@ -82,9 +82,12 @@
private transient Map&l
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5142
The page number is the number of patterns and so it is usually very small.
The `long` is only needed in theory just as you said MAX_INT * MAX_INT
resulting to MAX_LONG. If this makes sense
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5141
@dawidwys Could you help to take a look at this PR? This is a bug fix and
the issue can be easily reproduced with the test case included in the PR.
Thanks a lot.
---
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5142
@dawidwys @StephanEwen Sorry for late response. For question 1 and 2, I
have the same thought with @dawidwys and have updated the PR accordingly. For
question 3, I think `int` is enough as we
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/5142
[FLINK-8227] Optimize the performance of SharedBufferSerializer
## What is the purpose of the change
*This pull request optimize the performance of SharedBufferSerializer
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/5141
[FLINK-8226] [cep] Dangling reference generated after NFA clean up timed
out SharedBufferEntry
â¦med out SharedBufferEntry
*Thank you very much for contributing to Apache Flink - we
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5063
The current known impact is that it will need to checkpoint more timer. For
the impact to performance, I will do some benchmark later. :)
I think we only need to consider this optimization
Github user dianfu closed the pull request at:
https://github.com/apache/flink/pull/5036
---
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5036
Close this PR for the same reason as #5063
---
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5063
For historical reasons, we only use punctuated watermark currently. But I
think you are right, we should consider using periodic watermark instead.
Thanks a lot for your explanation. I will close
Github user dianfu closed the pull request at:
https://github.com/apache/flink/pull/5063
---
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5063
@fhueske Thanks a lot for your comments. Definitely agree with you on the
motivation of punctuated watermark. But in practice, there are many cases there
is no watermark information in the source
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/5080
[FLINK-8159] [cep] Add rich support for SelectWrapper and FlatSelectWrapper
## What is the purpose of the change
*This pull request add the rich support for SelectWrapper
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5063
@fhueske Yes, the bad performance is related to the way we generate the
watermarks. But this is the way how punctuated watermark works. If we do not
optimize for punctuated watermark, then are we
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5063#discussion_r152955709
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RowTimeUnboundedOver.scala
---
@@ -116,7 +116,7 @@ abstract
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5063
{{AbstractKeyedCEPPatternOperator}} has similar logic as
{{RowTimeUnboundedOver}}. As described in FLINK-8106, we find that the
performance is very bad under the current logic
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/5063
[FLINK-8144] [table] Optimize the timer logic in RowTimeUnboundedOver
## What is the purpose of the change
*This pull request optimize the timer handling in RowTimeUnboundedOver.
Currently
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/5036
[FLINK-8106] [cep] Optimize the timer logic in
AbstractKeyedCEPPatternOperator
## What is the purpose of the change
*This pull request optimize the performance
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5025#discussion_r151625442
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -234,11 +234,12 @@ abstract class
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5025#discussion_r151609882
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/TimeAttributesITCase.scala
---
@@ -179,6 +179,32 @@ class
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5025#discussion_r151609700
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -234,11 +234,12 @@ abstract class
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/5027
[FLINK-8097] [table] Add built-in support for min/max aggregation for
Date/Time
## What is the purpose of the change
*This PR adds built-in support for min/max aggregation for Date/Time
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/5025
[FLINK-8096] [table] Fix time material issue when write to TableSink
## What is the purpose of the change
*This pull request fix the time material issue when write to TableSink
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4936
@wuchong Thanks a lot for your review.
@fhueske It would be great if you can also give some feedback.
---
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4936
[FLINK-7962] Add built-in support for min/max aggregation for Timestamp
## What is the purpose of the change
*This JIRA adds the built-in support for min/max aggregation for Timestamp
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4502
@fhueske Could you help to take a look at this PR in case you missed? This
PR has been ready for more than one month. Very appreciated.
---
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
@dawidwys Any comments?
---
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
@dawidwys It would be great if you could take a look. Very appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r135441351
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -421,6 +437,15 @@ private void
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r135440842
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -526,18 +551,32 @@ private boolean
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4296
Sure. Have created FLINK-7496 to track this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
@dawidwys I have updated the PR and it currently only contains changes of
the RichFunction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4563
@dawidwys Have updated the PR according to your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4563
Thanks @dawidwys for the suggestion. I will update the PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
Thanks @dawidwys for the remind. Yes, you're right and that make sense to
me. I will update the the PR and remove ConditionRegistry related changes.
---
If your project is set up for it, you can
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4563
[FLINK-7479] [cep] Support to retrieve the past event by an offset
## What is the purpose of the change
*Currently, it's already able to retrieve events matched to the specifed
pattern
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4502
@fhueske @kl0u @dawidwys @wuchong Any feedback?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4523
@kl0u That's OK. Thanks a lot. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
@dawidwys @kl0u In case you missed this PR, could you help to take a look
at? Very appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4523
@dawidwys @kl0u Could you help to take a look at this PR? Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r132867483
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -340,6 +362,65 @@ public void resetNFAChanged
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4523
[FLINK-7123] [cep] Support timesOrMore in CEP
## What is the purpose of the change
*This pull request adds timesOrMore to CEP pattern API*
## Verifying this change
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4502
@fhueske Great, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4296
@dawidwys Any comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
As discussed with @wuchong offline, I will continue the work of #4145 as
this is required by the feature of cep on sql, see the PR of FLINK-7062 for
details.
@dawidwys @kl0u Could you help
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4513
[FLINK-6938][FLINK-6939] [cep] Not store IterativeCondition with NFA state
and support RichFunction interface
## What is the purpose of the change
*The core idea is that the StateTransition
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4502
@kl0u @dawidwys @wuchong It will be great if you could take a look at this
PR. This PR add the basic support for cep on sql. Thanks in advance. :)
---
If your project is set up for it, you can reply
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4502
[FLINK-7062] [table, cep] Support the basic functionality of MATCH_RECOGNIZE
## What is the purpose of the change
*This pull request adds the basic support of MATCH_RECOGNIZE
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r131804949
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GreedyITCase.java
---
@@ -0,0 +1,1068 @@
+/*
+ * Licensed to the Apache
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r131804902
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GreedyITCase.java
---
@@ -0,0 +1,1068 @@
+/*
+ * Licensed to the Apache
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r131804887
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GreedyITCase.java
---
@@ -0,0 +1,1068 @@
+/*
+ * Licensed to the Apache
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r131804932
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GreedyITCase.java
---
@@ -0,0 +1,1068 @@
+/*
+ * Licensed to the Apache
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r131804764
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -637,9 +675,23 @@ private boolean
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r131804398
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -386,6 +387,19 @@ private void
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4418
@kl0u Good catch. Have updated the PR according to the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4296
@dawidwys Regarding to the times().greedy(), the result is not expected and
have fixed the issue in the latest PR. Also updated the doc.
---
If your project is set up for it, you can reply
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4418
@dawidwys Updated the contribution checklist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4418
@dawidwys Thanks a lot for your review. Have updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4418#discussion_r130896153
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java
---
@@ -923,6 +934,126 @@ public boolean filter(Event
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4418#discussion_r130896034
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -257,7 +289,32 @@ public void
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4418#discussion_r130896085
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java
---
@@ -923,6 +934,126 @@ public boolean filter(Event
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4418#discussion_r130895852
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/CEP.scala
---
@@ -36,8 +38,26 @@ object CEP {
* @tparam T Type
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4418#discussion_r130895782
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/CEP.java ---
@@ -38,4 +40,17 @@
public static PatternStream pattern
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r130883414
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -657,25 +663,34 @@ private boolean
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4373#discussion_r130829080
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/JoinTest.scala
---
@@ -55,12 +55,13 @@ class JoinTest extends
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4373#discussion_r130801549
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/JoinTest.scala
---
@@ -55,12 +55,13 @@ class JoinTest extends
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4373
I have did some investigation of the test failure of
**JoinITCase.testJoinWithExpressionPreds** and would like to share my findings
and solutions for your reference. The cause of this issue
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r130264164
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -551,18 +579,47 @@ private boolean isSelfIgnore(final
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r130266394
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -551,18 +579,47 @@ private boolean isSelfIgnore(final
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r130264936
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -551,18 +579,47 @@ private boolean isSelfIgnore(final
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r130265354
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -551,18 +579,47 @@ private boolean isSelfIgnore(final
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4418
[FLINK-7293] [cep] Support custom order by in PatternStream
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4331
Sorry for late response. I think this feature is very useful and agree that
we should have a clear thought on what things should be for each skip strategy.
I noticed that there are already some
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4296
@dawidwys Thanks a lot for the review. I have updated the patch. Currently,
there is something wrong when the greedy state is followed by an optional
state. This can be covered by test case
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r129832284
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GreedyITCase.java
---
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r129830324
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Quantifier.java
---
@@ -105,6 +107,14 @@ public void optional
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r129830367
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Pattern.java
---
@@ -492,4 +506,10 @@ private void checkIfQuantifierApplied
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4296
@dawidwys OK. Have a good time. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4296
@dawidwys Could you help to take a look at this PR? Thanks a lot in advance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4318
[FLINK-7170] [cep] Fix until condition when the contiguity is strict
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4296
[FLINK-7147] [cep] Support greedy quantifier in CEP
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4153
@dawidwys Thanks a lot for the review. Updated the doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4153
@dawidwys thanks a lot for your comments. Have updated the PR and it should
have addressed all the comments. :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125178823
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GroupITCase.java
---
@@ -0,0 +1,807 @@
+/*
+ * Licensed to the Apache
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125176853
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GroupITCase.java
---
@@ -0,0 +1,807 @@
+/*
+ * Licensed to the Apache
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125176801
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GroupITCase.java
---
@@ -0,0 +1,807 @@
+/*
+ * Licensed to the Apache
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125176457
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GroupITCase.java
---
@@ -0,0 +1,807 @@
+/*
+ * Licensed to the Apache
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125176383
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GroupITCase.java
---
@@ -0,0 +1,807 @@
+/*
+ * Licensed to the Apache
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125176384
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GroupITCase.java
---
@@ -0,0 +1,807 @@
+/*
+ * Licensed to the Apache
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125173912
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Pattern.java
---
@@ -430,6 +431,54 @@ public Quantifier getQuantifier
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125173877
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/TimesRangeITCase.java
---
@@ -92,6 +92,57 @@ public boolean filter(Event value
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125173876
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Quantifier.java
---
@@ -153,9 +153,8 @@ public int hashCode
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125173871
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFAStateNameHandler.java
---
@@ -55,6 +55,11 @@ public void
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125173832
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -455,6 +548,76 @@ private void
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125173828
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -455,6 +548,76 @@ private void
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4153#discussion_r125173760
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Pattern.java
---
@@ -366,8 +366,9 @@ public Quantifier getQuantifier
1 - 100 of 136 matches
Mail list logo
