Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3124
This PR can be closed. PR #5491 added a TableSource that supports nested
JSON data.
Thanks, Fabian
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3609
This PR can be closed as it will be addressed by FLINK-9714.
Thanks, Fabian
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6341
Thanks for the fix @AlexanderKoltsov!
I'll merge this.
---
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/6393
[FLINK-9296] [table] Add support for non-windowed DISTINCT aggregates.
## What is the purpose of the change
- Fix a regression from 1.5 that was caused by rearranging optimization
rules
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6267#discussion_r200478425
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetUnion.scala
---
@@ -36,22 +39,21 @@ import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6267#discussion_r200478336
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetUnion.scala
---
@@ -36,22 +39,21 @@ import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6267#discussion_r200480534
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/batch/sql/JavaSqlITCase.java
---
@@ -73,6 +73,30 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6267#discussion_r200478263
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetUnion.scala
---
@@ -36,22 +39,21 @@ import
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6161
Documentation fixes are usually not critical to include in a release
because the docs are always built from the most recent release branch. So also
documentation changes that are not included
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6255
Thanks for the update @hequn8128.
I'll merge this
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6252
Thanks for the update @HeartSaVioR.
I'll merge this
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6253
Thanks for the update @HeartSaVioR.
I'll merge this
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6252
Looks good. Just one last comment.
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6252#discussion_r200345063
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionUtils.scala
---
@@ -22,13 +22,16 @@ import java.lang
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6255#discussion_r200333630
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/HarnessTestBase.scala
---
@@ -384,4 +386,12 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6255#discussion_r200330683
--- Diff: docs/dev/table/streaming.md ---
@@ -591,16 +589,14 @@ qConfig.withIdleStateRetentionTime(Time.hours(12);
val qConfig: StreamQueryConfig
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6253
It's a good question whether to add a new class or not. Right now,
extending the implementation of `ExistingField` seems like a better approach to
me. Once we add a `ParsingExistingField` extractor
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6252
I think it can also be a new public method in
`org.apache.flink.table.expressions.ExpressionUtils`.
Thanks, Fabian
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6252
Thanks for opening this PR @HeartSaVioR! (cc @twalthr)
I thought about this again and I don't think we should make the method
public. The problem is that `Expression` is one of the core
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6188
Hmm, I think there is still a case for `timestampAdd`. The problem are time
intervals with variable length such as `MONTH`, `QUARTER`, and `YEAR`. All of
these cannot be defined by milliseconds
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6201
Hi @suez1224, that sounds good overall. :-)
A few comments:
- I would not add a user-facing property `connector.support-timestamp`
because a user chooses that by choosing
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199743600
--- Diff: docs/dev/table/tableApi.md ---
@@ -2184,6 +2184,17 @@ NUMERIC.atan()
+
+
+{% highlight
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6161
Thanks @snuyanzin!
+1 to merge
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199500643
--- Diff: docs/dev/table/sql.md ---
@@ -1510,6 +1510,17 @@ ATAN(numeric)
+
+
+{% highlight text
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199504092
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/mathExpressions.scala
---
@@ -243,6 +243,16 @@ case class Atan
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199501131
--- Diff: docs/dev/table/tableApi.md ---
@@ -3748,6 +3759,17 @@ NUMERIC.atan()
+
+
+{% highlight
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199500973
--- Diff: docs/dev/table/tableApi.md ---
@@ -2184,6 +2184,17 @@ NUMERIC.atan()
+
+
+{% highlight
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199501083
--- Diff: docs/dev/table/tableApi.md ---
@@ -3748,6 +3759,17 @@ NUMERIC.atan()
+
+
+{% highlight
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199500813
--- Diff: docs/dev/table/sql.md ---
@@ -1510,6 +1510,17 @@ ATAN(numeric)
+
+
+{% highlight text
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199501001
--- Diff: docs/dev/table/tableApi.md ---
@@ -2184,6 +2184,17 @@ NUMERIC.atan()
+
+
+{% highlight
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6226
Thanks for the update @snuyanzin.
Looks good. Will merge it.
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r199485393
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -1029,6 +1029,29 @@ object
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6123
I'm with Till here. The example JARs add very little value. I would be OK
with adding them if this was lightweight, but each example will include the
Table API and its dependencies (incl. Calcite
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199204037
--- Diff: docs/dev/table/sql.md ---
@@ -176,9 +181,20 @@ groupItem:
| ROLLUP '(' expression [, expression ]* ')'
| GROUPING SETS '(' groupItem
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199204120
--- Diff: docs/dev/table/sql.md ---
@@ -176,9 +181,20 @@ groupItem:
| ROLLUP '(' expression [, expression ]* ')'
| GROUPING SETS '(' groupItem
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199205419
--- Diff: docs/dev/table/sql.md ---
@@ -176,9 +181,20 @@ groupItem:
| ROLLUP '(' expression [, expression ]* ')'
| GROUPING SETS '(' groupItem
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199209179
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/OverWindowTest.scala
---
@@ -44,7 +44,26 @@ class OverWindowTest
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r199190279
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -1029,6 +1029,29 @@ object
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6201
Hi, I think timestamp fields of source-sink tables should be handled as
follows when emitting the table:
- `proc-time`: ignore
- `from-field`: simply write out the timestamp as part
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6180
Thanks for the update @yzandrew.
Merging
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6153
Looks good.
+1 to merge
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6163
Thanks for the PR @kisimple
+1 to merge.
Best, Fabian
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6180#discussion_r197453235
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala
---
@@ -132,74 +132,80
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6180#discussion_r197453796
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala
---
@@ -132,74 +132,80
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6131
Hi @zjffdu, thanks for the fix!
+1 to merge
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6082
I think we have to return an typed array here. A `List` won't be supported
by the built-in SQL functions.
There are a few tricks on can play to create typed arrays, even in static
code
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6082
We treat sequences of values as arrays in SQL and the Table API. There are
no built-in functions to handle lists. So we should return the values as an
array, and hence don't need a List type.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6106
Oh... Thanks for fixing that :-)
+1 to merge
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6099
Thanks for the PR @snuyanzin!
We cannot update the Calcite version to a `SNAPSHOT` version and have to
wait until Calcite 1.17 is released before continuing with this PR.
Best, Fabian
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r190176842
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/KeyedProcessFunctionWithCleanupState.scala
---
@@ -44,8
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5998#discussion_r190171657
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/setop/StreamIntersectCoProcessFunction.scala
---
@@ -0,0 +1,236
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6039
Thanks, I'll also commit an empty release notes page to the 1.6 / master
docs.
---
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/6039
[hotfix] [docs] Add Release Notes for Flink 1.5.
## What is the purpose of the change
* Add release notes for Flink 1.5 to the documentation
## Brief change log
* Add page
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5961
Thanks for the update @snuyanzin. I'll try to have a look at the changes in
the next days.
Best, Fabian
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6012
Fix looks good.
+1
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6001
Thanks for the fix @yanghua. I left a minor comment.
Otherwise +1 to merge.
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6001#discussion_r187871263
--- Diff: docs/dev/stream/operators/windows.md ---
@@ -883,7 +883,7 @@ private static class AverageAggregate
@Override
public Double
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5897
Thanks, @StephanEwen.
I will later merge this for `release-1.4` and `release-1.5`. Should we
merge it for `master` as well and create a JIRA to drop the deprecated code?
That would ensure
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5988
Merging
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5860
Merging
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5988#discussion_r187710610
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/CallGenerator.scala
---
@@ -64,17 +65,28 @@ object CallGenerator
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5860
Hi @glaksh100, thanks for the update!
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5988#discussion_r187577471
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
---
@@ -686,6 +686,28 @@ class SqlITCase
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5988#discussion_r187575678
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/CallGenerator.scala
---
@@ -64,17 +65,28 @@ object CallGenerator
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5988#discussion_r187568481
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/CallGenerator.scala
---
@@ -64,17 +65,28 @@ object CallGenerator
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5969
thanks for the PR @tzulitai.
The new e2e tests passed on my machine. The changes look good as well.
+1 to merge
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5961#discussion_r186528901
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/typeutils/FieldAccessorTest.java
---
@@ -368,4 +369,23 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5961#discussion_r186484649
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/operator/MaxByOperatorTest.java
---
@@ -230,4 +235,43 @@ public String toString
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5961#discussion_r186477977
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/functions/SelectByMinFunction.java
---
@@ -41,7 +41,7 @@
* is regarded in the reduce
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5961#discussion_r186527205
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -157,15 +156,15 @@ public T set(T record
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5961#discussion_r186527277
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -197,7 +196,7 @@ public T set(T record, F
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3765
The features that this PR was going to implement has been resolved by PR
#.
I will close it.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3764
This PR has been integrated into #5940.
I'll close it.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5940
merging
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5927
merging
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5927
Thanks for the update @pavel-shvetsov-git.
+1 to merge
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5940
Thanks for the update @walterddr.
The PR is good to merge.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5860
Hi @glaksh100,
I just noticed that the bucket closing check is only done when a record is
written. Hence, inactive buckets might not get closed in time if a larger
inactive bucket interval
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5940
Hmmm, good point. The discussion would be lost.
How about I put your changes on top of Haohui's changes before merging?
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5940#discussion_r186033706
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
---
@@ -52,6 +52,76 @@ class SqlITCase
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5940#discussion_r186022377
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -641,7 +641,8 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5940#discussion_r186029985
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/DistinctAggregateTest.scala
---
@@ -0,0 +1,173
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5940#discussion_r185955967
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -641,7 +641,8 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5940#discussion_r186036107
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
---
@@ -52,6 +52,76 @@ class SqlITCase
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5940#discussion_r186033401
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
---
@@ -52,6 +52,76 @@ class SqlITCase
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5836#discussion_r185942219
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/datastream/SplitSideOutputTest.java
---
@@ -0,0 +1,75
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5836#discussion_r185942147
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/datastream/SplitSideOutputTest.java
---
@@ -0,0 +1,75
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5927
Thanks for the PR @pavel-shvetsov-git!
I've left a suggestion to improve the error message.
Afterwards the PR should be good to merge.
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5927#discussion_r185932952
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -550,6
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5909
Thanks for cleaning up the syntax highlighting @zentol!
+1 to merge
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5860
Thanks for the update @glaksh100! The changes look good to me.
What do you think @aljoscha?
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5887
Thanks for the update @bowenli86.
I'll merge the PR later.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5935
Thanks for the fix @yanghua!
+1 to merge
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5899
Hi @bitsilly, as @sihuazhou please describe the purpose of this PR.
Also please translate the comments to English.
Thanks, Fabian
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3783
Hi @huawei-flink ,
I'll close this PR later today when merging #.
# adds runtime support for distinct aggregation and follows a similar
approach as this PR. However, it leverages
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184442107
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184419816
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala
---
@@ -47,60 +51,51 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184405910
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/#discussion_r184405329
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala
---
@@ -50,6 +50,155 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5867#discussion_r184099775
--- Diff: flink-dist/src/main/resources/flink-conf.yaml ---
@@ -229,17 +229,26 @@ web.port: 8081
# Directory to upload completed jobs to. Add
1 - 100 of 6115 matches
Mail list logo
