[GitHub] flink pull request #6282: [FLINK-6847][FLINK-6813][Table Api & Sql] Timestam...

2018-07-22 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6282#discussion_r204230530 --- Diff: docs/dev/table/tableApi.md --- @@ -4490,6 +4490,16 @@ dateFormat(TIMESTAMP, STRING

[GitHub] flink pull request #6282: [FLINK-6847][FLINK-6813][Table Api & Sql] Timestam...

2018-07-22 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6282#discussion_r204230536 --- Diff: docs/dev/table/tableApi.md --- @@ -4490,6 +4490,16 @@ dateFormat(TIMESTAMP, STRING

[GitHub] flink pull request #6282: [FLINK-6847][FLINK-6813][Table Api & Sql] Timestam...

2018-07-22 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6282#discussion_r204230539 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -338,3 +341,66 @@ case class DateFormat

[GitHub] flink pull request #6282: [FLINK-6847][FLINK-6813][Table Api & Sql] Timestam...

2018-07-22 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6282#discussion_r204230534 --- Diff: docs/dev/table/tableApi.md --- @@ -4490,6 +4490,16 @@ dateFormat(TIMESTAMP, STRING

[GitHub] flink pull request #6282: [FLINK-6847][FLINK-6813][Table Api & Sql] Timestam...

2018-07-22 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6282#discussion_r204230537 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -338,3 +341,66 @@ case class DateFormat

[GitHub] flink issue #6337: [FLINK-9853][Tabel API & SQL] add HEX support

2018-07-20 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6337 Thanks for your PR. +1 to merge. ---

[GitHub] flink issue #6367: [FLINK-9850] Add a string to the print method to identify...

2018-07-19 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6367 @yanghua Thanks for your update. +1 to merge ---

[GitHub] flink issue #6335: [FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream

2018-07-19 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6335 @zhangminglei It sounds great :-) ---

[GitHub] flink pull request #6367: [FLINK-9850] Add a string to the print method to i...

2018-07-18 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6367#discussion_r203588835 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/DataStream.scala --- @@ -959,6 +959,29 @@ class DataStream[T](stream

[GitHub] flink issue #6335: [FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream

2018-07-18 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6335 Hi @zhangminglei , Good catch! Maybe the Reader may also need to be adapted, making `new InputStreamReader` to `Channels.newReader`. I find a benchmark about File InputStream and Reader [here

[GitHub] flink issue #6301: [FLINK-9794] [jdbc] JDBCOutputFormat does not consider id...

2018-07-13 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6301 @jrthe42 Hi, thanks for your PR. From my side, I think use a connection pool to solve the connection problem is a better way. We don't need to keep the connections all the way. It wastes

[GitHub] flink issue #6075: [FLINK-9407] [hdfs connector] Support orc rolling sink wr...

2018-07-07 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6075 Hi @zhangminglei , The main reason to implement the `CheckpointedFuntion ` is you have kept a buffer in you Writer class. The buffer is a memory buffer which will suffer data loss during job

[GitHub] flink issue #6266: [FLINK-9682] Add setDescription to execution environment ...

2018-07-07 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6266 Hi @yanghua , I think if the description is too long, we can simply cut off the description. It is safe and easy. ---

[GitHub] flink issue #6075: [FLINK-9407] [hdfs connector] Support orc rolling sink wr...

2018-07-07 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6075 Hi @zhangminglei , thanks very much for your PR. As for dependencies, I think it is better to move ORC related classes into the module of `flink-orc`, so we don't need to add orc

[GitHub] flink issue #6267: [FLINK-5750] Incorrect parse of brackets inside VALUES su...

2018-07-05 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6267 @AlexanderKoltsov Hi, thanks for looking into this problem. The PR looks good. I agree with @fhueske that `DataStreamUnion ` should be fixed in this PR. Furthermore, I find `DataSetMinus

[GitHub] flink issue #6255: [FLINK-9681] [table] Make sure difference between minRete...

2018-07-05 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6255 @fhueske Comments have been addressed. Thanks for your review. ---

[GitHub] flink pull request #6255: [FLINK-9681] [table] Make sure difference between ...

2018-07-04 Thread hequn8128
GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/6255 [FLINK-9681] [table] Make sure difference between minRetentionTime and maxRetentionTime at least 5 minutes ## What is the purpose of the change This PR aims to make sure difference

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

2018-07-02 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199537675 --- Diff: docs/dev/table/sql.md --- @@ -1510,6 +1510,17 @@ ATAN(numeric) + + +{% highlight text

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

2018-07-02 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199537034 --- Diff: docs/dev/table/sql.md --- @@ -1510,6 +1510,17 @@ ATAN(numeric) + + +{% highlight text

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

2018-07-02 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199537075 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala --- @@ -300,6 +300,24 @@ object

[GitHub] flink pull request #6233: [FLINK-9696] Deep toString for array/map sql types

2018-07-02 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6233#discussion_r199506183 --- Diff: flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java --- @@ -0,0 +1,108

[GitHub] flink pull request #6233: [FLINK-9696] Deep toString for array/map sql types

2018-07-02 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6233#discussion_r199504811 --- Diff: flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java --- @@ -0,0 +1,108

[GitHub] flink pull request #6233: [FLINK-9696] Deep toString for array/map sql types

2018-07-02 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6233#discussion_r199504779 --- Diff: flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java --- @@ -0,0 +1,108

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-07-01 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r199349619 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1029,6 +1029,29 @@ object

[GitHub] flink issue #6233: [FLINK-9696] Deep toString for array/map sql types

2018-07-01 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6233 Hi @snuyanzin , thanks for your PR. The code looks good and the `deepToString()` function returns result correctly. I could not spot any issues with the implementation. To make the PR better, I

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-24 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197662959 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -349,6 +349,17 @@ case class TimestampAdd

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-24 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197640442 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,71 @@ case class TemporalOverlaps

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-24 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197640444 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,71 @@ case class TemporalOverlaps

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197614200 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197614217 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197614206 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197614210 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197614223 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps

[GitHub] flink issue #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-22 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6188 @xueyumusic Great that you step out to contribute to flink, I will take a look this weekend :-) ---

[GitHub] flink issue #6079: [FLINK-8430] [table] Implement stream-stream non-window f...

2018-06-06 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6079 @twalthr Thanks a lot for the review and merging. I will take a look at the FLINK-9440 and see if we can do any improvement. ---

[GitHub] flink pull request #6079: [FLINK-8430] [table] Implement stream-stream non-w...

2018-05-25 Thread hequn8128
GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/6079 [FLINK-8430] [table] Implement stream-stream non-window full outer join ## What is the purpose of the change Support stream-stream non-window full outer join. ## Brief

[GitHub] flink pull request #6046: [FLINK-8429] Implement stream-stream non-window ri...

2018-05-19 Thread hequn8128
GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/6046 [FLINK-8429] Implement stream-stream non-window right outer join ## What is the purpose of the change Implement stream-stream non-window right outer join. Most of the work has been

[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 @twalthr Hi, thanks for your review. I have updated the pr according to your suggestions. Changes mainly include: - Remove changes about UpsertSink - Refactor test case name and add more

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184995939 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/JoinITCase.scala --- @@ -977,6 +922,254 @@ class

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184995707 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala --- @@ -176,14 +179,34 @@ class

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184995596 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowOuterJoin.scala --- @@ -0,0 +1,303

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184995668 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/RetractionRulesTest.scala --- @@ -302,8 +303,87 @@ class

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184995557 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -230,8 +230,12 @@ abstract class

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184995438 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowOuterJoin.scala --- @@ -0,0 +1,303

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184995228 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowOuterJoin.scala --- @@ -0,0 +1,303

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184994673 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowOuterJoin.scala --- @@ -0,0 +1,303

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184994503 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowOuterJoin.scala --- @@ -0,0 +1,303

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184994194 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowOuterJoin.scala --- @@ -0,0 +1,303

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184993658 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala --- @@ -60,6 +60,9 @@ class

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-04-30 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r184993457 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamRel.scala --- @@ -53,4 +53,8 @@ trait

[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...

2018-04-20 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 @twalthr Hi, Great to see your review and valuable suggestions. I will update my pr late next week(maybe next weekend). Thanks very much. ---

[GitHub] flink pull request #4674: [FLINK-7627] [table] SingleElementIterable should ...

2018-04-17 Thread hequn8128
Github user hequn8128 closed the pull request at: https://github.com/apache/flink/pull/4674 ---

[GitHub] flink issue #4674: [FLINK-7627] [table] SingleElementIterable should impleme...

2018-04-17 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/4674 @fhueske Hi, I will close it. Thanks for the checking. ---

[GitHub] flink issue #5555: [FLINK-8689][table]Add runtime support of distinct filter...

2018-03-14 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/ Hi, @walterddr I was thinking we added some `MapView` as new member variables of the generated class, so we don't need to extend the arity of `accumulatorState `. What do you think? ---

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-03-10 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r173644059 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala --- @@ -0,0 +1,102

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-03-10 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r173644062 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1439,7 +1467,47 @@ object

[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...

2018-03-08 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 Hi @twalthr @walterddr The latest update refactors interfaces and functions to make code more friendly to right/full joins. The code of right/full joins are also ready and can be reached from

[GitHub] flink issue #5555: [FLINK-8689][table]Add runtime support of distinct filter...

2018-03-07 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/ @walterddr Cool, thanks for your update. I will take a look during this weekend or early next week :-) ---

[GitHub] flink issue #5613: [FLINK-8274] [table] Split generated methods for preventi...

2018-03-02 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5613 Hi @twalthr Current implementation will reach the limits if a field becomes too large. This can be reproduced by creating a filed produced by concat_ws(). see https://github.com/hequn8128

[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...

2018-02-28 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 Update pr according to @walterddr 's suggestions. ---

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-02-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r170936623 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowJoin.scala --- @@ -0,0 +1,271

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-02-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r170936833 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowLeftJoinWithNonEquiPredicates.scala --- @@ -0,0 +1,228

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-02-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r170936767 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowLeftJoin.scala --- @@ -0,0 +1,179

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-02-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r170936524 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/UpdatingPlanChecker.scala --- @@ -149,45 +148,39 @@ object

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-02-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r170936813 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowLeftJoinWithNonEquiPredicates.scala --- @@ -0,0 +1,228

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-02-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5327#discussion_r170936660 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowLeftJoin.scala --- @@ -0,0 +1,179

[GitHub] flink issue #5555: [FLINK-8689][table]Add runtime support of distinct filter...

2018-02-27 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/ Cool! It can avoid the problems with nested map views and is more flexible. ---

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-02-26 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r170828036 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1393,6 +1393,21 @@ object

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-02-26 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r170828027 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala --- @@ -0,0 +1,122

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-02-26 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r170577231 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -105,11 +106,32 @@ class

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-02-26 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r170577575 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala --- @@ -0,0 +1,122

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-02-26 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r170577434 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala --- @@ -0,0 +1,122

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-02-26 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r170577325 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala --- @@ -0,0 +1,122

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-02-26 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r170577531 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala --- @@ -0,0 +1,122

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-02-26 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r170577418 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAggDelegateFunction.scala --- @@ -0,0 +1,122

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-02-26 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r170577818 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala --- @@ -50,6 +50,80 @@ class

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-02-26 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r170577731 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1393,6 +1393,21 @@ object

[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...

2018-02-24 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 hi, @twalthr Look forward to your review, thanks :-) ---

[GitHub] flink pull request #5404: [FLINK-8550][table] Iterate over entryset instead ...

2018-02-02 Thread hequn8128
GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/5404 [FLINK-8550][table] Iterate over entryset instead of keys ## What is the purpose of the change Iterate over entrysets instead of keys when we want to get both key and value. I went

[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...

2018-01-29 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 Hi, @twalthr It would be great if you can take a look at the pr. I'm looking forward to finish outer join (left/right/full) before the end of March. Besides, there are a few PRs planed

[GitHub] flink pull request #5342: [FLINK-8479] Timebounded stream join

2018-01-29 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5342#discussion_r164631861 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java --- @@ -0,0 +1,398

[GitHub] flink pull request #5342: [FLINK-8479] Timebounded stream join

2018-01-29 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5342#discussion_r164631864 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java --- @@ -0,0 +1,398

[GitHub] flink pull request #5342: [FLINK-8479] Timebounded stream join

2018-01-29 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5342#discussion_r164631884 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java --- @@ -0,0 +1,398

[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

2018-01-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5367#discussion_r164266892 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/CalcTest.scala --- @@ -0,0 +1,47 @@ +/* + * Licensed

[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

2018-01-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5367#discussion_r164266896 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -984,6 +987,63 @@ object

[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

2018-01-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5367#discussion_r164266907 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala --- @@ -469,6 +473,148 @@ class SqlITCase

[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

2018-01-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5367#discussion_r164266897 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -984,6 +987,63 @@ object

[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

2018-01-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5367#discussion_r164266903 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -984,6 +987,63 @@ object

[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

2018-01-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5367#discussion_r164266900 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -984,6 +987,63 @@ object

[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

2018-01-27 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5367#discussion_r164266898 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -984,6 +987,63 @@ object

[GitHub] flink issue #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-26 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5347 hi, @fhueske Thanks for your suggestions. The pr has been updated according to your comments. ---

[GitHub] flink issue #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5347 hi @fhueske @twalthr , the pr has been updated. It would be great if you can take a look at it. Changes mainly include: 1. Adapt estimateRowCount to be more accurate. The original

[GitHub] flink issue #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-24 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5347 Hi, @fhueske @twalthr , To solve the problem, we need to make the `estimateRowCount` in `CommonCalc` more accurate. I will update the pr tomorrow. Anyway, cost model can't solve

[GitHub] flink issue #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-24 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5347 @twalthr thanks for your review. I will take a look and update the pr. ---

[GitHub] flink pull request #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-23 Thread hequn8128
GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/5347 [FLINK-8492][table] Fix calc cost bug ## What is the purpose of the change Fix calc cost bug. Currently, unsupported exception will be thrown when multi calc existing between

[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

2018-01-20 Thread hequn8128
GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/5327 [FLINK-8428] [table] Implement stream-stream non-window left outer join ## What is the purpose of the change Implement stream-stream non-window left outer join for sql/table-api

[GitHub] flink issue #4471: [FLINK-6094] [table] Implement stream-stream proctime non...

2018-01-10 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/4471 hi @twalthr The pr has been submitted. https://issues.apache.org/jira/browse/FLINK-8400 Thanks, Hequn. ---

[GitHub] flink pull request #5273: [FLINK-8400] [table] Use the lexicographic smalles...

2018-01-10 Thread hequn8128
GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/5273 [FLINK-8400] [table] Use the lexicographic smallest attribute as the common group id when extract unique key ## What is the purpose of the change `UniqueKeyExtractor` will return

[GitHub] flink issue #4471: [FLINK-6094] [table] Implement stream-stream proctime non...

2018-01-10 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/4471 hi @twalthr ~ Thanks for your review. I will give another pr to fix a small bug for FLINK-6094. PS: Outer joins are coming soon. Also, some PRs to optimize the stream-stream (inner/outer

[GitHub] flink pull request #5244: [FLINK-8366] [table] Use Row instead of String as ...

2018-01-05 Thread hequn8128
GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/5244 [FLINK-8366] [table] Use Row instead of String as key when process upsert results ## What is the purpose of the change This pr fix the bug in `TableSinkITCase.upsertResults

  1   2   >