Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r144257631
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/validation/SortValidationTest.scala
---
@@ -27,10 +27,26
Github user hustfxj commented on the issue:
https://github.com/apache/flink/pull/4133
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hustfxj commented on the issue:
https://github.com/apache/flink/pull/4111
Looks good to me.
+1 to merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hustfxj commented on the issue:
https://github.com/apache/flink/pull/4111
@sunjincheng121 I get it. Thank you very much!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hustfxj commented on the issue:
https://github.com/apache/flink/pull/4111
@sunjincheng121 Sorry, I didn't get you. I think the column will not be
out of order If we delete the code. Because we already ensure that the index is
at the correct range by the previous
Github user hustfxj commented on the issue:
https://github.com/apache/flink/pull/4111
@sunjincheng121 Thank you for the Fix. Maybe it had better remove the
followed codes at the Func **generateFieldAccess**.
```
val fieldIndex = if (ct.isInstanceOf[PojoTypeInfo
Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r121624773
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -329,6 +337,41 @@ object
