[GitHub] flink issue #4683: [FLINK-5944] Support reading of Snappy files

2017-10-13 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4683 @aljoscha @haohui , thank you for your comments. Marked hadoop dependency as provided, set Hadoop codec as default one ---

[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files

2017-09-27 Thread mlipkovich
Github user mlipkovich commented on a diff in the pull request: https://github.com/apache/flink/pull/4683#discussion_r141424281 --- Diff: flink-core/pom.xml --- @@ -52,6 +52,12 @@ under the License. flink-shaded-asm

[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files

2017-09-25 Thread mlipkovich
Github user mlipkovich commented on a diff in the pull request: https://github.com/apache/flink/pull/4683#discussion_r140833786 --- Diff: flink-core/pom.xml --- @@ -52,6 +52,12 @@ under the License. flink-shaded-asm

[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files

2017-09-24 Thread mlipkovich
Github user mlipkovich commented on a diff in the pull request: https://github.com/apache/flink/pull/4683#discussion_r140652438 --- Diff: flink-core/pom.xml --- @@ -52,6 +52,12 @@ under the License. flink-shaded-asm

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-22 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 Thanks! Closing it ---

[GitHub] flink pull request #4655: [FLINK-7567]: Removed keepPartitioning parameter f...

2017-09-22 Thread mlipkovich
Github user mlipkovich closed the pull request at: https://github.com/apache/flink/pull/4655 ---

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-20 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 Hi @aljoscha It turned out that exclude filter works if we escape dollar signs. I commited these changes, but I believe it still should be fixed by japicmp What do you think about merging

[GitHub] flink issue #4630: [FLINK-6733] Remove commented out AvgAggregationFunction....

2017-09-19 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4630 @zentol thanks for your comment. As I understand I can't merge it without a formal review. May I ask you to review it? ---

[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files

2017-09-19 Thread mlipkovich
GitHub user mlipkovich opened a pull request: https://github.com/apache/flink/pull/4683 [FLINK-5944] Support reading of Snappy files ## What is the purpose of the change Support reading of Snappy compressed text files (both Xerial and Hadoop snappy) ## Brief

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-15 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 Thansk, Aljoscha Probably I've forgotten to run `clean`. The method `iterate$default$3` is a method which automatically created by Scala for calculation of default value for parameter

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-14 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 The local build works fine. If you mean `mvn verify` by compatibility plugin it also worked with no issues ---

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-07 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 As I understand the build has failed because of changed API method. The method which was changed has annotation PublicEvolving so there should be a way to change it. As was mentioned by @aljoscha

[GitHub] flink pull request #4655: [FLINK-7567]: Removed keepPartitioning parameter f...

2017-09-07 Thread mlipkovich
GitHub user mlipkovich opened a pull request: https://github.com/apache/flink/pull/4655 [FLINK-7567]: Removed keepPartitioning parameter from iterate method ## What is the purpose of the change Removed parameter keepPartitioning from DataStream#iterate method since it's

[GitHub] flink issue #4630: [FLINK-6733] Remove commented out AvgAggregationFunction....

2017-09-01 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4630 The build has failed but it seems like Travis issue. My changes could not break it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #4630: [FLINK-6733] Remove commented out AvgAggregationFu...

2017-08-31 Thread mlipkovich
GitHub user mlipkovich opened a pull request: https://github.com/apache/flink/pull/4630 [FLINK-6733] Remove commented out AvgAggregationFunction.java *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community