Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2732
This is still based on old runtime parts (JobManager), though the interface
allows it to be ported to the new runtime (JobMaster). As the new one is about
to supersede the old one, it might be sensible
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2732
This probably needs an overhaul by now. Have there been any efforts
undergone to introduce a job client?
---
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2917
>edit: Re-reading the PR description, I actually got it to work by setting
jobmanager.rpc.address to the external IP and getting rid of the hostname.
Glad you were able to solve the prob
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/3086
No, looks good. Thanks. As Greg mentioned, please open a JIRA issue next
time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/3086
@kaelumania `ARG` is only available from Docker 1.10 on and upwards. I
believe docker-compose also offers to configure environment variables either
through the compose file or via a command-line
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95411011
--- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
@@ -28,6 +28,9 @@ if [ "$1" == "jobmanager" ]; then
echo &qu
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95411497
--- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
@@ -36,9 +39,9 @@ elif [ "$1" == "taskmanager" ]; then
echo &q
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95410892
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,9 +22,9 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure Flink
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/3017
Thank you @theomega. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/3016
@greghogan `docs/build_docs.sh`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/3016
Had to add this to the root `pom.xml` to convince the Rat plugin to pass.
```xml
docs/ruby2/Gemfile.lock
```
---
If your project is set up for it, you can reply
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/3016
Thank you for fixing this, David! I have just verified that this fixes the
Buildbot related issues. It is a shame that we only have Ruby 1.9, but for now
we will have to deal with this limitation
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2917
Thank you, will go ahead and merge then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/3017
[FLINK-5350] don't overwrite an existing JAAS config
Users may want to use SASL/PLAIN https://tools.ietf.org/html/rfc4616
without Kerberos.
You can merge this pull request into a Git repository
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2917
I've added the new staging repository to test the PR changes. Also, the
repository is currently deploying to Maven central.
---
If your project is set up for it, you can reply to this email and have
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2917
Thanks you @tillrohrmann and @StephanEwen. I've addressed your comments.
I'll have to redeploy Flakka because the staging repository which this PR used,
has been dropped in the meantime. I will update
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2917#discussion_r92661183
--- Diff: flink-runtime/pom.xml ---
@@ -193,8 +193,8 @@ under the License.
- com.typesafe.akka
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2917#discussion_r92659443
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ---
@@ -216,12 +219,19 @@ object AkkaUtils {
* identified
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2917#discussion_r92658704
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ---
@@ -216,12 +219,19 @@ object AkkaUtils {
* identified
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2917#discussion_r92658254
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ---
@@ -102,21 +102,24 @@ object AkkaUtils {
* specified
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/3013#discussion_r92653981
--- Diff: docs/build_docs.sh ---
@@ -46,8 +46,8 @@ DOCS_DST=${DOCS_SRC}/content
JEKYLL_CMD="build"
# if -p flag is provided,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/3013#discussion_r92654203
--- Diff: docs/Gemfile ---
@@ -17,13 +17,14 @@
source 'https
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2928
Thanks for your understanding :) Could you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2997
Thanks for the review, will merge then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/3007
[FLINK-4922][docs] document how to use Flink on Mesos
This adds some initial user documentation for Flink on Mesos.
You can merge this pull request into a Git repository by running:
$ git pull
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2928
There is one problem we overlooked. In detached mode we ensure cluster
shutdown through a message sent by the client during job submission to tell the
JobManager that this is going to be the last job
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2997
[FLINK-5240][tests] ensure state backends are properly closed
This adds additional test cases to verify the state backends are closed
properly upon the end of a task. The state backends should
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2928
I will go ahead and merge this PR since there have been no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2981
[docker] improve Dockerfile host configuration
- configure job manager address for both operation modes
- introduce argument to specify the external job manager address
- replace ARG with ENV
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2917
@StephanEwen I've updated the pull request to incorporate your suggestions.
When an IPv6 address is specified, we format it like in the current code base.
When a hostname is specified, we do some simple
Github user mxm closed the pull request at:
https://github.com/apache/flink/pull/2951
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2951
Sorry, I missed your comment. We can open another PR to clarify that!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2954
Merged in c024b0b6cae16a0b668d864c77e923820c262087 but forgot to include
the "This closes #2954" message in the commit, could you close the PR?
---
If your project is set up for it, you
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2951
[docs] clarify default restart behavior when checkpointing is enabled
Merging this to `master` and `release-1.1`.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2915
Looks really good!. Merging with some minor changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2928
I think the original intend of the Client shutdown hook was to make sure
that clusters which are spawned and didn't receive jobs are cleaned up again.
However, that behavior can be quite tricky because
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2945
I've tested the changes through this build:
https://ci.apache.org/builders/flink-docs-FLINK-3887/builds/36
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2945
[FLINK-5262][docs] Introduce Gemfile.lock to avoid dependency range
conflicts
The Gemfile for specifying the Ruby dependencies of our documentation
has fixed dependency versions to avoid
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2928
Thanks for the PR! This removes the shutdown hook after the cluster has
been deployed. The original intend was to remove it only after job submission.
Probably it makes sense to remove it all-together
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90664938
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/SSLStoreOverlay.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90664759
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/HadoopUserOverlay.java
---
@@ -0,0 +1,83 @@
+/*
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90666953
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java
---
@@ -542,42 +542,10 @@ protected static File
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90454287
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/ContainerOverlay.java
---
@@ -0,0 +1,37 @@
+/*
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90454802
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/AbstractContainerOverlay.java
---
@@ -0,0 +1,72
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90664795
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/Krb5ConfOverlay.java
---
@@ -0,0 +1,111 @@
+/*
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90665396
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/overlays/HadoopConfOverlayTest.java
---
@@ -0,0 +1,119
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90664782
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/KeytabOverlay.java
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90666707
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/overlays/HadoopConfOverlayTest.java
---
@@ -0,0 +1,119
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2917
>Can we try and preserve both in some way? When a logical hostname is
specified, we use that one in the Akka URLs. When an IP address is specified,
we normalize it and use it.
Detecting whet
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2917#discussion_r90627441
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1891,8 +1891,8 @@ object JobManager {
// parsing
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2917
Thanks for checking out the code!
>If different parts of the code or the JDK do a subtle change of behavior
(i.e. resolve the InetAddress), then some nodes may have a hostname in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2917#discussion_r90621937
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -2729,11 +2727,11 @@ object JobManager {
def
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2917#discussion_r90621698
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1891,8 +1891,8 @@ object JobManager {
// parsing
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2908#discussion_r90469083
--- Diff: flink-libraries/flink-cep-scala/pom.xml ---
@@ -93,6 +93,8 @@ under the License.
+
+src/main/scala
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2917
[FLINK-2821] use custom Akka build to listen on all interfaces
This uses Flakka (a custom Akka 2.3 build) to resolve the issue that
the bind address needs to be matching the external address
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2900
Tests passed. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2908
[maven] properly attach the CEP Scala source code
Two options, either change the default Maven source directory from
'src/main/java' to 'src/main/scala' or use the build-helper-maven-plugin
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2900
Rebased again to the latest Mesos changes to make sure tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2900
Rebased: Keytab & TLS support for Flink on Mesos Setup
Rebased #2734 to the latest master.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/f
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2827
Makes sense then. Do distributions like DC/OS already ship Mesos 1.0.1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2827
Looks good to me. Do we lose backwards-capability for Mesos installations <
1.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2734
Sorry this is taking so long. You you please rebase to the latest master?
@EronWright Could you take a look at the changes?
---
If your project is set up for it, you can reply to this email
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2836
It does not: https://github.com/jacoco/jacoco/wiki/MavenMultiModule
That's a bummer but apparently there are some workarounds:
http://www.thinkcode.se/blog/2012/02/18/test-coverage
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2864
[FLINK-5055][security] skip Hadoop UGI login if unsecured
The new Kerberos authentication code in Flink assumed that it's running
against vanilla Hadoop. Original Hadoop's behavior is to skip a secure
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2856
You removed the tests you introduced in #2623. If there were any tests in
`KryoCollectionsSerializerTest` which test `Arrays.asList(..)` they would have
failed prior merging #2623. Could you add a unit
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2623
Sure, I'll take care of it. I saw you giving a +1 and didn't see an issue
myself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2860
Thanks, I'll leave this open for a bit. I wasn't aware we also had an issue
for removing the trigger. I don't know how useful it is to users.
---
If your project is set up for it, you can reply
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2803
I just opened a PR as well :)
I was under the assumption that a continuous trigger is useful for early
window results. Not sure if it might be confusing for users because you can
receive
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2860
CC @kl0u @aljoscha
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2860
[FLINK-5149] let ContinuousEventTimeTrigger fire at the end of the window
This changes the ContinuousEventTimeTrigger to behave like the
EventTimeTrigger in the sense that it also triggers
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2854
[typo] fix toString() of ContinuousEventTimeTrigger
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink master
Alternatively you can review
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r89284152
--- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/pom.xml ---
@@ -193,9 +192,7 @@ under the License
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r89282667
--- Diff: pom.xml ---
@@ -996,10 +996,9 @@ under the License.
${flink.reuseForks
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r89282258
--- Diff: pom.xml ---
@@ -93,7 +93,7 @@ under the License.
1C
true
log4j-test.properties
- -Xms256m
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r89284243
--- Diff: flink-streaming-connectors/flink-connector-kafka-0.10/pom.xml ---
@@ -197,9 +196,7 @@ under the License
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r89284270
--- Diff: flink-streaming-connectors/flink-connector-cassandra/pom.xml ---
@@ -50,9 +49,7 @@ under the License
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2623
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89161736
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/JobClient.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2623
The build fails during the Maven Rat plugin license check. Could you fix
the build and rebase to the latest master? I think we can merge then.
---
If your project is set up for it, you can reply
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89141224
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -172,29 +174,40 @@ public JobExecutionResult executePlan(Plan plan
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89141153
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -172,29 +174,40 @@ public JobExecutionResult executePlan(Plan plan
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89140934
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -172,29 +174,40 @@ public JobExecutionResult executePlan(Plan plan
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89139301
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/JobClientEager.java
---
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89139085
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/JobClientEager.java
---
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89140321
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/RemoteExecutor.java ---
@@ -207,14 +207,23 @@ public JobExecutionResult
executePlanWithJars
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89139969
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/RemoteExecutor.java ---
@@ -207,14 +207,23 @@ public JobExecutionResult
executePlanWithJars
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89138438
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/JobClientTest.java
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89138090
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/JobClient.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89137404
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/JobClient.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89137049
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -911,6 +912,24 @@ public JobExecutionResult execute() throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89137469
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/JobClient.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89136864
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -911,6 +912,24 @@ public JobExecutionResult execute() throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89136345
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java
---
@@ -333,4 +354,31 @@ protected boolean isClientConnected
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89136326
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java
---
@@ -333,4 +354,31 @@ protected boolean isClientConnected
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89136299
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActorUtils.java
---
@@ -101,11 +93,37 @@ public static JobListeningContext
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89135846
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala
---
@@ -634,6 +634,25 @@ class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89135855
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/ExecutionEnvironment.scala
---
@@ -652,6 +652,34 @@ class ExecutionEnvironment(javaEnv: JavaEnv
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89135481
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorErrorITCase.java
---
@@ -91,11 +91,9 @@ public void testFaultyAccumulator
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2732
Thank you for your comments @tillrohrmann and @aljoscha. I'll make changes
and get back to you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r89130510
--- Diff: flink-streaming-connectors/flink-connector-kafka-0.10/pom.xml ---
@@ -196,7 +197,9 @@ under the License
1 - 100 of 1762 matches
Mail list logo
