Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4883#discussion_r182155763
--- Diff: docs/dev/stream/state/checkpointing.md ---
@@ -118,6 +120,9 @@
env.getCheckpointConfig.setMinPauseBetweenCheckpoints(500)
// checkpoints
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/5293
[hotfix][docs] Mention maven dependency for RocksDB state backend
This hotfix adds a note to the RocksDB state backend page, mentioning that
it requires a maven dependency to be added to the users
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4616
No, you can define fine-grained exclusions. Check the excludes in the
example: http://siom79.github.io/japicmp/MavenPlugin.html
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4616
I see. It is a similar problem we've discussed with the SourceContext.
Users only implement it, but don't call it.
I believe in this case, it makes sense to add an exception to Japicmp
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4522
I've pushed the PR to CI again. If it passes, I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4566
+1 to merge (assuming `command` is available on all operating systems / or
is a bash command?)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4566#discussion_r133985865
--- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
@@ -351,8 +351,20 @@ if [ -z "$HADOOP_CONF_DIR" ]; then
fi
fi
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4566#discussion_r133985612
--- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
@@ -351,8 +351,20 @@ if [ -z "$HADOOP_CONF_DIR" ]; then
fi
fi
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4553
Afaik the problem is that the doc builders are independent of Flink
version. So we use the same toolchain for building 0.8 docs and 1.4 docs.
The `flink.conf` file in
https://svn.apache.org
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4452
+1 to merge:
- Checked with a project depending on Flink. It doesn't fail anymore after
using your PR
- mvn build passes
- the dependency-red-pom of flink-runtime looks good (no netty
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4452#discussion_r130890710
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -290,6 +290,15 @@ check_shaded_artifacts() {
echo
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4452#discussion_r130668606
--- Diff: flink-dist/pom.xml ---
@@ -204,6 +204,11 @@ under the License
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4452#discussion_r130615205
--- Diff: flink-dist/pom.xml ---
@@ -204,6 +204,11 @@ under the License
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4233
I think this looks good.
It's basically a change now restricted to the build system only.
+1 to give it a try on master and see how things go with it.
---
If your project is set up
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4233#discussion_r126991245
--- Diff: pom.xml ---
@@ -858,32 +856,6 @@ under the License
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4233#discussion_r126990790
--- Diff: .travis.yml ---
@@ -17,32 +17,45 @@ matrix:
include:
# Always run test groups A and B together
--- End diff --
I think
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4233#discussion_r125493654
--- Diff: flink-connectors/pom.xml ---
@@ -87,6 +87,39 @@ under the License
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4233#discussion_r125493890
--- Diff: flink-fs-tests/pom.xml ---
@@ -96,6 +96,40 @@ under the License.
${hadoop.version
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4233#discussion_r125493851
--- Diff: flink-examples/pom.xml ---
@@ -70,6 +70,40 @@ under the License
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4233
So executing `mvn clean verify` won't run the tests, right?
Have you considered doing this, basically without touching the pom files at
all?
Basically by having a script that says
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3911
Okay
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3911
I think the change is okay to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3270
This pull request actually updates the Kafka connector examples, so I think
there's no need to do anything here:
https://github.com/apache/flink/pull/3911/files
---
If your project is set up
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3270
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4211#discussion_r124589466
--- Diff: docs/dev/migration.md ---
@@ -25,6 +25,62 @@ under the License.
* This will be replaced by the TOC
{:toc}
+## Migrating from
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4208
+1 to merge once travis has passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4207
+1 to merge once travis has passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4182#discussion_r124588442
--- Diff: pom.xml ---
@@ -1021,6 +1021,7 @@ under the License
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4182
+1 to merge once my concerns are addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4182#discussion_r124588048
--- Diff: .travis.yml ---
@@ -1,7 +1,8 @@
# s3 deployment based on
http://about.travis-ci.org/blog/2012-12-18-travis-artifacts/
# send
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3270#discussion_r124046763
--- Diff: flink-examples/flink-examples-streaming/pom.xml ---
@@ -482,54 +502,19 @@ under the License
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3270#discussion_r124046687
--- Diff: flink-examples/flink-examples-streaming/pom.xml ---
@@ -360,6 +360,26 @@ under the License
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4175
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4017
That would be nice, yes. Thx
Sent from my iPhone
> On 23. Jun 2017, at 11:52, zentol <notificati...@github.com> wrote:
>
> I could include this in my merge
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4017
With the current travis situation, I can not validate this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4017
Change looks good.
I'll merge it once travis gives green light on my fork.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4111
Please see my message in the 1.3.1 thread on the dev@ list :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4102
Please see my message in the 1.3.1 thread on the dev@ list :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2487
@asdf2014 I think there was never a PR for siddhi at the Bahir project.
But if you are interested, you could work on contributing it to bahir.
---
If your project is set up for it, you can
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4083
Change looks good to merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4048
I've tested the change with the release scripts, and the elasticsearch5
connector was showing up.
I'll merge the change now.
---
If your project is set up for it, you can reply
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4039
Cool, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4039
@dawidwys What's your schedule to address the comments?
This is one of the real blockers for the 1.3.1 release, and I would like to
put the first RC this week.
---
If your project is set up
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/4048
[FLINK-6812] Enforce Java8 when creating a release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink6812
Alternatively you
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4041
I'll update the release announcement blog post, once the CEP doc has been
updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3916
How about the following:
- We commit the generated files to git
- We try in build-docs.sh to update the generated files, but a failure
won't break the doc build process
This way, we
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4041
Cool, thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4041
@dawidwys Do you think we can merge the updated documentation today already?
I would like to put out the 1.3 release ann with a link to the CEP docs.
---
If your project is set up for it, you
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3916#discussion_r119607441
--- Diff: docs/_includes/generated/environment_options_configuration.html
---
@@ -0,0 +1 @@
+KeyDefault
ValueDescriptionenv.java.opts(none)Set
custom
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3833#discussion_r119595452
--- Diff: flink-metrics/flink-metrics-prometheus/pom.xml ---
@@ -0,0 +1,129 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://w
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3916
+1 for integration into the build-docs.sh, we just have to make sure that
the docs are still properly build on the buildbot for the flink website.
---
If your project is set up for it, you can
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3916#discussion_r119594668
--- Diff: docs/_includes/generated/environment_options_configuration.html
---
@@ -0,0 +1 @@
+KeyDefault
ValueDescriptionenv.java.opts(none)Set
custom
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4011
I'll merge the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3979
+1 to merge (assuming this change has been tested on a cluster)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3987
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3984
+1 to remove it (however, please merge this only after at least one other
PMC member also +1ed and after some time passed. I don't want to cause any
discussions afterwards)
---
If your project
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3960
I'm not sure if the proposed fix is correct, because it will add the shaded
hadoop uber project's dependencies into Flink dist.
IIRC, this was the whole point of Stephan's recent refactoring
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3970
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3960
Okay, I was able to reproduce the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3960
Not sure about the initial issue. For me the command worked (without yoru
changes on the 1.3 branch)
```
[INFO
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3961
@kl0u asked me to merge this PR to the release-1.3 branch. It seems the
change is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3965
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3937
Thanks a lot for the quick review and merge!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3937
Thank you for your response.
This PR is the last item for the next release candidate. Would be good to
get this in in the next few hours so that I can finally start the vote for the
1.3 release
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3947
+1 to merge (tested the change locally)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3949
+1 to merge this change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3937
Hey,
what's the status of this PR?
I see the JIRA is marked as a blocker. When do you think is this PR ready
to be merged?
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3950
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3911
I tried it locally, but got some weird results:
```
Found error in log files.
Found exception in log files.
Found non-empty file
build-target/log/flink-robert-jobmanager-0
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3911#discussion_r117445440
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -227,5 +227,15 @@ upload_artifacts_s3
# we are going back to
cd ../../
+# run end-to-end
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3856
Afaik this PR can be closed because it has been superseded by Stephan's PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3910
Thanks a lot for fixing the issue.
I've tested it again, and it works.
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3910
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3933
Lets see what Till says.
In my opinion, both approaches are fine. What you are proposing makes
things on Flink's side a bit more complicated, but the behavior is consistent
with other places
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3933
Till and I had an offline discussion about this.
What you can do in your user code to set the TCCL properly is the following:
```
Thread.currentThread().setContextClassLoader
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3910
Not sure what's happening, but when I'm trying to generate a project from
the archetype, I'm getting:
```
Failed to execute goal
org.apache.maven.plugins:maven-archetype-plugin:2.4
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3910
the change *looks* good to merge. I'm currently building Flink to quickly
try it out
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3906
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3917
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3910
The script is deploying scala 2.10 for the quickstarts, yes.
I think the reason for this is that scala 2.10 is still considered
"default" in Flink.
---
If your project is set up f
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3932
+1 Very good, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3933
I haven't worked on this part of the code before, but I believe this code
is +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3931
I'll merge the change now ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3931
Thank you for addressing my comments so quickly.
The change is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3931
(for both 1.3 and 1.4)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3931#discussion_r117204403
--- Diff: docs/setup/yarn_setup.md ---
@@ -245,6 +245,18 @@ Note: You can use a different configuration directory
per job by setting the env
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3931#discussion_r117199176
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -665,58 +685,52 @@ public ApplicationReport
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3931#discussion_r117198446
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -200,6 +214,17 @@ public void setTaskManagerMemory(int
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3931#discussion_r117199375
--- Diff: docs/setup/yarn_setup.md ---
@@ -245,6 +245,18 @@ Note: You can use a different configuration directory
per job by setting the env
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3877
@StephanEwen can you manually close the PR?
Thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3926
Sadly, our tests are a little bit unstable. The issue is not related to
your change.
@tillrohrmann could you talk a quick look here?
---
If your project is set up for it, you can reply
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3903
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3900
@zentol do you agree to merge this now. Its the last thing I would like to
get into RC1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3900#discussion_r116492253
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
---
@@ -62,7 +62,7 @@
*/
public static final
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3877
Merging this change ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3876
I'm merging this change now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/3900
[FLINK-6580] Sync default heap sizes from code with config file
Flink didn't start on YARN anymore without explicit configuration of JM and
TM heap because the default heap sizes in the yaml file
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3876
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3890
Thank you for addressing this so quickly.
+1 from my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3870
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
1 - 100 of 2231 matches
Mail list logo
