Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202517181
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/TieBreakingPriorityComparator.java
---
@@ -85,10 +85,10 @@ public int compare(T o1
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202519256
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -446,8 +485,10 @@ public String toString
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202517247
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java
---
@@ -305,6 +351,6 @@ private void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202516863
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupPartitioner.java
---
@@ -264,6 +265,42 @@ public void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202519024
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueueSnapshotRestoreWrapper.java
---
@@ -0,0 +1,102
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202518473
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastStateBackendMetaInfo.java
---
@@ -63,54 +72,46 @@ public
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202519294
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/PriorityComparable.java
---
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5982
@StephanEwen Thanks! Looking forward~
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6306
@aljoscha Thanks for your quick review, will address your comments while
merging.
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6308#discussion_r201778299
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedBackendSerializationProxy.java
---
@@ -98,8 +103,7 @@ public int getVersion
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6301
Hi @jrthe42, In general the checkpoint include two part of works.
- part1: take a snapshot of the state.
- part2: transfer the snapshot to the checkpoint destination(e.g. DFS
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6306
CC @aljoscha
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6306
[FLINK-9804][state] KeyedStateBackend.getKeys() does not work on RocksDB
MapState
## What is the purpose of the change
*This PR fixes the bug that the KeyedStateBackend.getKeys() does
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6301#discussion_r201676322
--- Diff:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -111,110 +134,117 @@ public void
Github user sihuazhou closed the pull request at:
https://github.com/apache/flink/pull/6133
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6228
+1 from my side
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6194
Hi @tillrohrmann I added a unit test
`FsCheckpointStorageTest#testResolveCheckpointStorageLocation()` to guard the
changes. But I still use one `mock` for creating two different file systems(one
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6194
@tillrohrmann Thanks for your review and suggestion, will change it tonight~
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6194
@yanghua Thanks for the review, I rebased the PR.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6228
@StefanRRichter very nice PR, I only had some very minor comments.
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199325117
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/InternalPriorityQueue.java
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199325112
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/InternalPriorityQueue.java
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199325523
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOrderedStore.java
---
@@ -0,0
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199325172
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/KeyGroupPartitionedPriorityQueue.java
---
@@ -0,0 +1,277
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199325190
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOrderedStore.java
---
@@ -0,0
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199320321
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOrderedStore.java
---
@@ -0,0
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199320135
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java
---
@@ -0,0 +1,288
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199320254
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOrderedStore.java
---
@@ -0,0
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199320146
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java
---
@@ -0,0 +1,288
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6125
@yanghua sorry I'm not a native english speaker, so I think I'm not
suitable to review this...
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6132
Hi @tillrohrmann I updated the PR could you please have a look again?
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6132#discussion_r199315500
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -984,6 +985,15 @@ private void startCheckpointScheduler
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6132
@tillrohrmann Thanks for your review and good suggestions, changing the
code according to it.
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6205#discussion_r198146934
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
---
@@ -346,16 +351,87 @@ private void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6205#discussion_r198146056
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
---
@@ -346,16 +351,87 @@ private void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6205#discussion_r198135717
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
---
@@ -346,16 +351,87 @@ private void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6205#discussion_r198136425
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
---
@@ -346,16 +351,87 @@ private void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6205#discussion_r198135796
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
---
@@ -346,16 +351,87 @@ private void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6205#discussion_r198136431
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
---
@@ -346,16 +351,87 @@ private void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6208#discussion_r198129785
--- Diff: flink-tests/src/test/resources/log4j-test.properties ---
@@ -18,7 +18,7 @@
# Set root logger level to OFF to not flood build logs
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6208#discussion_r198129120
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultSlotPoolFactory.java
---
@@ -75,10 +82,21 @@ public static
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r198015825
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,204 @@
+package
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r198015848
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,204 @@
+package
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r198015385
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,204 @@
+package
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r198015282
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,204 @@
+package
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r198015105
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,204 @@
+package
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r198014886
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,204 @@
+package
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r198014021
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6186
@StefanRRichter Thanks for you reply! I think that makes sense, there is
still a workaround for the user to go. `+1` to implement the current approach
firstly.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6186
Maybe let me elaborate the TTL checking condition in detail, overall the
checking condition contains two parts and looks like `(current_ts - update_ts)
- time_shift_offset >=
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6186
I'm still a bit worried about the time-align problem on recovery(because
I've met serval case that would become disaster on production if we don't do
the time-align on recovery. (One instance: we
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6186
@azagrebin thanks for addressing the concerns, looks good from my side now.
let's wait for @StefanRRichter 's review.
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r197329976
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,204 @@
+package
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r197331145
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r197330095
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,204 @@
+package
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r197330813
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
---
@@ -48,7 +48,8 @@
KeyedStateBackend
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r197331820
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r197329533
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,204 @@
+package
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r197331211
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r197331898
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r197330596
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,204 @@
+package
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r197331741
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r197331764
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r197192870
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlConfig.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r197188305
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlValue.java ---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r197114442
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlValue.java ---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r197111980
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlValue.java ---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r197080576
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlListState.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6194
CC @zentol
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6194
[FLINK-9633][checkpoint] Use savepoint path's file system to create
checkpoint output stream
## What is the purpose of the change
*This PR fixes Flink doesn't use the savepoint path's
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6189#discussion_r197008798
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/AbstractHandler.java
---
@@ -103,77 +102,68 @@ protected void respondAsLeader
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r197001110
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlReducingState.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196995820
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlListState.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196998472
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlListState.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r197004891
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlValue.java ---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r197001339
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlAggregatingState.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196996094
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlListState.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196996839
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlListState.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196995095
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlConfig.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196827863
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlListState.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196820474
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/AbstractTtlDecorator.java
---
@@ -0,0 +1,98 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196809755
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/AbstractTtlDecorator.java
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196817846
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlListState.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196816259
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlListState.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196791555
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlConfig.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196786370
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/AbstractTtlDecorator.java
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r196784275
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/AbstractTtlDecorator.java
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5982
Could anybody have a look at this?
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6185
CC @tillrohrmann
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6185
[FLINK-9619][YARN] Eagerly close the connection with task manager when the
container is completed
## What is the purpose of the change
*We should always eagerly close the connection
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6151#discussion_r196366033
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSerializer.java
---
@@ -105,41 +108,54
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6088
cc @tillrohrmann
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6174
@StefanRRichter Thanks for the review, I think that makes a lot of sense,
will change it according to your suggestion.
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6173#discussion_r195903383
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -110,7 +123,7 @@
/**
* Map
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6173#discussion_r195903191
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6173#discussion_r195903638
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6173#discussion_r195903619
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6173#discussion_r195903979
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/StateBinder.java ---
@@ -23,7 +23,10 @@
/**
* The {@code StateBinder
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6173#discussion_r195903433
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -203,91 +216,16 @@ private boolean
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6174
CC @StefanRRichter
---
1 - 100 of 536 matches
Mail list logo
