Re: [PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

2024-05-26 Thread via GitHub
Zakelly closed pull request #24840: [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files URL: https://github.com/apache/flink/pull/24840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-24298] Add GCP PubSub Sink API Implementation, bump Flink version to 1.19.0 [flink-connector-gcp-pubsub]

2024-05-26 Thread via GitHub
snuyanzin commented on PR #27: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/27#issuecomment-2132266341 it seems dependency convergence issue should be resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-24298] Add GCP PubSub Sink API Implementation, bump Flink version to 1.19.0 [flink-connector-gcp-pubsub]

2024-05-26 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/27#discussion_r1615240064 ## flink-connector-gcp-pubsub/src/main/java/org/apache/flink/connector/gcp/pubsub/common/PubSubConstants.java: ## @@ -0,0 +1,11 @@ +package

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-26 Thread via GitHub
snuyanzin merged PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-26 Thread via GitHub
snuyanzin commented on PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#issuecomment-2132254635 Thanks for the valuable improvement @liuml07 thanks for the review @reta -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-26 Thread via GitHub
vahmed-hamdy commented on PR #24839: URL: https://github.com/apache/flink/pull/24839#issuecomment-2132249502 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35348][table] Introduce refresh materialized table rest api [flink]

2024-05-26 Thread via GitHub
flinkbot commented on PR #24844: URL: https://github.com/apache/flink/pull/24844#issuecomment-2132246140 ## CI report: * b9b0aad8794f5fe34bdb3a5c0d3a75826468 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35348][table] Introduce refresh materialized table rest api [flink]

2024-05-26 Thread via GitHub
hackergin opened a new pull request, #24844: URL: https://github.com/apache/flink/pull/24844 ## What is the purpose of the change *Introduce refresh materialized table rest api* ## Brief change log - *test-filesystem support partition.fields option* - *Introduce

Re: [PR] [FLINK-35354] Support host mapping in Flink tikv cdc [flink-cdc]

2024-05-26 Thread via GitHub
Mrart commented on PR #3336: URL: https://github.com/apache/flink-cdc/pull/3336#issuecomment-2132210507 > > I think we can specific a config prefix pass config to tikv client like cdc source connector pass config to debezium by `debezium.*`. This way will be flexible. @leonardBang @Mrart

Re: [PR] [FLINK-35354] Support host mapping in Flink tikv cdc [flink-cdc]

2024-05-26 Thread via GitHub
GOODBOY008 commented on PR #3336: URL: https://github.com/apache/flink-cdc/pull/3336#issuecomment-2132201295 As discuss offline with @Mrart , due to ``tikvclient` config `hostMapping` different from others. So the solution in this PR, I think ok. -- This is an automated message from the

Re: [PR] [FLINK-35453][core] StreamReader Charset fix with UTF8 in core files [flink]

2024-05-26 Thread via GitHub
xuzifu666 commented on PR #24842: URL: https://github.com/apache/flink/pull/24842#issuecomment-2132165935 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35454] Allow connector classes to depend on internal Flink util classes [flink]

2024-05-26 Thread via GitHub
flinkbot commented on PR #24843: URL: https://github.com/apache/flink/pull/24843#issuecomment-2132147690 ## CI report: * 7dd3dc90fcb9c37fd0beccba69cf19586efe59f6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-26 Thread via GitHub
vahmed-hamdy commented on PR #24839: URL: https://github.com/apache/flink/pull/24839#issuecomment-2132141416 @dannycranmer thanks for the review, Could you have another pass? The CI is failing due to a bug in Architecture tests FLINK-35454, Could you take a look at this

[PR] [FLINK-35454] Allow connector classes to depend on internal Flink util classes [flink]

2024-05-26 Thread via GitHub
vahmed-hamdy opened a new pull request, #24843: URL: https://github.com/apache/flink/pull/24843 … ## What is the purpose of the change Allow connector classes to depend on internal Flink util classes in ArchUnit tests. ## Brief change log *(for

Re: [PR] [FLINK-35453][core] StreamReader Charset fix with UTF8 in core files [flink]

2024-05-25 Thread via GitHub
flinkbot commented on PR #24842: URL: https://github.com/apache/flink/pull/24842#issuecomment-2132050840 ## CI report: * 745f6f511d6e978317e42d1ca6e4b51d5d201926 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35453][core] StreamReader Charset fix with UTF8 in core files [flink]

2024-05-25 Thread via GitHub
xuzifu666 opened a new pull request, #24842: URL: https://github.com/apache/flink/pull/24842 ## What is the purpose of the change StreamReader Charset fix with UTF8 in core files ## Brief change log StreamReader Charset fix with UTF8 in core files

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614911177 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTimeoutTest.java: ## @@ -0,0 +1,200 @@ +/* + *

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614911032 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTimeoutTest.java: ## @@ -0,0 +1,200 @@ +/* + *

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614910580 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTimeoutTest.java: ## @@ -0,0 +1,200 @@ +/* + *

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614908849 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTimeoutTest.java: ## @@ -0,0 +1,200 @@ +/* + *

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614909440 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTimeoutTest.java: ## @@ -0,0 +1,200 @@ +/* + *

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614907240 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java: ## @@ -54,6 +54,8 @@ public abstract class

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614905336 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -533,4 +607,77 @@ private int

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614904850 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -533,4 +607,77 @@ private int

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
vahmed-hamdy commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614903605 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java: ## @@ -73,6 +97,8 @@ protected AsyncSinkBase(

Re: [PR] [FLINK-11529][docs-zh] Translate the "DataStream API Tutorial" page into Chinese [flink]

2024-05-25 Thread via GitHub
Rose-365 commented on PR #9097: URL: https://github.com/apache/flink/pull/9097#issuecomment-2131387633 Hello, I'm LXT, my first day in the flink community, I want to contribute to the community by translating docs, but I found that the path of this project seems to have changed, and I

Re: [PR] [doc]Flink sql gettingstarted Expression 'dept_id' is not being grouped [flink]

2024-05-25 Thread via GitHub
flinkbot commented on PR #24841: URL: https://github.com/apache/flink/pull/24841#issuecomment-2131362898 ## CI report: * fb738b0acce19682d7ba377baefe8a26f551518e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [doc]Flink sql gettingstarted Expression 'dept_id' is not being grouped [flink]

2024-05-25 Thread via GitHub
ZmmBigdata commented on PR #24841: URL: https://github.com/apache/flink/pull/24841#issuecomment-2131360809 ![image](https://github.com/apache/flink/assets/102840730/b4fa4fe6-b2b9-46a5-bedc-dc93b4fe903e) Verified already -- This is an automated message from the Apache Git Service. To

[PR] [doc]Flink sql gettingstarted Expression 'dept_id' is not being grouped [flink]

2024-05-25 Thread via GitHub
ZmmBigdata opened a new pull request, #24841: URL: https://github.com/apache/flink/pull/24841 ## What is the purpose of the change Flink sql gettingstarted Expression 'dept_id' is not being grouped

Re: [PR] [FLINK-35215][core] Add a test for deserializing an object whose serialization result is an empty byte array [flink]

2024-05-25 Thread via GitHub
1996fanrui merged PR #24837: URL: https://github.com/apache/flink/pull/24837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-25 Thread via GitHub
jeyhunkarimov commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1614421157 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -181,15 +187,88 @@ public abstract

Re: [PR] [FLINK-35242] Optimize schema evolution & add SE IT cases [flink-cdc]

2024-05-24 Thread via GitHub
hk-lrzy commented on code in PR #3339: URL: https://github.com/apache/flink-cdc/pull/3339#discussion_r1614307385 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/SchemaOperatorTranslator.java: ## @@ -58,12 +59,18 @@ public DataStream translate(

Re: [PR] [FLINK-35242] Optimize schema evolution & add SE IT cases [flink-cdc]

2024-05-24 Thread via GitHub
hk-lrzy commented on code in PR #3339: URL: https://github.com/apache/flink-cdc/pull/3339#discussion_r1612861870 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/SchemaOperatorTranslator.java: ## @@ -58,12 +59,18 @@ public DataStream translate(

Re: [PR] [FLINK-33892][runtime] Support Job Recovery from JobMaster Failures for Batch Jobs. [flink]

2024-05-24 Thread via GitHub
JunRuiLee commented on PR #24771: URL: https://github.com/apache/flink/pull/24771#issuecomment-2130666752 Thanks @zhuzhurk for the thorough review. I have refactored the BatchJobRecoveryTest and JMFailoverITCase based on your comments. PTAL. -- This is an automated message from

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1614242366 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
reta commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1614235030 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1614194871 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row/map/array type [flink]

2024-05-24 Thread via GitHub
ViktorCosenza commented on PR #24795: URL: https://github.com/apache/flink/pull/24795#issuecomment-2130263489 > @ViktorCosenza did you rebase? Yes, i did an interactive rebase and then force-pushed the squashed commits -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-24 Thread via GitHub
dannycranmer commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1613883830 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java: ## @@ -54,6 +54,8 @@ public abstract class

Re: [PR] [FLINK-30687][table] Support pushdown for aggregate filters [flink]

2024-05-24 Thread via GitHub
jeyhunkarimov commented on PR #24660: URL: https://github.com/apache/flink/pull/24660#issuecomment-2130159573 Hi @JingGe , I added support for multiple aggregates with the same filter (to push down their filters). Could you please check the PR in your available time? Thanks! -- This is

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row/map/array type [flink]

2024-05-24 Thread via GitHub
JingGe commented on PR #24795: URL: https://github.com/apache/flink/pull/24795#issuecomment-2130068966 @ViktorCosenza did you rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row/map/array type [flink]

2024-05-24 Thread via GitHub
JingGe commented on PR #24795: URL: https://github.com/apache/flink/pull/24795#issuecomment-2130067792 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to [flink]

2024-05-24 Thread via GitHub
davidradl commented on PR #24741: URL: https://github.com/apache/flink/pull/24741#issuecomment-2130035074 @reswqa all clean now. I did not backport the 1.19 change at that method was not there at 1.18. I was hoping that I could backport commit 06b3708 which introduces the getMap change to

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613758123 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
reta commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613717772 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

Re: [PR] [FLINK-35424][connectors/elasticsearch] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613711076 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

Re: [PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

2024-05-24 Thread via GitHub
flinkbot commented on PR #24840: URL: https://github.com/apache/flink/pull/24840#issuecomment-2129877895 ## CI report: * 5a78e68711f02ccaeb069376270649229d8c53c8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35316][tests] Run CDC E2e test with Flink 1.19 [flink-cdc]

2024-05-24 Thread via GitHub
yuxiqian closed pull request #3305: [FLINK-35316][tests] Run CDC E2e test with Flink 1.19 URL: https://github.com/apache/flink-cdc/pull/3305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-35316][tests] Run CDC E2e test with Flink 1.19 [flink-cdc]

2024-05-24 Thread via GitHub
yuxiqian commented on PR #3305: URL: https://github.com/apache/flink-cdc/pull/3305#issuecomment-2129877441 Addressed in #3348. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35424][connectors/elasticsearch] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613694681 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java: ## @@ -100,16

Re: [PR] [FLINK-35355][State] Internal async aggregating state and corresponding state descriptor [flink]

2024-05-24 Thread via GitHub
Zakelly closed pull request #24810: [FLINK-35355][State] Internal async aggregating state and corresponding state descriptor URL: https://github.com/apache/flink/pull/24810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

2024-05-24 Thread via GitHub
Zakelly commented on PR #24840: URL: https://github.com/apache/flink/pull/24840#issuecomment-2129858482 @fredia @ljz2051 Would you please take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-35355][State] Internal async aggregating state and corresponding state descriptor [flink]

2024-05-24 Thread via GitHub
Zakelly commented on PR #24810: URL: https://github.com/apache/flink/pull/24810#issuecomment-2129836350 CI green, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

2024-05-24 Thread via GitHub
Zakelly opened a new pull request, #24840: URL: https://github.com/apache/flink/pull/24840 ## What is the purpose of the change See FLINK-35446. It seems the file merging is disabled, thus the `FileMergingSnapshotManagerBase#initFileSystem` is never called. And at this time if we

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-05-24 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1613512120 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -93,16 +90,18 @@ spec: ``` {{< hint info >}} -When using the operator with Flink

Re: [PR] [FLINK-35424][connectors/elasticsearch] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
reta commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613490458 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java: ## @@ -100,16

Re: [PR] [FLINK-35424][connectors/elasticsearch] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
reta commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613488632 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

[PR] [FLINK-35052] Reject unsupported versions in the webhook validator [flink-kubernetes-operator]

2024-05-24 Thread via GitHub
afedulov opened a new pull request, #831: URL: https://github.com/apache/flink-kubernetes-operator/pull/831 ## What is the purpose of the change The admission webhook currently does not verify if FlinkDeployment CR utilizes Flink versions that are not supported by the Operator. This

[PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-05-24 Thread via GitHub
caicancai opened a new pull request, #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment`

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-05-24 Thread via GitHub
morazow commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2129494739 Test run built wheel artifacts: https://github.com/morazow/flink/actions/runs/9224143298 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row/map/array type [flink]

2024-05-24 Thread via GitHub
ViktorCosenza commented on PR #24795: URL: https://github.com/apache/flink/pull/24795#issuecomment-2129462557 @JingGe Are you able to trigger the CI manually? I think I't wasnt triggered after the squash because no changes were detected. -- This is an automated message from the Apache

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-24 Thread via GitHub
MartijnVisser commented on PR #190: URL: https://github.com/apache/flink-docker/pull/190#issuecomment-2129446485 @hlteoh37 Done, but I'm not sure if this actually needs to be backported to the other branches. @lincoln-lil do you know? -- This is an automated message from the Apache Git

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-05-24 Thread via GitHub
morazow commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2129446733 Hey @XComp, @HuangXingBo , What do you think of the latest commit changes for migration? This way both Linux & MacOS platform use similar build system, we also don't depend

Re: [PR] [FLINK-35129][cdc][postgres] Add checkpoint cycle option for commit offsets [flink-cdc]

2024-05-24 Thread via GitHub
morazow commented on code in PR #3349: URL: https://github.com/apache/flink-cdc/pull/3349#discussion_r1613394340 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/reader/PostgresSourceReader.java:

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24741: URL: https://github.com/apache/flink/pull/24741#discussion_r1613388125 ## flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/SqlClientTestBase.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33892][runtime] Support Job Recovery from JobMaster Failures for Batch Jobs. [flink]

2024-05-24 Thread via GitHub
zhuzhurk commented on code in PR #24771: URL: https://github.com/apache/flink/pull/24771#discussion_r1612989352 ## flink-tests/src/test/java/org/apache/flink/test/scheduling/JMFailoverITCase.java: ## @@ -532,9 +508,9 @@ private JobGraph

Re: [PR] [FLINK-35447][doc-ci] Flink CDC Document document file had removed but website can access [flink-cdc]

2024-05-24 Thread via GitHub
GOODBOY008 commented on PR #3362: URL: https://github.com/apache/flink-cdc/pull/3362#issuecomment-2129373300 @leonardBang PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [FLINK-35447][doc-ci] Flink CDC Document document file had removed but website can access [flink-cdc]

2024-05-24 Thread via GitHub
GOODBOY008 opened a new pull request, #3362: URL: https://github.com/apache/flink-cdc/pull/3362 Solution: Deletes files from the destination directory that are not present in the source directory. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-35434] Support pass exception in StateExecutor to runtime [flink]

2024-05-24 Thread via GitHub
zoltar9264 commented on code in PR #24833: URL: https://github.com/apache/flink/pull/24833#discussion_r1613094184 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStWriteBatchOperation.java: ## @@ -75,7 +74,10 @@ public

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-24 Thread via GitHub
flinkbot commented on PR #24839: URL: https://github.com/apache/flink/pull/24839#issuecomment-2129354320 ## CI report: * 2b91a9c92af7d97d492a9c83d43d7c544f85d355 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-24 Thread via GitHub
vahmed-hamdy opened a new pull request, #24839: URL: https://github.com/apache/flink/pull/24839 ## What is the purpose of the change Implementation of [FLIP-451](https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Introduce+timeout+configuration+to+AsyncSink+API)

Re: [PR] [FLINK-35415][base] Fix compatibility with Flink 1.19 [flink-cdc]

2024-05-24 Thread via GitHub
yuxiqian commented on PR #3348: URL: https://github.com/apache/flink-cdc/pull/3348#issuecomment-2129300597 Pushed another commit to resolve CI issue, could @leonardBang please re-trigger the CI? Thanks! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33892][runtime] Support Job Recovery from JobMaster Failures for Batch Jobs. [flink]

2024-05-24 Thread via GitHub
zhuzhurk commented on code in PR #24771: URL: https://github.com/apache/flink/pull/24771#discussion_r1612975806 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/BatchJobRecoveryTest.java: ## @@ -0,0 +1,1217 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1613290123 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/LineageGraph.java: ## @@ -20,13 +20,12 @@ package

Re: [PR] [FLINK-35406] Use inner serializer when casting RAW type to BINARY or… [flink]

2024-05-24 Thread via GitHub
twalthr commented on code in PR #24818: URL: https://github.com/apache/flink/pull/24818#discussion_r1613283206 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionMiscITCase.java: ## @@ -384,4 +410,15 @@ public static class

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-24 Thread via GitHub
MartijnVisser merged PR #190: URL: https://github.com/apache/flink-docker/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on PR #24835: URL: https://github.com/apache/flink/pull/24835#issuecomment-2129222164 Shouldn't this pr go in after [https://github.com/apache/flink/pull/24618](https://github.com/apache/flink/pull/24618) -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-05-24 Thread via GitHub
morazow commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1613261308 ## .github/workflows/nightly.yml: ## @@ -94,3 +94,51 @@ jobs: s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} s3_access_key: ${{

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-05-24 Thread via GitHub
morazow commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1613227700 ## .github/workflows/nightly.yml: ## @@ -94,3 +94,51 @@ jobs: s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} s3_access_key: ${{

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-05-24 Thread via GitHub
morazow commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1613226372 ## .github/workflows/nightly.yml: ## @@ -94,3 +94,51 @@ jobs: s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} s3_access_key: ${{

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-24 Thread via GitHub
hlteoh37 commented on PR #190: URL: https://github.com/apache/flink-docker/pull/190#issuecomment-2129138391 @MartijnVisser can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-35298][cdc] improve fetch delay metric reporter logic [flink-cdc]

2024-05-24 Thread via GitHub
leonardBang merged PR #3298: URL: https://github.com/apache/flink-cdc/pull/3298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35129][cdc][postgres] Add checkpoint cycle option for commit offsets [flink-cdc]

2024-05-24 Thread via GitHub
leonardBang commented on code in PR #3349: URL: https://github.com/apache/flink-cdc/pull/3349#discussion_r1613201109 ##

Re: [PR] [FLINK-35129][cdc][postgres] Add checkpoint cycle option for commit offsets [flink-cdc]

2024-05-24 Thread via GitHub
loserwang1024 commented on code in PR #3349: URL: https://github.com/apache/flink-cdc/pull/3349#discussion_r1613185257 ##

Re: [PR] [FLINK-35129][cdc][postgres] Add checkpoint cycle option for commit offsets [flink-cdc]

2024-05-24 Thread via GitHub
loserwang1024 commented on code in PR #3349: URL: https://github.com/apache/flink-cdc/pull/3349#discussion_r1613185257 ##

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-24 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1611984504 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to

Re: [PR] [FLINK-35301][cdc] fix deadlock when loading driver classes [flink-cdc]

2024-05-24 Thread via GitHub
Shawn-Hx commented on code in PR #3300: URL: https://github.com/apache/flink-cdc/pull/3300#discussion_r1613143714 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPoolFactory.java:

Re: [PR] [enhancement] add param which contain column comments of source table field [flink-cdc]

2024-05-24 Thread via GitHub
lvyanquan commented on PR #3039: URL: https://github.com/apache/flink-cdc/pull/3039#issuecomment-2129028432 Hi @dufeng1010 can you help to rebase to master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-35242] Optimize schema evolution & add SE IT cases [flink-cdc]

2024-05-24 Thread via GitHub
yuxiqian commented on PR #3339: URL: https://github.com/apache/flink-cdc/pull/3339#issuecomment-2128993381 @PatrickRen @leonardBang PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1613118293 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageDataset.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1613112277 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageDataset.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1613106837 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageDataset.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1613096352 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageDataset.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35301][cdc] fix deadlock when loading driver classes [flink-cdc]

2024-05-24 Thread via GitHub
leonardBang commented on code in PR #3300: URL: https://github.com/apache/flink-cdc/pull/3300#discussion_r1613103947 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPoolFactory.java:

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-05-24 Thread via GitHub
yuanoOo commented on PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2128951367 Please trigger the CI again,I have removed the snapshot dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1613096352 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageDataset.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35434] Support pass exception in StateExecutor to runtime [flink]

2024-05-24 Thread via GitHub
zoltar9264 commented on code in PR #24833: URL: https://github.com/apache/flink/pull/24833#discussion_r1613094184 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStWriteBatchOperation.java: ## @@ -75,7 +74,10 @@ public

Re: [PR] [FLINK-31664] Implement ARRAY_INTERSECT function [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24526: URL: https://github.com/apache/flink/pull/24526#discussion_r1613069596 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed

Re: [PR] [FLINK-35437] Rewrite BlockStatementGrouper so that it uses less memory [flink]

2024-05-24 Thread via GitHub
dawidwys merged PR #24834: URL: https://github.com/apache/flink/pull/24834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-31664] Implement ARRAY_INTERSECT function [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24526: URL: https://github.com/apache/flink/pull/24526#discussion_r1613069596 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed

  1   2   3   4   5   6   7   8   9   10   >