GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/6356
[FLINK-9790] [doc] Add documentation for UDF in SQL Client
## What is the purpose of the change
This PR aims to add document for UDF in SQL Client.
## Brief change log
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6090
Hi @twalthr, I've made some changes to the PR.
1. Add a normalize method in `ClassTypeValidator` which converts the config
like `constructor.0 = abc` to `constructor.0.type = STRING constructor.0
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6253
Hi @HeartSaVioR, really sorry for the late reply. The problem that has
always been confusing me is how to configure the date format. Anyway,
supporting the standard ISO one is a great first step
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6090
Hi @twalthr, please give me one more day. I will commit the changes
tomorrow. ð
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6090
Hi @twalthr, sorry for the delay. I've been quite busy with my graduation
these weeks. Everything's finished now and I'll put these tasks back on track.
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r198485307
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/PrimitiveTypeDescriptor.scala
---
@@ -0,0 +1,56
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r198484614
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
---
@@ -187,6 +206,7 @@ private
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r198482931
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/UDFDescriptor.java
---
@@ -0,0 +1,153
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r197005582
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/PrimitiveTypeDescriptor.scala
---
@@ -0,0 +1,56
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196998269
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/PrimitiveTypeValidator.scala
---
@@ -0,0 +1,72
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196996876
--- Diff:
flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/utils/UserDefinedFunctions.java
---
@@ -0,0 +1,105
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196996002
--- Diff:
flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
---
@@ -145,6 +146,68 @@ public
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196995942
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
---
@@ -187,6 +206,7 @@ private
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196995241
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
---
@@ -101,6 +110,16 @@ public
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196995191
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/UDFDescriptor.java
---
@@ -0,0 +1,153
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196994767
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/UDFDescriptor.java
---
@@ -0,0 +1,153
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5660
Thanks for the improvements, @twalthr.
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5660
Hi @twalthr, the PR has been reworked. Take a look when you are convenient.
Thanks!
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5660#discussion_r194250975
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableResultView.java
---
@@ -159,6 +160,9 @@ protected void
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/6106
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6106
Merging this.
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6106
It's my fault. Sorry about that:see_no_evil:
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/6106
[hotfix][table] Remove a println statement
## What is the purpose of the change
Remove a `println` statement in `TimeBoundedStreamJoin`.
## Brief change log
Remove
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/6090
[FLINK-8863] [SQL] Add user-defined function support in SQL Client
## What is the purpose of the change
This PR aims to add user-defined function (ScalarFunction, TableFunction
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5660
Sure @twalthr, I'll rebase the PR soon.
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188891227
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -809,6 +809,23 @@ trait
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188891077
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -809,6 +809,23 @@ trait
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188894442
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/logic.scala
---
@@ -105,3 +105,75 @@ case class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188895005
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarOperatorsTest.scala
---
@@ -406,5 +406,26 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188895939
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarOperatorsTest.scala
---
@@ -406,5 +406,26 @@ class
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5210
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/6003
[FLINK-9289] Parallelism of generated operators should have max parallelism
of input
## What is the purpose of the change
This PR aims to fix the default parallelism problem
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5610
Thanks for the review @twalthr. ð
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5660
I see, @twalthr. Sorry for my impatience.
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5660
Hi @twalthr and @fhueske, the PR has been rebased. I wonder if you could
help review it when you are convenient. Thanks~
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174511059
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Licensed
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174339296
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174338968
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174338993
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174338981
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174339810
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/QueryableTableSinkTest.scala
---
@@ -0,0 +1,102
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174339658
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/QueryableTableSinkTest.scala
---
@@ -0,0 +1,102
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174338955
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174338947
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173888555
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5610
Hi @twalthr, I've rebased this PR and fixed some problems.
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173879267
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173860901
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173857218
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -148,6 +148,13 @@ object SchemaValidator
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173791129
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -148,6 +148,13 @@ object SchemaValidator
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173784883
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -148,6 +148,13 @@ object SchemaValidator
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5662
Thanks for the explanation, @twalthr! I'll update the PR and resolve the
conflicts caused.
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5660
[FLINK-8861] [table] Add support for batch queries in SQL Client
## What is the purpose of the change
This PR added support for batch queries in SQL Client.
## Brief change log
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5659
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5659
[FLINK-8661] [table] Add support for batch queries in SQL Client
## What is the purpose of the change
This PR added support for batch queries in SQL Client.
## Brief change log
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5610
Hi @twalthr @fhueske, I wonder if you could help review this PR when you
are convenient.
Thanks, Xingcan
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5610
[FLINK-8537][table]Add a Kafka table source factory with Avro format support
## What is the purpose of the change
This PR adds the Kafka table source factory with Avro format
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r171354820
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -67,14 +85,129 @@ class SchemaValidator
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r171280725
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -67,14 +85,129 @@ class SchemaValidator
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5505
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170175473
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170188551
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170181909
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactoryService.scala
---
@@ -43,7 +42,7 @@ object
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170175378
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170194561
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/ConnectorDescriptorValidator.scala
---
@@ -27,13 +27,27 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170180103
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -178,46 +244,128 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170191830
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170185039
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/table/descriptors/KafkaValidator.java
---
@@ -0,0 +1,123
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5505
Yes @twalthr, that will be great! I'll start working on the
`KafkaAvroTableSourceFactory` and keep an eye on the API refactorings.
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5505
[FLINK-8538][table]Add a Kafka table source factory with JSON format support
## What is the purpose of the change
This PR adds Kafka JSON table source factories for different Kafka versions
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168446783
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonSchemaConverter.java
---
@@ -0,0 +1,358 @@
+/*
+ * Licensed
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168439090
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
---
@@ -0,0 +1,217
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168449398
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowSerializationSchema.java
---
@@ -0,0 +1,208 @@
+/*
+ * Licensed
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168438157
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonNodeDeserializationSchema.java
---
@@ -0,0 +1,53
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168439885
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonSchemaConverter.java
---
@@ -0,0 +1,358 @@
+/*
+ * Licensed
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168436287
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonNodeDeserializationSchema.java
---
@@ -0,0 +1,53
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5369
Sure. Thanks for helping merge this!
---
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5369
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5369
Ah ha, it doesn't matter. ð The test has been updated. Actually, I
wanted to ensure that all the partitioning methods should cause the exception.
However, that would be fussy and thus I only kept
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5369
That makes sense to me. I just wonder what do you mean by "add a test for
the Java API"...
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5369
Hi @aljoscha, since the `DataStream` in Java API do not own a
`setParallelism` method as the Scala API, do you think it's necessary to add
such one?
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5369
Sure. I'll update the PR to make it more appropriate and thanks for your
review, @aljoscha.
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5369
[FLINK-8407] [DataStream] Setting the parallelism after a partitioninâ¦
## What is the purpose of the change
This PR forbids the users to set parallelism after a partitioning operation
(e.g
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5368
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5368
[Flink-8407][DataStream]Setting the parallelism after a partitioning
operation should be forbidden
## What is the purpose of the change
This PR forbids the users to set parallelism after
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5210
Hi @sunjincheng121, thanks for your reply. I think an example would be
that, for some non-standard CSV files like `a, b , c,`, if the boolean flag
`trailingDelimiter=false`, the file will be parsed
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5210
Hi @sunjincheng121, yes, the reported issue should be solved with
FLINK-8331. In addition, maybe we can add the trailing delimiter as a new
feature (like the
[CSVParser.java](https://github.com
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5210
Hi @sunjincheng121, thanks for the review! You may refer to [this
thread](https://lists.apache.org/thread.html/cfe3b1718a479300dc91d1523be023ef5bc702bd5ad53af4fea5a596@%3Cuser.flink.apache.org%3E
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5140
Hi @fhueske, thanks for your concrete suggestions! IMO, the refactorings in
`TimeBoundedStreamJoin` are quite reasonable, while the refactoring for
`createNegativeWindowSizeJoin()` may not be so
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5169
Thanks for the review @twalthr ð
---
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5192
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5192
Thanks for the review, @aljoscha ð . I'll close this PR.
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5140
Hi @fhueske, thanks for your review. I've made the following changes to the
PR.
1. Fixes the "wrong sides" problem in `TimeBoundedStreamJoin`.
2. Adds the logic for outer-joins wit
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5140#discussion_r159069304
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamJoin.scala
---
@@ -182,16 +196,64 @@ abstract class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5140#discussion_r159069074
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinAwareCollector.scala
---
@@ -0,0 +1,68
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5140#discussion_r159023858
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala
---
@@ -142,50 +143,47 @@ class
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5210
[FLINK-8316][table]The CsvTableSink and the CsvInputFormat are not in sync
## What is the purpose of the change
This PR adds an extra parameter (`trailingDelim`) to `CsvTableSink` to
enable
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5177
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5177
Thanks for looking into this @fhueske. I'll close this PR.
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5177
Hi @fhueske, I wonder if you could have a look at this PR when you are
convenient.
Thanks, Xingcan
---
1 - 100 of 249 matches
Mail list logo
