Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4632
I added the test case to the `CEP Operator` and addressed the line. Thanks
so much.
---
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4673
Hi @dawidwys , Thanks for the tip, that's what I tried to add. Sorry for
the missing times().
---
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4673
Hi @dawidwys ,
I just found this issue in after match feature, which causes
AfterMatchSkipStrategy not work. This may be introduced while merging file
conflicts. I addressed that in this PR
GitHub user yestinchen opened a pull request:
https://github.com/apache/flink/pull/4673
[hotfix] [cep] Fix afterMatchStrategy parameter missing issue
## What is the purpose of the change
Fix afterMatchSkipStrategy parameter missing when calling `nfa.process
GitHub user yestinchen opened a pull request:
https://github.com/apache/flink/pull/4632
[FLINK-7563] [cep] Fix watermark semantics in cep and related tests.
## What is the purpose of the change
Correct the watermark semantics in cep.
## Brief change log
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
@dawidwys Thanks for the reviews and comments, please change the
documentation during merge.
And @kl0u , thanks for the reviews!
---
If your project is set up for it, you can reply
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r136169035
--- Diff: docs/dev/libs/cep.md ---
@@ -1250,6 +1250,104 @@ pattern.within(Time.seconds(10))
+### After Match Skip Strategy
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
Hi @dawidwys , sorry for the late response.
Thanks for your reviews, I have updated the test and the document. Please
take a look if you have time. Thanks.
---
If your project is set up
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r133478539
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -340,6 +362,65 @@ public void resetNFAChanged
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r133478273
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -150,6 +160,29 @@ long getWindowTime
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r133091608
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -340,6 +362,65 @@ public void resetNFAChanged
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
Thanks for your reviews @dawidwys ! I'll update the doc in the following
commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r132386948
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -150,6 +160,59 @@ long getWindowTime
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r132349108
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/AfterMatchSkipStrategy.java
---
@@ -0,0 +1,276 @@
+/*
+ * Licensed
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r132348950
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -150,6 +160,59 @@ long getWindowTime
GitHub user yestinchen opened a pull request:
https://github.com/apache/flink/pull/4479
[FLINK-7309][hotfix] fix NullPointerException when selecting null fields
## What is the purpose of the change
This pull request addresses FLINK-7309, adds null check before applying
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
@dawidwys @dianfu I've updated the approach according to the document. Feel
free to comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
@dianfu Thanks for your reviewing.
I found @dawidwys wrote a draft about the JIRA's implementation. I'll go
through that first and address those issues in this PR latter.
---
If your
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r130317411
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -551,18 +579,47 @@ private boolean isSelfIgnore(final
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r130317270
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -551,18 +579,47 @@ private boolean isSelfIgnore(final
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r130317122
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -551,18 +579,47 @@ private boolean isSelfIgnore(final
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
@dawidwys Thanks for the reviewing.
Problem 1 is easy to fix, we can just start a new match process if the only
left computation state reaches stopState.
Problem 2 can not be avoided
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r129518272
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -551,18 +579,47 @@ private boolean isSelfIgnore(final
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r129517227
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/AfterMatchSkipStrategy.java
---
@@ -0,0 +1,241 @@
+/*
+ * Licensed
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r129517254
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/AfterMatchSkipStrategy.java
---
@@ -0,0 +1,241 @@
+/*
+ * Licensed
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r129517161
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/AfterMatchSkipStrategy.java
---
@@ -0,0 +1,241 @@
+/*
+ * Licensed
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r129516786
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/AfterMatchSkipStrategy.java
---
@@ -0,0 +1,241 @@
+/*
+ * Licensed
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r129516650
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/CEP.java ---
@@ -36,6 +40,14 @@
* @return Resulting pattern stream
Github user yestinchen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4331#discussion_r129515022
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -551,18 +579,47 @@ private boolean isSelfIgnore(final
GitHub user yestinchen opened a pull request:
https://github.com/apache/flink/pull/4331
[FLINK-7169][CEP] Support AFTER MATCH SKIP function in CEP
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
30 matches
Mail list logo
