Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/6116
@pnowojski yes, some of dependencis in the hadoop version maintained by
our company have some coflicts with flink.
do you have any suggestions for me?
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/6118
yes, this is a hadoop-file-system discovery issue (similar case:
https://stackoverflow.com/questions/17265002/hadoop-no-filesystem-for-scheme-file),
but if flink-job dependency this `hadoop
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/6118
[FLINK-9525][filesystem] Add missing `META-INF/services/*FileSystemFactory`
file for flink-hadoop-fs
## What is the purpose of the change
more details, see JIRA:<https://issues.apache.
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/6116
when I build flink with our maintained hadoop version, the command like
this `mvn clean install -DskipTests -Dhadoop.version=2.7.0-xxx`, it will
`BUILD FAILURE`.
Some Enforcer rules have failed
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/6116
CC @pnowojski
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/6116
[FLINK-9498][build] Disable dependency convergence for
flink-end-to-end-tests
## What is the purpose of the change
*deactivate that enforce dependency convergence for
`flink-end-to-end
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5893
@zentol thanks you. I updated the code. :laughing:
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5893
i saw legacy/SubtasksAllAccumulatorsHandler.java used
gen.writeStringField("id", jobVertex.getJobVertexId().toString());.
if i change the type of `SubtasksAllAccumulatorsInfo#j
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5893
@zentol thanks for your review. I have updated the PR.
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5893
[FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler to new REST endpoint
## What is the purpose of the change
*Port SubtasksAllAccumulatorsHandler to new REST endpoint
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5731
@greghogan I have updated this PR, Please look it again.:mask:
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5891
[FLINK-9088][nifi-connector][build] Bump nifi-site-to-site-client to 1.6.0
## What is the purpose of the change
*Currently dependency of nifi-site-to-site-client is 0.6.1
We should
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5731#discussion_r177616520
--- Diff:
flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala
---
@@ -23,7 +23,7 @@ import java.io._
import
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5731
@greghogan thanks for your review. I have updated this PR.
---
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5712#discussion_r176047433
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ---
@@ -351,16 +351,16 @@ static ContainerLaunchContext
createTaskExecutorContext
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5712#discussion_r175842877
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ---
@@ -351,16 +351,16 @@ static ContainerLaunchContext
createTaskExecutorContext
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5731
[FLINK-9033][config] Replace usages of deprecated
TASK_MANAGER_NUM_TASK_SLOTS
## What is the purpose of the change
The deprecated ConfigConstants#TASK_MANAGER_NUM_TASK_SLOTS is still used
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/4826
---
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/4769
---
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/5072
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5406
:satisfied: , I addressed your comments.
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5408
[hotfix][docs] Fix typos in windows document
Hotfix typos in Windows Document.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5406
@zentol thanks for your attention to this PR, I had updated this PR
according to your comments.
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5407
[hotfix][build] Fix duplicate maven enforce plugin declaration
## What is the purpose of the change
Hotfix duplicate `maven-enforce-plugin` declaration.
## Brief change log
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5406
[hotfix][docs] Fix typos
Hotfix some typos in comments.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink fix_typos
Alternatively you
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5374#discussion_r165035180
--- Diff:
flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/Elasticsearch53ApiCallBridge.java
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5374#discussion_r165032079
--- Diff:
flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/BulkProcessorIndexer.java
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5374#discussion_r164961589
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5161
Yes, in our production environment, we report and store all metrics to an
external Time series database for alarm and visual presentation.
When the job is started, we will store the edge
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5161
@zentol :+1:
**1)**, I have no opinion.
**2), 3)**, Replace `operatorID` with `operatorName`, will be better?
@aljoscha @rmetzger what are your opinions?
---
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/5144
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5119
nice!
LGTM
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5302
[FLINK-][build] Bump japicmp to 0.11.0
## What is the purpose of the change
Currently, flink used japicmp-maven-plugin version is 0.7.0, I observed
some warning messages
, detail
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5238
[FLINK-8359][docs] Update copyright date in NOTICE
## What is the purpose of the change
NOTICE file has copyright year as 2014-2017. This needs to be updated as
2014-2018.
You can
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5213
[docs][metrics] Fix typo of metrics docs
## What is the purpose of the change
1. Fix typo of Threads.Count metric in docs.
2. Fix `Liquid Exception: highlight tag was never closed
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5113
Thanks @StephanEwen for the suggestion. I will update the PR accordingly.
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5144
Just use the static code analysis tool provided by IntelliJ IDEA.
On menu bar click on `Analyze -> Inspect Code` :)
---
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/5143
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5143
If this change does not improve performance, I agree with you keep origin
formatting. :)
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5144
[Minor][cleanup] Remove unnecessary semicolons
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink remove_unnecessary_semicolons
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5143
[FLINK-8228][cleanup] Code cleanup - pointless bitwise expressions
## Brief change log
Remove pointless bitwise expressions, Such expressions include anding with
zero, oring by zero
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5072
@greghogan, I saw the following in the `flink-core` POM:
```
org.xerial.snappy
snappy-java
```
I think this PR just upgrades the snappy-java version
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5133
LGTM.
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5076
@zentol thanks for your review. I have updated the PR.
`mvn clean verify -Dverbose -pl flink-clients`ï¼No dependency problems
found:
```
[INFO] --- maven-dependency-plugin
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5076#discussion_r154708511
--- Diff: pom.xml ---
@@ -581,6 +581,20 @@ under the License.
0.9.10
test
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/5071
---
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5113#discussion_r154520820
--- Diff: pom.xml ---
@@ -367,11 +367,10 @@ under the License.
3.2.2
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5113
[FLINK-8156][build] Bump commons-beanutils version to 1.9.3
## What is the purpose of the change
Commons-beanutils v1.8.0 dependency is not security compliant. See
[CVE-2014-0114](https
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5076
@zentol , Thanks for your suggestions, i will be very careful to clean up
the dependencies.
I will start with the top modules (not used by other modules), order as
follow:
> âââ fl
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5071#discussion_r154031899
--- Diff: docs/monitoring/metrics.md ---
@@ -94,8 +94,8 @@ Alternatively you can also use your own `Counter`
implementation:
{% highlight java
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5076#discussion_r153858786
--- Diff: pom.xml ---
@@ -891,6 +905,41 @@ under the License
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5071
@zentol , thanks for your review. I have updated the PR according to your
comments.
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5069
@tzulitai, thanks for your review. I have updated the PR according to your
comments.
---
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5069#discussion_r153841399
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -41,7 +42,6
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5076
Hi @greghogan, You're quite right, Thanks for your advice.
For a discussion of this improvement, you can see #4712.
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5076
`mvn clean verify -pl flink-clients`, No dependency problems found.
> [INFO] --- maven-dependency-plugin:3.0.2:analyze-only (analyze) @
flink-clients_2.11 ---
> [INFO] No depe
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5076
[FLINK-7574][build] POM Cleanup flink-clients
Re-created #4712.
## What is the purpose of the change
This PR changes the `flink-clients` pom to
- contain unused
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5072
[FLINK-7984][build] Bump snappy-java to 1.1.4
## What is the purpose of the change
This PR bumps the snappy-java version to 1.1.14.
snappy-java-1.1.4 (2017-05-22):
- Fix a 1
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5071
[FLINK-7907][docs] The metrics documentation missing scala snippets
## What is the purpose of the change
*The metrics documentation is missing Scala examples for many of the
metrics types
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5069
[FLINK-8149][kinesis] Replace usages of deprecated SerializationSchema
## What is the purpose of the change
The deprecated `SerializationSchema` in `flink-streaming-java`, has been
moved
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5067
[FLINK-8142][config] Cleanup reference to deprecated constants in
ConfigConstants
## What is the purpose of the change
ConfigConstants contains several deprecated String constants
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/4712
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5034
[FLINK-8105][minor] Removed unnecessary null check
## What is the purpose of the change
Removed unnecessary null check
eg.
`if (value != null && value instanceof String)`
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5001
:wink: @zentol , Thank you for your careful review.
This PR has been updated.
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5001
[FLINK-7679][build[[java9] Upgrade maven enforcer plugin to 3.0.0-M1
## What is the purpose of the change
Maven enforcer plugin fails after Java 9 build 175
[(MENFORCER-274)](https
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5000
[hotfix][docs] Fix typos in deployment AWS documentation
Remove double "you" in Deployment AWS documentation.
You can merge this pull request into a Git repository by running:
$ git
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4999
[hotfix][docs][javadocs] Remove double "of"
Remove double "of" word in document and java docs.
You can merge this pull request into a Git repository by running:
$ git pul
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4978
thx @tillrohrmann , removed the redundant import.
---
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/4948
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4948
@StephanEwen
make sense.
I will close this PR.
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4978
[FLINK-7704][hotfix][flip6] Fix JobPlanInfoTest package path
This PR fix the package path of `JobPlanInfoTest`, consistent with the
JobPlanInfo `org.apache.flink.runtime.rest.messages`.
You
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4826
ping @zentol
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4964
[hotfix][docs] Add type for numLateRecordsDropped metric in documentation
This "numLateRecordsDropped" metric missing type described in the document:
 overload to log exceptions
## What is the purpose of the change
When logging an exception, we often convert the exception to string or call
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/4898#discussion_r148934171
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobAccumulatorsInfo.java
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4769
@tzulitai , confirm.
because the `FlinkKafkaConsumer011` extend from `FlinkKafkaConsumer010`
and `Kafka010Fetcher` extend from `Kafka09Fetcher`, for Kafka connector only
need to fix
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4869
@zentol , thinks for your reviewing. I addressed some of your comments.
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4826
Sorry to reply late, @zentol could you will merge this PR?
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4794
@StephanEwen, @greghogan , I'm sorry to reply late, a little busy recently.
Stephan, I agree with you.
This PR has been updated.
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4898
@tillrohrmann, could you please take a look? :)
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4712
thx @zentol, I will add the `maven-dependency-plugin` to flink-parent
pom.xml file.
```
org.apache.maven.plugins
maven-dependency-plugin
3.0.2
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/4869#discussion_r147100695
--- Diff: docs/monitoring/metrics.md ---
@@ -856,66 +918,80 @@ Thus, in order to infer the metric identifier:
- Scope
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/4869#discussion_r147092709
--- Diff: docs/monitoring/metrics.md ---
@@ -856,66 +918,80 @@ Thus, in order to infer the metric identifier:
- Scope
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/4869#discussion_r147091360
--- Diff: docs/monitoring/metrics.md ---
@@ -801,53 +849,67 @@ Thus, in order to infer the metric identifier:
- Scope
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/4869#discussion_r147090946
--- Diff: docs/monitoring/metrics.md ---
@@ -801,53 +849,67 @@ Thus, in order to infer the metric identifier:
- Scope
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/4869#discussion_r147090107
--- Diff: docs/monitoring/metrics.md ---
@@ -543,62 +546,75 @@ Thus, in order to infer the metric identifier
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/4869#discussion_r147090125
--- Diff: docs/monitoring/metrics.md ---
@@ -543,62 +546,75 @@ Thus, in order to infer the metric identifier
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4898
[FLINK-7706] [flip6] Add JobAccumulatorsHandler for new REST endpoint
## What is the purpose of the change
*Port JobAccumulatorsHandler to REST endpoint*
## Brief change log
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4794
@StephanEwen ping
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4769
@zentol ping. I have updated this PR.
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4661
@zentol thanks a lot for your review. I have updated the PR according to
your comments.
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4712
@tillrohrmann , Please let me know if this is good :)
---
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/4875
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4885
[hotfix][docs] Fix typos in documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink fix_typos_in_project_setup_docs
GitHub user yew1eb reopened a pull request:
https://github.com/apache/flink/pull/4714
[FLINK-7577][build][WIP] POM Cleanup flink-core
## What is the purpose of the change
This PR changes the flink-core pom to
- not contain unused dependencies
- contain all used
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/4714
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4875
@pnowojski, I found to fix this PR, must first solve the `flink-core`,
`flink-runtime`, and so on. Please ignore this PR, I will close it.
Please feel free to continue working on **Enable
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4875
[FLINK-7889] Enable dependency convergence in flink-streaming-java
Base on #4777
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4777
@pnowojski
Multiple commits may refer to the same issue, if the issue is fixed in
multiple steps.
```
[FLINK-1234] [runtime] Runtime support some cool new thing
[FLINK-1234] [java
1 - 100 of 184 matches
Mail list logo
