[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205106925 --- Diff: flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/DataSetAllroundTestProgram.java --- @@ -66,14 +61,21

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205108213 --- Diff: flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/Generator.java --- @@ -0,0 +1,147

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205108561 --- Diff: flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/Generator.java --- @@ -0,0 +1,147

[GitHub] flink pull request #6407: [FLINK-9877][docs] Add documentation page for diff...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6407#discussion_r205097411 --- Diff: docs/dev/stream/operators/joining.md --- @@ -0,0 +1,286 @@ +--- +title: "Joining" +nav-id: streaming_joins +nav-show_over

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205087147 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash

[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6378 merging. ---

[GitHub] flink issue #6402: [FLINK-9914][docs] Update Docker docs

2018-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6402 merging. ---

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205081350 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash

[GitHub] flink issue #6409: [FLINK-9899][Kinesis Connecotr] Add comprehensive per-sha...

2018-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6409 New metrics should be documented in https://ci.apache.org/projects/flink/flink-docs-master/monitoring/metrics.html#kinesis-connectors. ---

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205078058 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205069073 --- Diff: flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/DataSetAllroundTestProgram.java --- @@ -66,14 +59,21

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205070681 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205070467 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205070430 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205072007 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205070024 --- Diff: flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/Generator.java --- @@ -0,0 +1,166

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205071341 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205070634 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6416: [FLINK-9942][rest] Guard handlers against null fie...

2018-07-25 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6416 [FLINK-9942][rest] Guard handlers against null fields ## What is the purpose of the change This PR fixes prevents some NPEs that could arise if fields in the request are set to null

[GitHub] flink pull request #6406: [FLINK-9159][runtime] Sanity check default timeout...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6406#discussion_r204820593 --- Diff: flink-docs/README.md --- @@ -28,7 +28,7 @@ The `RestAPIDocGenerator` can be used to generate a full reference of the REST A To integrate a new

[GitHub] flink issue #6396: [FLINK-9806][docs] Add canonical link element to docs

2018-07-24 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6396 we can keep the hotfix in this PR but it shouldn't be squashed into the main commit as it is unrelated. ---

[GitHub] flink pull request #6406: [FLINK-9159][runtime] Sanity check default timeout...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6406#discussion_r204819304 --- Diff: flink-docs/README.md --- @@ -28,7 +28,7 @@ The `RestAPIDocGenerator` can be used to generate a full reference of the REST A To integrate a new

[GitHub] flink pull request #6400: [FLINK-9931][ui] watermark display bug.

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6400#discussion_r204758822 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobVertexMetricsHandler.java --- @@ -28,15 +35,21

[GitHub] flink pull request #6400: [FLINK-9931][ui] watermark display bug.

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6400#discussion_r204757730 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobVertexMetricsHandler.java --- @@ -57,4 +70,77 @@ public

[GitHub] flink pull request #6400: [FLINK-9931][ui] watermark display bug.

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6400#discussion_r204759313 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobVertexMetricsHandler.java --- @@ -28,15 +35,21

[GitHub] flink pull request #6388: [FLINK-6222] Allow passing env variables to start ...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6388#discussion_r204750473 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -96,6 +96,8 @@ DEFAULT_ENV_JAVA_OPTS=""# Optiona

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720999 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -297,7 +300,13 @@ public void testFailingDataSinkTask

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721547 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSourceTaskTest.java --- @@ -45,33 +46,30 @@ public class

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721015 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -337,7 +345,13 @@ public void

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721035 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -363,7 +376,9 @@ public void testCancelDataSinkTask

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720914 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -79,12 +75,11 @@ public void testDataSinkTask

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721046 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -419,7 +432,13 @@ public void

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721390 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSourceTaskTest.java --- @@ -45,33 +46,30 @@ public class

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720983 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -225,7 +224,13 @@ public void testSortingDataSinkTask

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204718919 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204722139 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/EnumerateNestedFilesTest.java --- @@ -240,36 +205,19 @@ public void

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204719730 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorITCase.java --- @@ -127,7 +132,7 @@ public void testSlotAllocation

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720974 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -141,7 +136,13 @@ public void testUnionDataSinkTask

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204719565 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java --- @@ -218,7 +224,7 @@ public void TestAnonymousClass() throws

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720758 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -49,22 +50,17 @@ import static

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720065 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/EnumerateNestedFilesTest.java --- @@ -338,22 +279,11 @@ public void

[GitHub] flink issue #6398: [FLINK-9923][tests] Harden OneInputStreamTaskTest#testWat...

2018-07-24 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6398 well, that's a fairly general statement isn't it :/ Unless we find any mention anywhere of a major JVM not adhering to the JLS in this regard, that is suited for Flink applications, I would

[GitHub] flink issue #6398: [FLINK-9923][tests] Harden OneInputStreamTaskTest#testWat...

2018-07-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6398 Do you have a source for volatile longs not being supported in all JVM implementations? I'm asking since the (expected) behavior is defined in the [Java Language Specification](https

[GitHub] flink issue #6388: [FLINK-6222] Allow passing env variables to start scripts...

2018-07-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6388 If a feature isn't visibly documented chances are no one will use it ;) I'm not sure if the configuration page is the right place to put it, as it so far deals exclusively with settings set

[GitHub] flink pull request #6395: [FLINK-9900][tests] Harden ZooKeeperHighAvailabili...

2018-07-23 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6395 [FLINK-9900][tests] Harden ZooKeeperHighAvailabilityITCase ## What is the purpose of the change This PR makes a few modifications to the `ZooKeeperHighAvailabilityITCase` to reduce

[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-22 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6378 @zhangminglei @YCjia Please do not push changes for the sole purpose of re-triggering Travis. We already know that they passed (due to the travis fork), and realistically there's no way

[GitHub] flink pull request #6372: [Flink 9353] Tests running per job standalone clus...

2018-07-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6372#discussion_r204018623 --- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh --- @@ -51,6 +51,7 @@ run_test "Shaded Hadoop S3A end-to-end test" "$END_TO_END_D

[GitHub] flink pull request #6377: [FLINK-8981] Add end-to-end test for running on YA...

2018-07-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6377#discussion_r203998139 --- Diff: flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/Dockerfile --- @@ -0,0 +1,159

[GitHub] flink pull request #6377: [FLINK-8981] Add end-to-end test for running on YA...

2018-07-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6377#discussion_r203997764 --- Diff: flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/bootstrap.sh --- @@ -0,0 +1,121 @@ +#!/bin/bash

[GitHub] flink pull request #6377: [FLINK-8981] Add end-to-end test for running on YA...

2018-07-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6377#discussion_r203974298 --- Diff: flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/bootstrap.sh --- @@ -0,0 +1,121 @@ +#!/bin/bash

[GitHub] flink pull request #6377: [FLINK-8981] Add end-to-end test for running on YA...

2018-07-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6377#discussion_r203972431 --- Diff: flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/config/log4j.properties --- @@ -0,0 +1,354

[GitHub] flink pull request #6377: [FLINK-8981] Add end-to-end test for running on YA...

2018-07-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6377#discussion_r203972230 --- Diff: flink-end-to-end-tests/test-scripts/test_yarn_kerberos_docker.sh --- @@ -0,0 +1,104 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6377: [FLINK-8981] Add end-to-end test for running on YA...

2018-07-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6377#discussion_r203969501 --- Diff: flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/README.md --- @@ -0,0 +1,118 @@ +# Apache Hadoop Docker image with Kerberos

[GitHub] flink pull request #6377: [FLINK-8981] Add end-to-end test for running on YA...

2018-07-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6377#discussion_r203973291 --- Diff: flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/Dockerfile --- @@ -0,0 +1,159

[GitHub] flink pull request #6377: [FLINK-8981] Add end-to-end test for running on YA...

2018-07-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6377#discussion_r203973314 --- Diff: flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/Dockerfile --- @@ -0,0 +1,159

[GitHub] flink issue #6370: [FLINK-9894] [runtime] Potential Data Race

2018-07-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6370 If another PR introduces race conditions, then these race conditions should be resolved in that very PR. ---

[GitHub] flink pull request #6374: [FLINK-9895][tests] Ensure error logging for Netty...

2018-07-19 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6374 [FLINK-9895][tests] Ensure error logging for NettyLeakDetectionResource ## What is the purpose of the change This PR is a small addition to #6363 to ensure that ERROR logging is enabled

[GitHub] flink pull request #6371: [FLINK-9871] Use Description class for ConfigOptio...

2018-07-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6371#discussion_r203692344 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java --- @@ -42,22 +45,27 @@ public static final ConfigOption

[GitHub] flink pull request #:

2018-07-19 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/ec28f92ffd042308494d9661a38ab462738611aa#commitcomment-29761887 In flink-core/src/main/java/org/apache/flink/configuration/Configuration.java: In flink-core/src/main/java/org/apache/flink

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203662639 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java --- @@ -0,0 +1,103

[GitHub] flink issue #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHandler

2018-07-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6363 merging. ---

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203658272 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyServer.java --- @@ -61,6 +62,7 @@ private ChannelFuture

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203657904 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyClient.java --- @@ -52,6 +55,7 @@ private Bootstrap

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203652194 --- Diff: docs/ops/security-ssl.md --- @@ -33,6 +33,9 @@ SSL can be enabled for all network communication between Flink components. SSL k

[GitHub] flink pull request #6342: [FLINK-9748][release] Use dedicated directory for ...

2018-07-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6342#discussion_r203629175 --- Diff: tools/releasing/create_binary_release.sh --- @@ -44,6 +44,12 @@ else SHASUM="sha512sum" fi +cd .. + +FLIN

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203437995 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java --- @@ -160,4 +160,41 @@ key("security.ssl.v

[GitHub] flink issue #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHandler

2018-07-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6363 +1 ---

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203422176 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java --- @@ -0,0 +1,84

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203414529 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java --- @@ -220,4 +224,5 @@ public void

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203414700 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java --- @@ -0,0 +1,84

[GitHub] flink issue #6352: [FLINK-9815][yarn][tests] Harden tests against slow job s...

2018-07-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6352 yay travis is green. ---

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203373280 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java --- @@ -50,6 +55,24 @@ private static final

[GitHub] flink pull request #6330: [FLINK-9499][rest] Support JSON request in JarHand...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6330#discussion_r203361773 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java --- @@ -138,12 +154,22 @@ public JarRunHandler

[GitHub] flink issue #6296: [FLINK-9793] YARN:When submitting a flink job with yarn-c...

2018-07-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6296 merging. ---

[GitHub] flink pull request #6362: [FLINK-9888][release] Remove unsafe defaults from ...

2018-07-18 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6362 [FLINK-9888][release] Remove unsafe defaults from release scripts ## What is the purpose of the change This PR removes several unnecessary and unsafe `*_VERSION` defaults from the release

[GitHub] flink issue #6352: [FLINK-9815][yarn][tests] Harden tests against slow job s...

2018-07-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6352 The `YARNHighAvailabilityITCase` still has the same problem. ---

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203326103 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java --- @@ -160,4 +160,41 @@ key("security.ssl.v

[GitHub] flink pull request #6330: [FLINK-9499][rest] Support JSON request in JarHand...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6330#discussion_r203309580 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunRequestBody.java --- @@ -0,0 +1,109 @@ +/* + * Licensed

[GitHub] flink pull request #6312: [FLINK-9792] Added custom Description class for Co...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6312#discussion_r203306483 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/description/Formatter.java --- @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6312: [FLINK-9792] Added custom Description class for Co...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6312#discussion_r203305919 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/description/Formatter.java --- @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6330: [FLINK-9499][rest] Support JSON request in JarHand...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6330#discussion_r203303832 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java --- @@ -138,12 +154,22 @@ public JarRunHandler

[GitHub] flink pull request #6330: [FLINK-9499][rest] Support JSON request in JarHand...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6330#discussion_r203302981 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerParameterTest.java --- @@ -0,0 +1,313

[GitHub] flink pull request #6330: [FLINK-9499][rest] Support JSON request in JarHand...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6330#discussion_r203302518 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunRequestBody.java --- @@ -0,0 +1,109 @@ +/* + * Licensed

[GitHub] flink issue #6352: [FLINK-9815][yarn][tests] Harden tests against slow job s...

2018-07-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6352 will look into them tomorrow ---

[GitHub] flink issue #6352: [FLINK-9815][yarn][tests] Harden tests against slow job s...

2018-07-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6352 the test failures may highlight tests that weren't shutting down the last application properly; previously this would've succeeded since the check was done in `@Before`. ---

[GitHub] flink pull request #6312: [FLINK-9792] Added custom Description class for Co...

2018-07-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6312#discussion_r203074481 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6312: [FLINK-9792] Added custom Description class for Co...

2018-07-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6312#discussion_r203069199 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6312: [FLINK-9792] Added custom Description class for Co...

2018-07-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6312#discussion_r203069177 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6352: [FLINK-8163][yarn][tests] Harden tests against slo...

2018-07-17 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6352 [FLINK-8163][yarn][tests] Harden tests against slow job shutdowns ## What is the purpose of the change This PR hardens the `YarnTestBase` against jobs that just don't want to shut down

[GitHub] flink issue #6347: [hotfix] consistency: vertexes -> vertices

2018-07-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6347 yes ---

[GitHub] flink pull request #6312: [FLINK-9792] Added custom Description class for Co...

2018-07-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6312#discussion_r202970121 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6312: [FLINK-9792] Added custom Description class for Co...

2018-07-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6312#discussion_r202969620 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6294: [FLINK-9013][docs] Document yarn.containers.vcores...

2018-07-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6294#discussion_r202968456 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/description/TextElement.java --- @@ -53,6 +55,16 @@ public static TextElement text(String

[GitHub] flink pull request #6350: [FLINK-9873][runtime] Log task state when aborting...

2018-07-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6350#discussion_r202962522 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java --- @@ -457,13 +457,20 @@ public

[GitHub] flink pull request #6350: [FLINK-9873][runtime] Log task state when aborting...

2018-07-17 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6350 [FLINK-9873][runtime] Log task state when aborting checkpoint ## What is the purpose of the change This PR adjusts the logging message for when a checkpoint is declined due to tasks

[GitHub] flink pull request #6349: [FLINK-6997][tests] Properly cancel test job

2018-07-17 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6349 [FLINK-6997][tests] Properly cancel test job ## What is the purpose of the change With this PR the jobs started in `SavepointITCase#testSavepointForJobWithIteration` are properly canceled

[GitHub] flink issue #6347: [hotfix] consistency: vertexes -> vertices

2018-07-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6347 `vertices` is the correct plural, but this is another one of those cases where fixing it might cause more harm than good since it could cause merge conflicts, yet provides no functional benefit

[GitHub] flink pull request #6342: [FLINK-9748][release] Use dedicated directory for ...

2018-07-16 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6342 [FLINK-9748][release] Use dedicated directory for release artifacts ## What is the purpose of the change With this PR artifacts created during the release process are no longer placed

[GitHub] flink issue #6327: [FLINK-9839][e2e] add end-to-end tests with SSL enabled

2018-07-16 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6327 merging. ---

[GitHub] flink pull request #6340: [FLINK-9842][rest] Pass actual configuration to Bl...

2018-07-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6340#discussion_r202655858 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandlerTest.java --- @@ -57,24 +60,39 @@ /** * Tests

  1   2   3   4   5   6   7   8   9   10   >