TanYuxin-tyx commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1537644742
@godfreyhe @JunRuiLee Thanks for helping review the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
TanYuxin-tyx commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1525612113
@godfreyhe Thanks for helping review the change. I have updated the code
according to the comments.
I add 3 methods in `BatchAbstractTestBase`, `createTempFolder`,
TanYuxin-tyx commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1524629429
I don't change the TimestampITCase finally, because separating to a new
commit will cause the previous commit of `Migrate BatchTestBase to junit5` can
not run the test successfully,
TanYuxin-tyx commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1524586407
@JunRuiLee I agree that the sub subclasses migration can be in separate
commits.
The reason for migrating some subclasses is that these classes have some
problems in the new
TanYuxin-tyx commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1523290741
@JunRuiLee Thanks for joining the review. Considering that the two base
classes have many table-related and Scala-related subclasses, it is indeed
necessary to upgrade all the
