Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4145
Hi @wuchong ! Nice work!
I have some changes to propose in the code itself, but before moving on
with this, I have some questions about the need of the change.
For the second, I have
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/4145
@dianfu I've created a JIRA
https://issues.apache.org/jira/browse/FLINK-6983 for it. Let's move the
discussion there.
---
If your project is set up for it, you can reply to this email and have
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4145
@dawidwys In my mind, to achieve `translating them to newly constructed
graph of states`, we only need to get the state from the NFA by the `state
name` stored in `ComputationState`. Not sure if my
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/4145
@dianfu I agree that we should consider removing states from serialization,
but I have some concerns about it:
1. `State`s are part of `ComputationState`s which describe partial matches,
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4145
@dianfu I agree with you. I think we can improve that in another JIRA.
@dawidwys I have addressed all the comments.
@kl0u It'll be great if you can have a look.
Cheers,
Jark
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4145
Nice work. Just one comment: the states in NFA is metadata, maybe we should
get rid of serializing them at all?
---
If your project is set up for it, you can reply to this email and have your
reply
