Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4153
@dawidwys Thanks a lot for the review. Updated the doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/4153
@dianfu Thanks for the update. The code looks really nice right now. The
only thing that is missing for this PR, are the docs. Could you please add a
section about the group patterns?
---
If your
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4153
@dawidwys thanks a lot for your comments. Have updated the PR and it should
have addressed all the comments. :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4153
Hi @dianfu and @dawidwys .
I think that we should stick to the current API as:
1) a new API will raise serious backwards compatibility concerns,
2) people have already started
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/4153
@dianfu sorry I have not reviewed it yet, but I do think this feature would
benefit from reworking of the Pattern API I propose in
[FLINK-3414](https://issues.apache.org/jira/browse/FLINK-3414).
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4153
rebase the code and @dawidwys @kl0u could you help to take a look at this
PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4153
@dawidwys @kl0u It will be great if you could take a look at this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
