[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-22 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 Thanks! Closing it ---

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-22 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4655 Perfect! Thanks for working on this. 👍 I merged, could you please close this PR? ---

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-20 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 Hi @aljoscha It turned out that exclude filter works if we escape dollar signs. I commited these changes, but I believe it still should be fixed by japicmp What do you think about merging

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-15 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4655 Thanks! This doesn't help us with our situation, though. ---

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-15 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 Thansk, Aljoscha Probably I've forgotten to run `clean`. The method `iterate$default$3` is a method which automatically created by Scala for calculation of default value for parameter

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-15 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4655 A local build of `mvn clean verify` fails for me because the japicmp plugin is complaining. The relevant section of the diff output from japicmp is ``` ***! MODIFIED CLASS: PUBLIC

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-14 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 The local build works fine. If you mean `mvn verify` by compatibility plugin it also worked with no issues ---

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-14 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4655 You can try and run the build locally to have a look at the file generated by the compatibility plugin. Then we can figure out why it's complaining. ---

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-07 Thread mlipkovich
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 As I understand the build has failed because of changed API method. The method which was changed has annotation PublicEvolving so there should be a way to change it. As was mentioned by @aljoscha