[GitHub] flink issue #4658: [Flink-7596][Table API & SQL] fix bug when Set Operation ...

2017-09-26 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4658 Thanks for looking into this @Xpray. The changes look good, I would only generalize it a little bit and check for the same `GenericRelDataType` type. I will do it while merging... ---

[GitHub] flink issue #4658: [Flink-7596][Table API & SQL] fix bug when Set Operation ...

2017-09-14 Thread Xpray
Github user Xpray commented on the issue: https://github.com/apache/flink/pull/4658 @twalthr , I've rewrite the methods, please have a look. ---

[GitHub] flink issue #4658: [Flink-7596][Table API & SQL] fix bug when Set Operation ...

2017-09-14 Thread Xpray
Github user Xpray commented on the issue: https://github.com/apache/flink/pull/4658 what about overriding `leastRestrictiveSqlType` method in `FlinkTypeFactory`? ---

[GitHub] flink issue #4658: [Flink-7596][Table API & SQL] fix bug when Set Operation ...

2017-09-14 Thread Xpray
Github user Xpray commented on the issue: https://github.com/apache/flink/pull/4658 Thanks for your advice. I am considering a better way to solve this. ---