Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4665
merging.
---
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4665
Hi @zentol , can you help merge this pr ? Is this be forgetten
---
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4665
is there still anything wrong @zentol
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4665
LGTM
---
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4665
is this ok to be merged in @bowenli86 @zentol @aljoscha ? ð
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4665
@aljoscha sorry for being late the this CR. I left a couple comments
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4665
This looks good to merge now. ð
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4665
Would be good to rename the metric to `numLateRecordsDropped` to be more
consistent with existing metrics.
@aljoscha will have to comment on whether the counting is correct or not.
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4665
Hello,Is it can be merged in @aljoscha @zentol ?
---
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4665
@aljoscha yes, i review the code this day, it will jude each window whether
late , so the previous method i use will counts more lost data than the actual
situation , i have fix the error and
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4665
@Aitozi I meant that the place where you're currently counting dropped
elements will not yield a correct count because one element might be in several
windows. The place were we side-output late
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4665
@aljoscha i agree that the name set to be "numLateElementsDropped", and do
you mean that my result should minus the num of element that go to side output
which is skipped and lateElement?
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4665
These are not actually the places where you can count dropped data. I would
suggest to add this at the very end of `processElement()` where we also check
whether we should side-output late data:
13 matches
Mail list logo