Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4777
Thanks!
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4777
Thanks!
Could you please close if GH doesn't auto-close?
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4777
https://issues.apache.org/jira/browse/FLINK-7765 - this is a parent issue
enclosing fixing other modules. Split between other subtasks is very, very
arbitrary, but I guess next milestone would be
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4777
I'll merge, yes, what are the follow-up issues you created?
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4777
All is green, could we merge this? This PR has a quite large silent
conflict chance during rebasing :( (whenever someone changes any dependency on
master)
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4777
@aljoscha `combine.self="override"` couldn't work because `` can not
be empty, so I couldn't override `maven-enforcer-plugin` with an empty
configuration. Instead I have enabled convergence by
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4777
But then any change in `maven-enforcer-plugin` configuration would have to
be repeated and manually added in every place where dependency convergence was
overridden.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4777
I think you can override configuration via a `combine.self="override"`
configuration. This way we could define the convergence config in the root pom
and override in child poms that don't yet
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4777
I'm not sure if you can easily disable convergence in child pom.
I think that shading happens after resolving dependency versions. So first
you would need to fix dependency convergence for
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4777
How does this interact with the shade plugin, i.e. what happens if a
relocated transitive dependency has a different version than another direct
dependency?
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4777
Looks good - still the open question whether we add dependency convergence
by default, and deactivate it in not yet done modules. That gives the completed
modules a "done" feeling and king of
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4777
@pnowojski
Multiple commits may refer to the same issue, if the issue is fixed in
multiple steps.
```
[FLINK-1234] [runtime] Runtime support some cool new thing
[FLINK-1234] [java
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4777
I created subtasks in JIRA for the follow ups, however I have bundled them
pretty arbitrarily (creating a subtask per module would be tiresome)
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4777
Looks good to me. Please create follow-up JIRAs for the remaining modules.
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4777
If this is merged, #2192 can be probably closed.
---
15 matches
Mail list logo
