[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-11-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4798 Done. @bowenli86 Can you please close this PR? ---

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-11-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4798 +1 also from my side, I will merge this. ---

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-11-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4798 +1 to having this in 1.4. @StefanRRichter, can you please merge once you're satisfied? ---

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-11-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4798 @StefanRRichter @aljoscha is it still possible to get this into 1.4? ---

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-11-09 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4798 Hi @StefanRRichter , do you have more feedbacks? ---

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-10-22 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4798 I only had a minor comment, overall the PR looks good! 👍 ---

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-10-22 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4798 Hi @StephanEwen @StefanRRichter , please let me know if you have any more feedbacks ---

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-10-13 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4798 Probably good change for now. I think in the long run, the TaskManager should give each Task a sub-directory and make sure that sub directory is cleared whenever tasks