Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4945
Sounds good. Thanks, @zentol !
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4945
@bowenli86 I've merged the PR to 1.4, could you close the PR? Note that i
have filed FLINK-8082 to bump the api check on master once 1.4 is released.
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4945
Sounds good. Thanks @zentol ! ð
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4945
Merging on hold until FLINK-8083 is resolved.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4945
Will set the version to compare against to 1.3.2 and merge it.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4945
@greghogan That's a great point.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4945
@greghogan That makes sense, I didn't think about added APIs.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4945
@zentol but we need a check against additions to the API since 1.0.
Enabling `breakBuildOnModifications` in bugfix releases which don't add the API
wouldn't require updating compatibility versions
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4945
Ultimately it shouldn't make a difference, but comparing against 1.0.X
would require less maintenance as we no longer have to update it with every
release.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4945
@greghogan I commented on the issue. Yes this is the API compatibility
check and the API should actually stay stable for all of the 1.x series. That's
also why I'm wondering why we're comparing
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4945
Isn't this API compatibility rather than checkpoint/savepoint
compatibility? And if the former should not 1.4 be checked against 1.3 (which
should be checked against 1.2, etc.)?
---
11 matches
Mail list logo
