[GitHub] flink issue #4955: [FLINK-7978][kafka] Ensure that transactional ids will ne...

2017-11-08 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4955 Thanks for reviews and merging! ---

[GitHub] flink issue #4955: [FLINK-7978][kafka] Ensure that transactional ids will ne...

2017-11-07 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4955 Thanks for fixing this! And thanks for the review! I merged, could you please close the PR? ---

[GitHub] flink issue #4955: [FLINK-7978][kafka] Ensure that transactional ids will ne...

2017-11-07 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4955 LGTM once Travis is green. ---

[GitHub] flink issue #4955: [FLINK-7978][kafka] Ensure that transactional ids will ne...

2017-11-06 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4955 @GJL @tzulitai could you take a look? ---