[GitHub] flink issue #4959: [FLINK-7998] private scope is changed to public to resolv...

2017-11-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4959 Thank you for fixing this, merging. ---

[GitHub] flink issue #4959: [FLINK-7998] private scope is changed to public to resolv...

2017-11-10 Thread vetriselvan1187
Github user vetriselvan1187 commented on the issue: https://github.com/apache/flink/pull/4959 @greghogan @naeioi have done some changes in both TPCHQuery3.scala and TCPCHQuery3.java ---

[GitHub] flink issue #4959: [FLINK-7998] private scope is changed to public to resolv...

2017-11-07 Thread naeioi
Github user naeioi commented on the issue: https://github.com/apache/flink/pull/4959 Also can you replace `params.get("order")` with `params.get("orders")` in TPCHQuery3.scala for consistency with java and the input hint? ---

[GitHub] flink issue #4959: [FLINK-7998] private scope is changed to public to resolv...

2017-11-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4959 Looks good but I have not tested. Can we also fix the parameter swap referenced in the JIRA? ---