Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-141402922
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1045
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-141024224
Can you add a test case that checks if "returns" works now. See the JIRA
example.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-141110503
Looks good to merge, if build succeeds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-141121393
One failing test in new to me. Do we need a JIRA for it?
```
Tests in error:
CompactingHashTableTest.testHashTableGrowthWithInsert:98->getMemory:243
»
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-140810066
I've removed the refactoring commit and did a rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-140098455
I'm ok with this approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-139741907
I am not familiar with the TypeExtractor in detail, but would support to
fix the bug first and open a separate issue to refactor the extractor, if that
is possible.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-139234472
@fhueske well I'm still waiting for an answer as to how to proceed. Either
return a MissingTypeInfo or throw some checked Exception when the type could
not be
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-139226620
@zentol Any news on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-135365948
@zentol This is a delicate change, so let's make sure we understand this
correctly:
The InvalidTypesException is now only used internally in the type
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-135370839
@StephanEwen yes, generally InvalidTypesExceptions are not propagated,
except TypeExtractor.getInfoFor(Class ...), which is both public and used in
the TypeExtractor.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-135373495
An exception is probably preferable since it would be consistent with the
getInfoFor() method.
---
If your project is set up for it, you can reply to this email and
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-135364762
@tillrohrmann This distinction between checked and unchecked exceptions is
a good point. It is not very consistent in the project so far, but we should
definitely
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-134203619
InvalidTypesException (from here on abbreviated as ITE) is no longer
unchecked.
For this to work i had to make changes in surprisingly many classes so
let's
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-134129643
I agree, will get right on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1045#issuecomment-134108201
The PR seems to solve the problem. However, I'm wondering why the
`InvalidTypesException` is an unchecked exception. I think that this is the
actual culprit and
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1045
[FLINK-2557] TypeExtractor properly returns MissingTypeInfo
This fix is not really obvious so let me explain:
getParameterTye() is called from two different places in the TypeExtractor;
to
18 matches
Mail list logo
