Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146891099
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41503795
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -68,38 +94,62 @@ object FlinkShell {
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41503815
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -68,38 +94,62 @@ object FlinkShell {
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41503634
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -18,48 +18,74 @@
package
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41504281
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,8 +223,50 @@ class
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146519237
Hi @nikste, thanks for update. It looks good to merge except some style
issues.
---
If your project is set up for it, you can reply to this email and have your
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146520283
@chiwanpark, white line issues are now fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41503746
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -68,38 +94,62 @@ object FlinkShell {
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41503700
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -68,38 +94,62 @@ object FlinkShell {
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41503724
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -68,38 +94,62 @@ object FlinkShell {
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41504146
--- Diff: docs/apis/scala_shell.md ---
@@ -30,15 +30,16 @@ Flink and setting up a cluster please refer to
To use the shell with an integrated Flink
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146507345
Hey @chiwanpark !
I've rebased this to the current master. Would be nice if this can be
merged soon if there are no further comments on this PR!
---
If your
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41503504
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -18,48 +18,74 @@
package
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41503540
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -18,48 +18,74 @@
package
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41503568
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -18,48 +18,74 @@
package
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41503496
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -18,48 +18,74 @@
package
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41504295
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellLocalStartupITCase.scala
---
@@ -0,0 +1,61 @@
+/*
+
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41504243
--- Diff: docs/apis/scala_shell.md ---
@@ -30,15 +30,16 @@ Flink and setting up a cluster please refer to
To use the shell with an integrated Flink
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146560991
@nikste Sorry for bothering you, but there are still some style issues.
Looks good to merge except the issues.
---
If your project is set up for it, you can reply
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41518056
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -67,39 +93,62 @@ object FlinkShell {
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41518604
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala
---
@@ -34,16 +34,16 @@ class FlinkILoop(
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41519871
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,8 +223,50 @@ class
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41519895
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellLocalStartupITCase.scala
---
@@ -0,0 +1,60 @@
+/*
+
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146533038
Okay, if there is no objection and the travis passes, I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41518461
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -18,48 +18,74 @@
package
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41518435
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -18,48 +18,74 @@
package
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146573493
@chiwanpark issues should be fixed NOW ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41525031
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,8 +223,50 @@ class ScalaShellITSuite
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146568015
@chiwanpark issues should be fixed now..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41523437
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellLocalStartupITCase.scala
---
@@ -0,0 +1,60 @@
+/*
+
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41525735
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,8 +223,50 @@ class
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146267428
Hi @nikste, because #1197 is merged first into master, we need rebase this
on master. Could you rebase this?
---
If your project is set up for it, you can reply to
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40898989
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144688685
@tillrohrmann, I changed the code according to your comments. There should
be no null values anymore now ;)
---
If your project is set up for it, you can reply to this
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r4088
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40890167
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40890119
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40890492
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40892847
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40892778
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40892740
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40892899
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40893325
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,6 +220,51 @@ class
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144667856
I had some more comments mostly concerning Scala style and one concerning
the setup of the `LocalFlinkMiniCluster` which will currently only be started
with a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40889842
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40890027
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40890515
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40893139
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,6 +220,51 @@ class
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40893417
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,6 +220,51 @@ class
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40893947
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144345845
@chiwanpark can you check again ? It seems that if I squash both commits
the history isn't shown anymore.
If they are separated
~~~bash
git log
GitHub user nikste reopened a pull request:
https://github.com/apache/flink/pull/1106
[FLINK-2613] Print usage information for Scala Shell
changed startup of scala shell
You can merge this pull request into a Git repository by running:
$ git pull
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144337406
@chiwanpark I moved the files with git mv, however they still don't show
the history.
This seems to be more of a gui thing of github according to:
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144339801
@sachingoel0101 just did and I've merged the two commits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144347584
@chiwanpark this should get fixed after your #1197 gets in first and this
is rebased on that.
---
If your project is set up for it, you can reply to this email
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144338050
Hey @nikste , you should rebase this to the current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144341545
But It seems that there is still same problem.
![screen shot 2015-09-30 at 11 43 59
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144347730
Okay, I checked that the logs are shown. The problem is resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40801479
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,6 +220,52 @@ class
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40801674
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,6 +220,52 @@ class
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40801356
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40801467
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -212,6 +214,52 @@ class
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40802535
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,6 +220,52 @@ class
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40801655
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,6 +220,52 @@ class
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40802725
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,6 +220,52 @@ class
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40801825
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,6 +220,52 @@ class
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144432852
I just reviewed this PR and have a question. What is difference between
`ScalaShellLocalStartupITCase` and `ScalaShellITSuite`? Does we need another
integration
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40811385
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,6 +220,51 @@ class
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144456895
@chiwanpark changed fail to give some reasons.
This is nicer indeed :+1:
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-17780
@chiwanpark, fixed the style issues.
`ScalaShellLocalStartupITCase` starts the shell in local mode (i.e. it will
create its own local cluster ) being invoked by the
Github user nikste closed the pull request at:
https://github.com/apache/flink/pull/1106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-141910091
@fhueske, good point to check if the program was actually executed!
@rmetzger fixed the directory structure as well.
---
If your project is set up for it, you can reply
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-141401714
@nikste, since you need to change the pull request again, can you also fix
the directory name of the classes
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-141066672
Should be fixed according to your comments @fhueske
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r39763329
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -212,6 +212,49 @@ class ScalaShellITSuite
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r39763373
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellLocalStartupITCase.scala
---
@@ -0,0 +1,58 @@
+/*
+ *
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-141131210
Thanks for the update @nikste! I have only one minor thing to add.
After that it's good to merge, IMO.
Thanks!
---
If your project is set up for it, you can
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r39654142
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -212,6 +214,52 @@ class ScalaShellITSuite
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r39654250
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -212,6 +214,52 @@ class ScalaShellITSuite
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r39653423
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellLocalStartupIT.scala
---
@@ -0,0 +1,60 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r39652554
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellLocalStartupIT.scala
---
@@ -0,0 +1,60 @@
+/*
+ *
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-140239647
The tests use the shell scripts (`.sh` or `.bat`) to start the Scala Shell
and rely on finding these scripts in the `flink-dist/target` folder. I think
this is a bit
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-138863295
Looks good. Is it possible that we cover both cases with tests?
1. Start the shell in local mode, submit some commands.
2. Start a
GitHub user nikste opened a pull request:
https://github.com/apache/flink/pull/1106
[FLINK-2613] Print usage information for Scala Shell
changed startup of scala shell
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikste/flink
85 matches
Mail list logo
