Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39725082
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/IntegerTypeInfo.java
---
@@ -18,15 +18,33 @@
package
Github user rxin commented on the pull request:
https://github.com/apache/flink/pull/1134#issuecomment-141163582
I understand you took the bot from Spark, but can you change the JIRA link?
It is spamming the Spark JIRA right now.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1134#issuecomment-141167625
Hey @rxin, I'm really sorry that this happened. Max told me that he stopped
the application on AppEngine as soon as he learned that the tool is not working
as
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1134#issuecomment-141231467
Hi @rxin, I'm really sorry for bothering. I was trying out the Spark Pull
Request Dashboard with all the settings adapted to the Flink JIRA and Flink
Github repository.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1134#issuecomment-140663091
Big change, but I didn't spot anything suspicious.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39612554
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/NumericTypeInfo.java
---
@@ -18,16 +18,36 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39625961
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/PojoField.java ---
@@ -68,4 +72,24 @@ private void readObject(ObjectInputStream in)
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39630227
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/OptionSerializer.scala
---
@@ -20,6 +20,8 @@ package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39630864
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RenamingProxyTypeInfo.scala
---
@@ -31,7 +32,8 @@ import
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39632768
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/NumericTypeInfo.java
---
@@ -18,16 +18,36 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39629488
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/ValueTypeInfoTest.java
---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39633196
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/PojoField.java ---
@@ -68,4 +72,24 @@ private void readObject(ObjectInputStream
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1134#issuecomment-140748369
Very good refactoring! I had just a few inline comments.
Thanks for this effort!
---
If your project is set up for it, you can reply to this email and have your
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1134#issuecomment-140756486
Thanks for reviewing @fhueske and @rmetzger. I addressed the comments and
updated the PR.
---
If your project is set up for it, you can reply to this email and
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39634911
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RenamingProxyTypeInfo.scala
---
@@ -31,7 +32,8 @@ import
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39634744
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/OptionSerializer.scala
---
@@ -20,6 +20,8 @@ package
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39634683
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/ValueTypeInfoTest.java
---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1134#issuecomment-140771931
Thanks for the fast update, LGTM.
Will merge this tomorrow unless somebody speaks up.
---
If your project is set up for it, you can reply to this email and have
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39650722
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/IntegerTypeInfo.java
---
@@ -18,15 +18,33 @@
package
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1134
[FLINK-2637] [api-breaking] [scala, types] Adds equals and hashCode method
to TypeInformations and TypeSerializers
Adds abstract `equals`, `hashCode`, `canEqual` and `toString` methods to
20 matches
Mail list logo
