Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1141#issuecomment-143697315
Will merge this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1141#issuecomment-143192190
Looks good to merge and +1 for FLINK-2692
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1141#discussion_r40327817
--- Diff:
flink-staging/flink-language-binding/flink-language-binding-generic/src/main/java/org/apache/flink/languagebinding/api/java/common/PlanBinder.java
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1141#discussion_r40329651
--- Diff:
flink-staging/flink-language-binding/flink-language-binding-generic/src/main/java/org/apache/flink/languagebinding/api/java/common/PlanBinder.java
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1141#issuecomment-142956414
Yes the reason why I introduced the `CommonCSVInputFormat` instead of
unifying it with the `GenericCsvInputFormat` was that we still have the Record
API
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1141#issuecomment-142953065
Looks good to me, feel free to merge.
Minor comment: We now have a `GenericCsvInputFormat` and a
`CommonCSVInputFormat`. Anything preventing us from
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1141
[FLINK-2690] [api-breaking] [scala api] [java api] Allows CsvInputFormat to
use derived Pojos
This PR adds support for the `CsvInputFormat` to use derived Pojos. In
order to also find pojo
