[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...

2017-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...

2017-06-16 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4133#discussion_r122389818 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -652,6 +653,21 @@ case class

[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...

2017-06-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4133#discussion_r122388804 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -652,6 +653,21 @@ case class

[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...

2017-06-16 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4133#discussion_r122378782 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -652,6 +653,21 @@ case class

[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...

2017-06-16 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4133#discussion_r122378757 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -652,6 +653,21 @@ case class

[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...

2017-06-15 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/4133 [FLINK-6930] [table] Forbid selecting window start/end on row-based Tumble/Slide windows Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check