Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-05-11 Thread via GitHub
1996fanrui commented on PR #24670: URL: https://github.com/apache/flink/pull/24670#issuecomment-2105650755 > @Jiabao-Sun @1996fanrui I will open hotfix to mater. Sorry, I didn't notice it. I start fix it after I received the CI alert.  -- This is an automated message from the

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-05-11 Thread via GitHub
GOODBOY008 commented on PR #24670: URL: https://github.com/apache/flink/pull/24670#issuecomment-2105648555 [workflow_dispatch](https://github.com/apache/flink/actions/runs/9042536161/job/24849180888#step:6:903) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-05-11 Thread via GitHub
GOODBOY008 commented on PR #24670: URL: https://github.com/apache/flink/pull/24670#issuecomment-2105648441 @Jiabao-Sun @1996fanrui I will open hotfix to mater. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-05-11 Thread via GitHub
1996fanrui merged PR #24670: URL: https://github.com/apache/flink/pull/24670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-05-09 Thread via GitHub
1996fanrui commented on code in PR #24670: URL: https://github.com/apache/flink/pull/24670#discussion_r1596162533 ## flink-core/src/test/java/org/apache/flink/util/AbstractIDTest.java: ## @@ -71,16 +67,16 @@ public void testCompare() throws Exception { AbstractID id10

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-05-07 Thread via GitHub
Jiabao-Sun commented on code in PR #24670: URL: https://github.com/apache/flink/pull/24670#discussion_r1593325219 ## flink-core/src/test/java/org/apache/flink/util/SerializedValueTest.java: ## @@ -20,62 +20,57 @@ import org.apache.flink.core.testutils.CommonTestUtils;

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-05-07 Thread via GitHub
Jiabao-Sun commented on code in PR #24670: URL: https://github.com/apache/flink/pull/24670#discussion_r1593260020 ## flink-core/src/test/java/org/apache/flink/util/LinkedOptionalMapTest.java: ## @@ -124,42 +118,50 @@ public void mergingToEmpty() {

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-05-07 Thread via GitHub
Jiabao-Sun commented on code in PR #24670: URL: https://github.com/apache/flink/pull/24670#discussion_r1592131889 ## flink-core/src/test/java/org/apache/flink/util/CloseableIteratorTest.java: ## @@ -17,48 +17,48 @@ package org.apache.flink.util; -import org.junit.Test;

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-04-16 Thread via GitHub
flinkbot commented on PR #24670: URL: https://github.com/apache/flink/pull/24670#issuecomment-2058604771 ## CI report: * aae449392b8ce075a2413679ed2a0c42eaa52c68 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-04-16 Thread via GitHub
GOODBOY008 commented on PR #24670: URL: https://github.com/apache/flink/pull/24670#issuecomment-2058579166 @Jiabao-Sun @1996fanrui PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the