Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

xuyangzhong commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-2062858561 Thanks very much for the bp @snuyanzin  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

snuyanzin merged PR #24280: URL: https://github.com/apache/flink/pull/24280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

snuyanzin commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-2034173734 that is also ok to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

xuyangzhong commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-2026444168 @snuyanzin Sure. I will create PRs to back port to 1.19 and 1.18 and comment the links here after this pr is merged. WDYT? -- This is an automated message from the Apache Git

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

snuyanzin commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-2025314263 @xuyangzhong thanks for the update it looks good from my side I put a couple of minor comments Could you also please create backports for other branches? -- This is an

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

snuyanzin commented on code in PR #24280: URL: https://github.com/apache/flink/pull/24280#discussion_r1543058071 ## flink-end-to-end-tests/flink-sql-client-test/src/main/java/org/apache/flink/table/toolbox/TestScanTableSourceWithWatermarkPushDown.java: ## @@ -0,0 +1,67 @@ +/* +

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

snuyanzin commented on code in PR #24280: URL: https://github.com/apache/flink/pull/24280#discussion_r1543065577 ## flink-end-to-end-tests/flink-sql-client-test/src/main/java/org/apache/flink/table/toolbox/TestScanTableSourceWithWatermarkPushDown.java: ## @@ -0,0 +1,67 @@ +/* +

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

snuyanzin commented on code in PR #24280: URL: https://github.com/apache/flink/pull/24280#discussion_r1543059276 ## flink-end-to-end-tests/flink-sql-client-test/src/main/java/org/apache/flink/table/toolbox/TestScanTableSourceWithWatermarkPushDownFactory.java: ## @@ -0,0 +1,53

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

snuyanzin commented on code in PR #24280: URL: https://github.com/apache/flink/pull/24280#discussion_r1543058071 ## flink-end-to-end-tests/flink-sql-client-test/src/main/java/org/apache/flink/table/toolbox/TestScanTableSourceWithWatermarkPushDown.java: ## @@ -0,0 +1,67 @@ +/* +

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

xuyangzhong commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-2017861678 Hi, @snuyanzin . I have added the test in `flink-end-to-end-tests`. I would appreciate it if you have time to review it. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

xuyangzhong commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-2008542204 > This is a pr we would like merged. It looks like @snuyanzin asked for tests to be added. @xuyangzhong are you looking at adding the tests? Hi, @davidradl . I'm attempting to

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

davidradl commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-2006990240 This is a pr we would like merged. It looks like @snuyanzin asked for tests to be added. @xuyangzhong are you looking at adding the tests? -- This is an automated message from the

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

seb-pereira commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-1936306609 I have tested this change on 1.18.0 in same conditions as reported in

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

xuyangzhong commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-1933276374 Hi, @snuyanzin I think regular IT tests and UT tests cannot help. If some tests must be added, I guess it can be added to the `flink-stream-sql-test` module in the

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

snuyanzin commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-1931481759 Is there a chance to add a test/ITest for this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

flinkbot commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-1931461621 ## CI report: * f065a4c0a11e1b34f8a3f17eb0c4b4b883a97627 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`