Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-24 Thread via GitHub
1996fanrui merged PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-21 Thread via GitHub
RocMarshal commented on PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#issuecomment-2068437230 hi, @Jiabao-Sun master, Could you help to have a review if you had the free time ? Thank you~  -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-19 Thread via GitHub
RocMarshal commented on code in PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1572398050 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java: ## @@ -90,13 +98,31 @@ public

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-19 Thread via GitHub
RocMarshal commented on code in PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1572398050 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java: ## @@ -90,13 +98,31 @@ public

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-19 Thread via GitHub
eskabetxe commented on code in PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1572162247 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java: ## @@ -90,13 +98,31 @@ public

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-19 Thread via GitHub
eskabetxe commented on code in PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1572162247 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java: ## @@ -90,13 +98,31 @@ public

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-19 Thread via GitHub
RocMarshal commented on code in PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1572083767 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java: ## @@ -90,13 +98,31 @@ public

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-19 Thread via GitHub
RocMarshal commented on code in PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1572083767 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java: ## @@ -90,13 +98,31 @@ public

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-19 Thread via GitHub
eskabetxe commented on code in PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1572010803 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java: ## @@ -90,13 +98,31 @@ public

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-18 Thread via GitHub
RocMarshal commented on code in PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1571809638 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java: ## @@ -90,6 +101,11 @@ public

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-18 Thread via GitHub
eskabetxe commented on code in PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1571058904 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java: ## @@ -90,6 +101,11 @@ public

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-18 Thread via GitHub
RocMarshal commented on PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#issuecomment-2063308586 hi, @snuyanzin @eskabetxe Could you help to have a review if you had the free time ? Thank you~ -- This is an automated message from the Apache Git Service. To

[PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-17 Thread via GitHub
RocMarshal opened a new pull request, #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115 - Support property authentication connection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to