fredia merged PR #24657:
URL: https://github.com/apache/flink/pull/24657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Zakelly commented on PR #24657:
URL: https://github.com/apache/flink/pull/24657#issuecomment-2060481241
Thanks @fredia and @yunfengzhou-hub for your detailed review! Really
appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1568151628
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AsyncStateProcessing.java:
##
@@ -34,19 +34,6 @@ public interface
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1568147623
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AsyncStateProcessingOperator.java:
##
@@ -0,0 +1,54 @@
+/*
+ *
yunfengzhou-hub commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1567131634
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AsyncStateProcessingOperator.java:
##
@@ -0,0 +1,54 @@
+/*
+
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1567158767
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/StateRequestBuffer.java:
##
@@ -59,6 +60,9 @@ public StateRequestBuffer() {
}
void
fredia commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1567096409
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/StateRequestBuffer.java:
##
@@ -59,6 +60,9 @@ public StateRequestBuffer() {
}
void
fredia commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1567004818
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordProcessorUtils.java:
##
@@ -82,6 +87,10 @@ public static ThrowingConsumer,
fredia commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1566767092
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/input/FirstInputOfTwoInput.java:
##
@@ -54,4 +57,17 @@ public
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1566670603
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordProcessorUtils.java:
##
@@ -82,6 +87,10 @@ public static ThrowingConsumer,
fredia commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r155895
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordProcessorUtils.java:
##
@@ -82,6 +87,10 @@ public static ThrowingConsumer,
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r154885
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/input/FirstInputOfTwoInput.java:
##
@@ -54,4 +57,17 @@ public
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r153205
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java:
##
@@ -0,0 +1,140 @@
+/*
+ *
fredia commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1566645709
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/input/FirstInputOfTwoInput.java:
##
@@ -54,4 +57,17 @@ public
Zakelly commented on PR #24657:
URL: https://github.com/apache/flink/pull/24657#issuecomment-2056794596
@fredia @yunfengzhou-hub Thanks a lot for your review. I have made another
PR to introduce the element order of processElement as FLIP-425 said. This is
strictly internal and not
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1565751676
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordProcessorUtils.java:
##
@@ -82,6 +87,10 @@ public static ThrowingConsumer,
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1565750669
##
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperatorTest.java:
##
@@ -0,0 +1,98 @@
+/*
+
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1565716029
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java:
##
@@ -0,0 +1,134 @@
+/*
+ *
fredia commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1565516972
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java:
##
@@ -0,0 +1,134 @@
+/*
+ *
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1565225216
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordProcessorUtils.java:
##
@@ -82,6 +87,10 @@ public static ThrowingConsumer,
fredia commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1565180422
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordProcessorUtils.java:
##
@@ -82,6 +87,10 @@ public static ThrowingConsumer,
fredia commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1565216681
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractInput.java:
##
@@ -35,7 +38,8 @@
* AbstractStreamOperatorV2}.
*/
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1563660363
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java:
##
@@ -0,0 +1,127 @@
+/*
+ *
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1563660215
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##
@@ -51,26 +51,43 @@ public class AsyncExecutionController {
Zakelly commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1563659916
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java:
##
@@ -0,0 +1,127 @@
+/*
+ *
yunfengzhou-hub commented on code in PR #24657:
URL: https://github.com/apache/flink/pull/24657#discussion_r1563570370
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##
@@ -51,26 +51,43 @@ public class
flinkbot commented on PR #24657:
URL: https://github.com/apache/flink/pull/24657#issuecomment-2051847830
## CI report:
* 19779deb56730b3da7d0b9ba0898e42786a316ea UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Zakelly opened a new pull request, #24657:
URL: https://github.com/apache/flink/pull/24657
## What is the purpose of the change
As part of the async execution model of disaggregated state management,
this PR gives the basic definition of `StreamingOperator` integrated with async
28 matches
Mail list logo
