[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071149#comment-16071149 ] ASF GitHub Bot commented on FLINK-5488: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062926#comment-16062926 ] ASF GitHub Bot commented on FLINK-5488: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058798#comment-16058798 ] ASF GitHub Bot commented on FLINK-5488: --- Github user zjureel commented on a diff in the pull

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053877#comment-16053877 ] ASF GitHub Bot commented on FLINK-5488: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053878#comment-16053878 ] ASF GitHub Bot commented on FLINK-5488: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041664#comment-16041664 ] Ted Yu commented on FLINK-5488: --- Please also fix the following in deployInternal(): {code}

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034117#comment-16034117 ] ASF GitHub Bot commented on FLINK-5488: --- Github user zjureel commented on a diff in the pull

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031769#comment-16031769 ] ASF GitHub Bot commented on FLINK-5488: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030647#comment-16030647 ] ASF GitHub Bot commented on FLINK-5488: --- Github user fanyon closed the pull request at:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030645#comment-16030645 ] ASF GitHub Bot commented on FLINK-5488: --- Github user zjureel commented on the issue:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030643#comment-16030643 ] ASF GitHub Bot commented on FLINK-5488: --- GitHub user zjureel opened a pull request:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022401#comment-16022401 ] ASF GitHub Bot commented on FLINK-5488: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005742#comment-16005742 ] Ted Yu commented on FLINK-5488: --- I agree. > yarnClient should be closed in AbstractYarnClusterDescriptor

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994229#comment-15994229 ] ASF GitHub Bot commented on FLINK-5488: --- Github user fanyon commented on the issue:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992944#comment-15992944 ] ASF GitHub Bot commented on FLINK-5488: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992633#comment-15992633 ] ASF GitHub Bot commented on FLINK-5488: --- GitHub user fanyon opened a pull request:

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992576#comment-15992576 ] Fang Yong commented on FLINK-5488: -- It's good to release resources before exception is thown, I'd create

[jira] [Commented] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991152#comment-15991152 ] Ted Yu commented on FLINK-5488: --- Here is another example from AbstractYarnClusterDescriptor#retrieve() :