[jira] [Commented] (FLINK-6602) Table source with defined time attributes allows empty string

2017-06-16 Thread Zhe Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052025#comment-16052025 ] Zhe Li commented on FLINK-6602: --- It's my pleasure:) I have opened a pull request just now. Thank you. >

[jira] [Commented] (FLINK-6602) Table source with defined time attributes allows empty string

2017-06-15 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050224#comment-16050224 ] Fabian Hueske commented on FLINK-6602: -- The fix looks good! Please open a pull request with that :-)

[jira] [Commented] (FLINK-6602) Table source with defined time attributes allows empty string

2017-06-15 Thread Zhe Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050038#comment-16050038 ] Zhe Li commented on FLINK-6602: --- Fabian, I understand what you mean. So I modified the codes in

[jira] [Commented] (FLINK-6602) Table source with defined time attributes allows empty string

2017-06-14 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048857#comment-16048857 ] Fabian Hueske commented on FLINK-6602: -- Hi [~lmalds], yes, we need to fix this issue in

[jira] [Commented] (FLINK-6602) Table source with defined time attributes allows empty string

2017-06-12 Thread Zhe Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046298#comment-16046298 ] Zhe Li commented on FLINK-6602: --- Timo & Fabian, I have 2 problems to confirm. (1) I think this problem

[jira] [Commented] (FLINK-6602) Table source with defined time attributes allows empty string

2017-06-06 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038991#comment-16038991 ] Fabian Hueske commented on FLINK-6602: -- I think we should allow {{null}} to indicate that no time

[jira] [Commented] (FLINK-6602) Table source with defined time attributes allows empty string

2017-06-06 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038973#comment-16038973 ] Timo Walther commented on FLINK-6602: - Yes, I would also check for null and change the message to "The

[jira] [Commented] (FLINK-6602) Table source with defined time attributes allows empty string

2017-06-05 Thread Zhe Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036675#comment-16036675 ] Zhe Li commented on FLINK-6602: --- Checking the rowtime and proctime are not allowed empty string in