[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628249#comment-16628249 ] stack commented on HBASE-20734: --- [~reidchan] Needs a release note with how to configure new facility. You

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628245#comment-16628245 ] stack commented on HBASE-19121: --- bq. A reminder, this way will break the `Fix Version/s` tag in JIRA IMO,

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-09-25 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628243#comment-16628243 ] Reid Chan commented on HBASE-19121: --- bq. Branching 2.2 from 2.1 might be the 'safest'. A reminder,

[jira] [Updated] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-09-25 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-20734: -- Fix Version/s: 1.4.8 2.2.0 1.5.0 > Colocate recovered edits

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-09-25 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628236#comment-16628236 ] Reid Chan commented on HBASE-20734: --- Pushed to master, branch-2, branch-1 and branch-1.4. ping

[jira] [Commented] (HBASE-21232) Show table state in Tables view on Master home page

2018-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628230#comment-16628230 ] Hadoop QA commented on HBASE-21232: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Comment Edited] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-09-25 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628222#comment-16628222 ] Reid Chan edited comment on HBASE-20734 at 9/26/18 3:47 AM: Conflicts in

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-09-25 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628222#comment-16628222 ] Reid Chan commented on HBASE-20734: --- Conflicts in branch-2, {code} <<< HEAD 51 *

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-09-25 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628219#comment-16628219 ] Allan Yang commented on HBASE-19121: {quote} A possible way to deal with this problem is that, we

[jira] [Commented] (HBASE-21217) Revisit the executeProcedure method for open/close region

2018-09-25 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628205#comment-16628205 ] Allan Yang commented on HBASE-21217: {quote} Ping Allan Yang, mind opening the issue to upload your

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628200#comment-16628200 ] stack commented on HBASE-19121: --- hbck2 for all branches is tough given we then add a new HbckService on a

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-09-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628181#comment-16628181 ] Duo Zhang commented on HBASE-19121: --- I think we should have hbck2 for all branches? IIRC on another

[jira] [Commented] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628163#comment-16628163 ] Duo Zhang commented on HBASE-21228: --- IIRC ThreadLocal has a initialValue method to create the first

[jira] [Commented] (HBASE-21217) Revisit the executeProcedure method for open/close region

2018-09-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628157#comment-16628157 ] Duo Zhang commented on HBASE-21217: --- Ping [~allan163], mind opening the issue to upload your patch for

[jira] [Commented] (HBASE-21227) Implement exponential retrying backoff for Assign/UnassignRegionHandler introduced in HBASE-21217

2018-09-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628160#comment-16628160 ] Duo Zhang commented on HBASE-21227: --- Let me check RetryCounter. Thanks. > Implement exponential

[jira] [Assigned] (HBASE-21230) BackupUtils#checkTargetDir doesn't compose error message correctly

2018-09-25 Thread liubangchen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen reassigned HBASE-21230: --- Assignee: liubangchen > BackupUtils#checkTargetDir doesn't compose error message correctly

[jira] [Updated] (HBASE-21232) Show table state in Tables view on Master home page

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21232: -- Release Note: Add table state column to the tables panel Status: Patch Available (was: Open) Small

[jira] [Updated] (HBASE-21232) Show table state in Tables view on Master home page

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21232: -- Attachment: HBASE-21232.branch-2.1.001.patch > Show table state in Tables view on Master home page >

[jira] [Commented] (HBASE-21232) Show table state in Tables view on Master home page

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628103#comment-16628103 ] stack commented on HBASE-21232: --- Above is a picture of what it looks like. > Show table state in Tables

[jira] [Updated] (HBASE-21232) Show table state in Tables view on Master home page

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21232: -- Attachment: table.pdf > Show table state in Tables view on Master home page >

[jira] [Created] (HBASE-21232) Show table state in Tables view on Master home page

2018-09-25 Thread stack (JIRA)
stack created HBASE-21232: - Summary: Show table state in Tables view on Master home page Key: HBASE-21232 URL: https://issues.apache.org/jira/browse/HBASE-21232 Project: HBase Issue Type: Bug

[jira] [Commented] (HBASE-21164) reportForDuty to spew less log if master is initializing

2018-09-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628070#comment-16628070 ] Hudson commented on HBASE-21164: Results for branch branch-2 [build #1301 on

[jira] [Commented] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628069#comment-16628069 ] Hudson commented on HBASE-21223: Results for branch branch-2 [build #1301 on

[jira] [Commented] (HBASE-21164) reportForDuty to spew less log if master is initializing

2018-09-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628053#comment-16628053 ] Hudson commented on HBASE-21164: Results for branch branch-2.1 [build #376 on

[jira] [Commented] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628052#comment-16628052 ] Hudson commented on HBASE-21223: Results for branch branch-2.1 [build #376 on

[jira] [Commented] (HBASE-21231) Add documentation for MajorCompactor

2018-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628022#comment-16628022 ] Hadoop QA commented on HBASE-21231: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Updated] (HBASE-21231) Add documentation for MajorCompactor

2018-09-25 Thread Balazs Meszaros (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-21231: Fix Version/s: 3.0.0 > Add documentation for MajorCompactor >

[jira] [Updated] (HBASE-21231) Add documentation for MajorCompactor

2018-09-25 Thread Balazs Meszaros (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-21231: Status: Patch Available (was: Open) > Add documentation for MajorCompactor >

[jira] [Updated] (HBASE-21231) Add documentation for MajorCompactor

2018-09-25 Thread Balazs Meszaros (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-21231: Attachment: HBASE-21231.master.001.patch > Add documentation for MajorCompactor >

[jira] [Created] (HBASE-21231) Add documentation for MajorCompactor

2018-09-25 Thread Balazs Meszaros (JIRA)
Balazs Meszaros created HBASE-21231: --- Summary: Add documentation for MajorCompactor Key: HBASE-21231 URL: https://issues.apache.org/jira/browse/HBASE-21231 Project: HBase Issue Type: Task

[jira] [Created] (HBASE-21230) BackupUtils#checkTargetDir doesn't compose error message correctly

2018-09-25 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21230: -- Summary: BackupUtils#checkTargetDir doesn't compose error message correctly Key: HBASE-21230 URL: https://issues.apache.org/jira/browse/HBASE-21230 Project: HBase

[jira] [Updated] (HBASE-20225) [RPC] Server does not tell clients what version it is

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-20225: -- Summary: [RPC] Server does not tell clients what version it is (was: [RPC] Server does not say what version

[jira] [Updated] (HBASE-20225) [RPC] Server does not say what version it is

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-20225: -- Priority: Critical (was: Major) > [RPC] Server does not say what version it is >

[jira] [Commented] (HBASE-20225) [RPC] Server does not say what version it is

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627857#comment-16627857 ] stack commented on HBASE-20225: --- Back here again. HBCK2 wants to know what version it is going against so

[jira] [Resolved] (HBASE-14707) NPE spew getting metrics via jmx

2018-09-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved HBASE-14707. --- Resolution: Cannot Reproduce Not seen in a while and not enough info to reproduce. The JVM used for

[jira] [Resolved] (HBASE-14950) Create table with AC fails when quota is enabled

2018-09-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved HBASE-14950. --- Resolution: Cannot Reproduce > Create table with AC fails when quota is enabled >

[jira] [Commented] (HBASE-14950) Create table with AC fails when quota is enabled

2018-09-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627841#comment-16627841 ] Mike Drob commented on HBASE-14950: --- I tested this on branch 2.1 and was not able to reproduce this

[jira] [Commented] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627788#comment-16627788 ] Hadoop QA commented on HBASE-21228: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Updated] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21223: -- Fix Version/s: 2.2.0 3.0.0 > [amv2] Remove abort_procedure from shell >

[jira] [Updated] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21223: -- Component/s: shell > [amv2] Remove abort_procedure from shell > > >

[jira] [Updated] (HBASE-21164) reportForDuty to spew less log if master is initializing

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21164: -- Resolution: Fixed Fix Version/s: 2.1.1 2.2.0 3.0.0

[jira] [Updated] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21223: -- Resolution: Fixed Hadoop Flags: Incompatible change,Reviewed Release Note: Removed the

[jira] [Commented] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627742#comment-16627742 ] Xu Cang commented on HBASE-21228: - nit: Remove the line after TODO you've removed. [~allan163]   >

[jira] [Commented] (HBASE-18451) PeriodicMemstoreFlusher should inspect the queue before adding a delayed flush request

2018-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627733#comment-16627733 ] Hadoop QA commented on HBASE-18451: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Updated] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang updated HBASE-21228: Description: In AbstractFSWAL(FSHLog in branch-1), we have a map caches thread and SyncFutures.

[jira] [Commented] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627724#comment-16627724 ] Hadoop QA commented on HBASE-21223: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Updated] (HBASE-14950) Create table with AC fails when quota is enabled

2018-09-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-14950: -- Component/s: proc-v2 > Create table with AC fails when quota is enabled >

[jira] [Commented] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627702#comment-16627702 ] Hadoop QA commented on HBASE-21223: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21217) Revisit the executeProcedure method for open/close region

2018-09-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627665#comment-16627665 ] Hudson commented on HBASE-21217: Results for branch branch-2 [build #1300 on

[jira] [Commented] (HBASE-20993) [Auth] IPC client fallback to simple auth allowed doesn't work

2018-09-25 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627659#comment-16627659 ] Reid Chan commented on HBASE-20993: --- Thanks Sean! > [Auth] IPC client fallback to simple auth allowed

[jira] [Commented] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627655#comment-16627655 ] stack commented on HBASE-21223: --- .002 Addresses [~balazs.meszaros] review. > [amv2] Remove

[jira] [Updated] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21223: -- Attachment: HBASE-21223.branch-2.1.002.patch > [amv2] Remove abort_procedure from shell >

[jira] [Commented] (HBASE-20993) [Auth] IPC client fallback to simple auth allowed doesn't work

2018-09-25 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627639#comment-16627639 ] Sean Busbey commented on HBASE-20993: - filed HBASE-21229. I haven't assigned it to myself yet

[jira] [Commented] (HBASE-21229) Add a nightly check that client-server wire compatibility works

2018-09-25 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627638#comment-16627638 ] Sean Busbey commented on HBASE-21229: - I'd say probably the script that runs the nightly test should

[jira] [Updated] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21223: -- Fix Version/s: 2.1.1 Status: Patch Available (was: Open) > [amv2] Remove abort_procedure from

[jira] [Updated] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21223: -- Attachment: HBASE-21223.branch-2.1.001.patch > [amv2] Remove abort_procedure from shell >

[jira] [Created] (HBASE-21229) Add a nightly check that client-server wire compatibility works

2018-09-25 Thread Sean Busbey (JIRA)
Sean Busbey created HBASE-21229: --- Summary: Add a nightly check that client-server wire compatibility works Key: HBASE-21229 URL: https://issues.apache.org/jira/browse/HBASE-21229 Project: HBase

[jira] [Commented] (HBASE-20993) [Auth] IPC client fallback to simple auth allowed doesn't work

2018-09-25 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627620#comment-16627620 ] Sean Busbey commented on HBASE-20993: - let me get a jira filed so we can move discussion there. the

[jira] [Commented] (HBASE-21227) Implement exponential retrying backoff for Assign/UnassignRegionHandler introduced in HBASE-21217

2018-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627609#comment-16627609 ] Hadoop QA commented on HBASE-21227: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627611#comment-16627611 ] Mike Drob commented on HBASE-21228: --- I was under the impression that initialValue was well known in

[jira] [Commented] (HBASE-21227) Implement exponential retrying backoff for Assign/UnassignRegionHandler introduced in HBASE-21217

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627608#comment-16627608 ] stack commented on HBASE-21227: --- Use RetryCounter utility calculating backoff? Otherwise, LGTM. >

[jira] [Commented] (HBASE-21217) Revisit the executeProcedure method for open/close region

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627591#comment-16627591 ] stack commented on HBASE-21217: --- Is there an issue for reenabling CompatRemoteProcedureResolver in

[jira] [Updated] (HBASE-21221) Ineffective assertion in TestFromClientSide3#testMultiRowMutations

2018-09-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21221: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Commented] (HBASE-21213) [hbck2] bypass leaves behind state in RegionStates when assign/unassign

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627582#comment-16627582 ] stack commented on HBASE-21213: --- Ok [~allan163]. Shout if there is anything that might disrupt your being

[jira] [Commented] (HBASE-21223) [amv2] Remove abort_procedure from shell

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627581#comment-16627581 ] stack commented on HBASE-21223: --- Looks like most procedures just ignore this call anyways... 2018-09-25

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-09-25 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627578#comment-16627578 ] Reid Chan commented on HBASE-20734: --- Will commit it late this day if no other comments. > Colocate

[jira] [Commented] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627575#comment-16627575 ] Allan Yang commented on HBASE-21228: {quote} If we override initialValue method on the ThreadLocal,

[jira] [Commented] (HBASE-21213) [hbck2] bypass leaves behind state in RegionStates when assign/unassign

2018-09-25 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627566#comment-16627566 ] Allan Yang commented on HBASE-21213: I want HBCK2 to work on branch-2.0. Maybe we can focus on

[jira] [Commented] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627558#comment-16627558 ] Mike Drob commented on HBASE-21228: --- If we override {{initialValue}} method on the ThreadLocal, then

[jira] [Commented] (HBASE-18451) PeriodicMemstoreFlusher should inspect the queue before adding a delayed flush request

2018-09-25 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627555#comment-16627555 ] Xu Cang commented on HBASE-18451: - Fixed code style for the master branch. re-uploaded branch-1 patch

[jira] [Commented] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627554#comment-16627554 ] Ted Yu commented on HBASE-21228: +1, pending QA > Memory leak since AbstractFSWAL caches Thread object

[jira] [Updated] (HBASE-18451) PeriodicMemstoreFlusher should inspect the queue before adding a delayed flush request

2018-09-25 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang updated HBASE-18451: Attachment: HBASE-18451.branch-1.002.patch > PeriodicMemstoreFlusher should inspect the queue before

[jira] [Updated] (HBASE-18451) PeriodicMemstoreFlusher should inspect the queue before adding a delayed flush request

2018-09-25 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang updated HBASE-18451: Attachment: HBASE-18451.master.004.patch > PeriodicMemstoreFlusher should inspect the queue before adding

[jira] [Commented] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627553#comment-16627553 ] Allan Yang commented on HBASE-21228: {quote} You're suggesting to replace the map with ThreadLocal?

[jira] [Updated] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allan Yang updated HBASE-21228: --- Status: Patch Available (was: Open) > Memory leak since AbstractFSWAL caches Thread object and

[jira] [Updated] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allan Yang updated HBASE-21228: --- Attachment: HBASE-21228.branch-2.0.001.patch > Memory leak since AbstractFSWAL caches Thread object

[jira] [Commented] (HBASE-20952) Re-visit the WAL API

2018-09-25 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627549#comment-16627549 ] Josh Elser commented on HBASE-20952: [~reidchan], [~zyork], also, FYI if you'd like to see the

[jira] [Commented] (HBASE-20952) Re-visit the WAL API

2018-09-25 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627546#comment-16627546 ] Josh Elser commented on HBASE-20952: [~stack], [~Apache9], ping, just in case this got lost over the

[jira] [Commented] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627533#comment-16627533 ] Mike Drob commented on HBASE-21228: --- You're suggesting to replace the map with {{ThreadLocal}}? Yea,

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627531#comment-16627531 ] stack commented on HBASE-19121: --- Ok. Let me let this stew a bit to see what fellows from China have to say

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627528#comment-16627528 ] stack commented on HBASE-19121: --- Thanks [~elserj] for input. HBASE-20881 adds new Procedure type.

[jira] [Updated] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allan Yang updated HBASE-21228: --- Description: In AbstractFSWAL(FSHLog in branch-1), we have a map caches thread and SyncFutures.

[jira] [Commented] (HBASE-18451) PeriodicMemstoreFlusher should inspect the queue before adding a delayed flush request

2018-09-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627523#comment-16627523 ] Mike Drob commented on HBASE-18451: --- +1 after checkstyle fixed > PeriodicMemstoreFlusher should

[jira] [Created] (HBASE-21228) Memory leak since AbstractFSWAL caches Thread object and never clean later

2018-09-25 Thread Allan Yang (JIRA)
Allan Yang created HBASE-21228: -- Summary: Memory leak since AbstractFSWAL caches Thread object and never clean later Key: HBASE-21228 URL: https://issues.apache.org/jira/browse/HBASE-21228 Project:

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-09-25 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627513#comment-16627513 ] Josh Elser commented on HBASE-19121: {quote}Or crazy-pants stuff like cutting branch-2.2 from

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627473#comment-16627473 ] stack commented on HBASE-19121: --- Or crazy-pants stuff like cutting branch-2.2 from branch-2.1? > HBCK for

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-09-25 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627457#comment-16627457 ] Josh Elser commented on HBASE-19121: {quote}hbck2 is showing up on a point release – 2.1.1 – rather

[jira] [Commented] (HBASE-19121) HBCK for AMv2 (A.K.A HBCK2)

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627438#comment-16627438 ] stack commented on HBASE-19121: --- TODO: hbck2 is showing up on a point release -- 2.1.1 -- rather than on a

[jira] [Commented] (HBASE-21213) [hbck2] bypass leaves behind state in RegionStates when assign/unassign

2018-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627437#comment-16627437 ] stack commented on HBASE-21213: --- [~allan163] Thanks for bringing this up. I suppose we need to declare

[jira] [Updated] (HBASE-21227) Implement exponential retrying backoff for Assign/UnassignRegionHandler introduced in HBASE-21217

2018-09-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21227: -- Attachment: HBASE-21227.patch > Implement exponential retrying backoff for

[jira] [Updated] (HBASE-21227) Implement exponential retrying backoff for Assign/UnassignRegionHandler introduced in HBASE-21217

2018-09-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21227: -- Assignee: Duo Zhang Status: Patch Available (was: Open) > Implement exponential retrying

[jira] [Commented] (HBASE-21208) Bytes#toShort doesn't work without unsafe

2018-09-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627281#comment-16627281 ] Hudson commented on HBASE-21208: Results for branch master [build #509 on

[jira] [Created] (HBASE-21227) Implement exponential retrying backoff for Assign/UnassignRegionHandler introduced in HBASE-21217

2018-09-25 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-21227: - Summary: Implement exponential retrying backoff for Assign/UnassignRegionHandler introduced in HBASE-21217 Key: HBASE-21227 URL: https://issues.apache.org/jira/browse/HBASE-21227

[jira] [Created] (HBASE-21226) Revisit the close region related code at RS side

2018-09-25 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-21226: - Summary: Revisit the close region related code at RS side Key: HBASE-21226 URL: https://issues.apache.org/jira/browse/HBASE-21226 Project: HBase Issue Type:

[jira] [Commented] (HBASE-21217) Revisit the executeProcedure method for open/close region

2018-09-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627269#comment-16627269 ] Duo Zhang commented on HBASE-21217: --- Yes, when calling closeRegion we could throw a

[jira] [Commented] (HBASE-21208) Bytes#toShort doesn't work without unsafe

2018-09-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627198#comment-16627198 ] Hudson commented on HBASE-21208: Results for branch branch-2 [build #1298 on

[jira] [Commented] (HBASE-21208) Bytes#toShort doesn't work without unsafe

2018-09-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627174#comment-16627174 ] Hudson commented on HBASE-21208: Results for branch branch-2.0 [build #861 on

[jira] [Commented] (HBASE-21217) Revisit the executeProcedure method for open/close region

2018-09-25 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627167#comment-16627167 ] Allan Yang commented on HBASE-21217: {quote} There is no FAILED_CLOSE state so we can not tell

[jira] [Commented] (HBASE-18451) PeriodicMemstoreFlusher should inspect the queue before adding a delayed flush request

2018-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627130#comment-16627130 ] Hadoop QA commented on HBASE-18451: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Updated] (HBASE-21217) Revisit the executeProcedure method for open/close region

2018-09-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21217: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available)

  1   2   >