[GitHub] [hbase] Apache-HBase commented on pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1588: URL: https://github.com/apache/hbase/pull/1588#issuecomment-620395121 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620387346 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m

[jira] [Updated] (HBASE-24210) Add Increment, Append and CheckAndMutate support to RowMutations

2020-04-27 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-24210: - Fix Version/s: 2.4.0 3.0.0 > Add Increment, Append and

[GitHub] [hbase] bsglz commented on pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-27 Thread GitBox
bsglz commented on pull request #767: URL: https://github.com/apache/hbase/pull/767#issuecomment-620375260 > IIRC this has been discussed several times in the past, that whether we should suppor filtering when using raw scan. > > The problem here is that, for a raw scan, the delete

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-620373072 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1597: URL: https://github.com/apache/hbase/pull/1597#issuecomment-620371629 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1588: URL: https://github.com/apache/hbase/pull/1588#issuecomment-620368853 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz commented on pull request #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-04-27 Thread GitBox
bsglz commented on pull request #767: URL: https://github.com/apache/hbase/pull/767#issuecomment-620366012 Thanks very much to all of the reviewers. This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094129#comment-17094129 ] Michael Stack commented on HBASE-24273: --- [~huaxiangsun] when hbck_chore runs and we come across a

[GitHub] [hbase] Apache-HBase commented on pull request #1500: HBASE-24164 Retain the ReadRequests and WriteRequests of region on we…

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1500: URL: https://github.com/apache/hbase/pull/1500#issuecomment-620362463 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[jira] [Commented] (HBASE-24250) CatalogJanitor resubmits GCMultipleMergedRegionsProcedure for the same region

2020-04-27 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094125#comment-17094125 ] niuyulin commented on HBASE-24250: -- “and then something when wrong and caused a different procedure to

[GitHub] [hbase] Apache-HBase commented on pull request #1500: HBASE-24164 Retain the ReadRequests and WriteRequests of region on we…

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1500: URL: https://github.com/apache/hbase/pull/1500#issuecomment-620360694 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1500: HBASE-24164 Retain the ReadRequests and WriteRequests of region on we…

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1500: URL: https://github.com/apache/hbase/pull/1500#issuecomment-620359219 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on a change in pull request #1500: HBASE-24164 Retain the ReadRequests and WriteRequests of region on we…

2020-04-27 Thread GitBox
bsglz commented on a change in pull request #1500: URL: https://github.com/apache/hbase/pull/1500#discussion_r416293843 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java ## @@ -67,6 +70,7 @@ public

[jira] [Updated] (HBASE-24266) Document of Hbase on Aarch64

2020-04-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24266: -- Fix Version/s: 3.0.0 > Document of Hbase on Aarch64 > > >

[jira] [Updated] (HBASE-24266) Document of Hbase on Aarch64

2020-04-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24266: -- Component/s: documentation > Document of Hbase on Aarch64 > > >

[GitHub] [hbase] Apache-HBase commented on pull request #1591: HBASE-24267 add limit support for scan in rest api

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1591: URL: https://github.com/apache/hbase/pull/1591#issuecomment-620355532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m

[GitHub] [hbase] Apache-HBase commented on pull request #1591: HBASE-24267 add limit support for scan in rest api

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1591: URL: https://github.com/apache/hbase/pull/1591#issuecomment-620354442 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1597: URL: https://github.com/apache/hbase/pull/1597#issuecomment-620354273 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m

[GitHub] [hbase] bsglz commented on a change in pull request #1500: HBASE-24164 Retain the ReadRequests and WriteRequests of region on we…

2020-04-27 Thread GitBox
bsglz commented on a change in pull request #1500: URL: https://github.com/apache/hbase/pull/1500#discussion_r416293843 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java ## @@ -67,6 +70,7 @@ public

[jira] [Commented] (HBASE-24272) Backport "Implement proxyuser/doAs mechanism for hbase-http" to 2.1.x

2020-04-27 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094109#comment-17094109 ] Istvan Toth commented on HBASE-24272: - Sure, I'll look into it. > Backport "Implement

[GitHub] [hbase] Apache-HBase commented on pull request #1591: HBASE-24267 add limit support for scan in rest api

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1591: URL: https://github.com/apache/hbase/pull/1591#issuecomment-620351233 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-620349786 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #1598: HBASE-24266 Add document of hbase building on aarch64

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1598: URL: https://github.com/apache/hbase/pull/1598#issuecomment-620348278 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Assigned] (HBASE-24266) Document of Hbase on Aarch64

2020-04-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24266: - Assignee: huangtianhua > Document of Hbase on Aarch64 > > >

[GitHub] [hbase] bsglz commented on a change in pull request #1500: HBASE-24164 Retain the ReadRequests and WriteRequests of region on we…

2020-04-27 Thread GitBox
bsglz commented on a change in pull request #1500: URL: https://github.com/apache/hbase/pull/1500#discussion_r416285959 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java ## @@ -123,6 +127,13 @@ public long

[GitHub] [hbase] bsglz commented on a change in pull request #1500: HBASE-24164 Retain the ReadRequests and WriteRequests of region on we…

2020-04-27 Thread GitBox
bsglz commented on a change in pull request #1500: URL: https://github.com/apache/hbase/pull/1500#discussion_r416284662 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -8964,4 +8977,12 @@ static void

[GitHub] [hbase] Apache-HBase commented on pull request #1598: HBASE-24266 Add document of hbase building on aarch64

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1598: URL: https://github.com/apache/hbase/pull/1598#issuecomment-620342745 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] bsglz commented on a change in pull request #1500: HBASE-24164 Retain the ReadRequests and WriteRequests of region on we…

2020-04-27 Thread GitBox
bsglz commented on a change in pull request #1500: URL: https://github.com/apache/hbase/pull/1500#discussion_r416283728 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -877,6 +877,19 @@ public HRegion(final HRegionFileSystem

[GitHub] [hbase] bsglz commented on a change in pull request #1500: HBASE-24164 Retain the ReadRequests and WriteRequests of region on we…

2020-04-27 Thread GitBox
bsglz commented on a change in pull request #1500: URL: https://github.com/apache/hbase/pull/1500#discussion_r416283728 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -877,6 +877,19 @@ public HRegion(final HRegionFileSystem

[GitHub] [hbase] Apache-HBase commented on pull request #1598: HBASE-24266 Add document of hbase building on aarch64

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1598: URL: https://github.com/apache/hbase/pull/1598#issuecomment-620342234 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] CodingBen commented on pull request #1591: HBASE-24267 add limit support for scan in rest api

2020-04-27 Thread GitBox
CodingBen commented on pull request #1591: URL: https://github.com/apache/hbase/pull/1591#issuecomment-620340814 > LGTM, just a small nit on the numbering of ScannerMessage fields, ain't sure if that's necessary or not. Thanks for pointing out this problem, and it has been updated

[GitHub] [hbase] huangtianhua opened a new pull request #1598: Hbase-24266 Add document of hbase building on aarch64

2020-04-27 Thread GitBox
huangtianhua opened a new pull request #1598: URL: https://github.com/apache/hbase/pull/1598 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HBASE-24143) [JDK11] Switch default garbage collector from CMS

2020-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094094#comment-17094094 ] Hudson commented on HBASE-24143: Results for branch branch-2 [build #2633 on

[jira] [Commented] (HBASE-24264) Disable TestNettyIPC.testHedgedAsyncEcho

2020-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094092#comment-17094092 ] Hudson commented on HBASE-24264: Results for branch branch-2 [build #2633 on

[jira] [Commented] (HBASE-24211) Create table is slow in large cluster when AccessController is enabled.

2020-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094093#comment-17094093 ] Hudson commented on HBASE-24211: Results for branch branch-2 [build #2633 on

[jira] [Commented] (HBASE-24252) Implement proxyuser/doAs mechanism for hbase-http

2020-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094095#comment-17094095 ] Hudson commented on HBASE-24252: Results for branch branch-2 [build #2633 on

[GitHub] [hbase] Apache9 commented on a change in pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
Apache9 commented on a change in pull request #1597: URL: https://github.com/apache/hbase/pull/1597#discussion_r416272099 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java ## @@ -1,4 +1,4 @@ -/* +/** Review comment: Why in the

[GitHub] [hbase] Apache9 commented on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …

2020-04-27 Thread GitBox
Apache9 commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620330907 > Just realized this work was triggered by HBASE-24264. How did you narrow it down to testHedgedAsyncEcho? There is not much detail in the jira/commit. Any jstacks? Curious what

[GitHub] [hbase] Apache9 edited a comment on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …

2020-04-27 Thread GitBox
Apache9 edited a comment on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620328101 > I think hedging RPC support is a standard RPC layer thing (for ex grpc: [1]). We can probably make a case to port region replica to hedging framework in the RPC layer.

[GitHub] [hbase] Apache9 commented on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …

2020-04-27 Thread GitBox
Apache9 commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620329700 I think what we want in 2.3.0 is MasterRegistry, not hedge read rpc right? So my goal is to make sure MasterRegistry available first and then we start the think of the hedge read

[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094079#comment-17094079 ] Huaxiang Sun commented on HBASE-24273: -- [~timoha] Yeah, seems what you said is correct for the

[GitHub] [hbase] Apache9 commented on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …

2020-04-27 Thread GitBox
Apache9 commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620328101 > I think hedging RPC support is a standard RPC layer thing (for ex grpc: [1]). We can probably make a case to port region replica to hedging framework in the RPC layer. Fun

[GitHub] [hbase] Apache9 commented on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …

2020-04-27 Thread GitBox
Apache9 commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620324213 > We use > 5 masters for redundancy in our critical production deployments. If we were to use this, we definitely don't want to spam every master for each of the request. -1 on

[GitHub] [hbase] Apache9 commented on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …

2020-04-27 Thread GitBox
Apache9 commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620323840 > I think >2 masters is a common deployment pattern. Typical ZooKeeper and HDFS HA deploy requires three coordinator hosts minimum, so it makes sense to deploy 3 masters across

[GitHub] [hbase] Apache-HBase commented on pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1597: URL: https://github.com/apache/hbase/pull/1597#issuecomment-620315696 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-620314043 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Andrey Elenskiy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094048#comment-17094048 ] Andrey Elenskiy commented on HBASE-24273: - Hm, interesting that you say that the parent regions

[jira] [Commented] (HBASE-24274) `RESTApiClusterManager` attempts to deserialize response using serialization API

2020-04-27 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094042#comment-17094042 ] Nick Dimiduk commented on HBASE-24274: -- The current stuff gives me this error {noformat} 20/04/27

[jira] [Work started] (HBASE-24274) `RESTApiClusterManager` attempts to deserialize response using serialization API

2020-04-27 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24274 started by Nick Dimiduk. > `RESTApiClusterManager` attempts to deserialize response using serialization

[jira] [Created] (HBASE-24274) `RESTApiClusterManager` attempts to deserialize response using serialization API

2020-04-27 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24274: Summary: `RESTApiClusterManager` attempts to deserialize response using serialization API Key: HBASE-24274 URL: https://issues.apache.org/jira/browse/HBASE-24274

[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094029#comment-17094029 ] Michael Stack commented on HBASE-24273: --- bq. But if master is restarted, in-memory state will be

[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Andrey Elenskiy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094016#comment-17094016 ] Andrey Elenskiy commented on HBASE-24273: - But if master is restarted, in-memory state will be

[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094015#comment-17094015 ] Michael Stack commented on HBASE-24273: --- Please do [~huaxiangsun] > HBCK's "Orphan Regions on

[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094012#comment-17094012 ] Huaxiang Sun commented on HBASE-24273: -- Once hbck_chore runs, it cleans up merged regions (parents)

[GitHub] [hbase] Apache9 commented on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …

2020-04-27 Thread GitBox
Apache9 commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620283327 And if you guys really want to implement the hedge read support, please open a new issue for it, and implement the feature in both rpc client implementations, and make it

[GitHub] [hbase] Apache9 commented on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …

2020-04-27 Thread GitBox
Apache9 commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620278089 Things are different in HBase. HBase is a rich client, you can see the implementation of the roc retrying caller. Typically, in HBase, a rpc retrying will lead to a clearing of

[GitHub] [hbase] ndimiduk commented on pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
ndimiduk commented on pull request #1597: URL: https://github.com/apache/hbase/pull/1597#issuecomment-620268170 > I'm surprised to not see the switch to change `file://` to refer to `RawLocalFileSystem` instead of `LocalFileSystem` here. I assume that means that the system generally works

[GitHub] [hbase] ndimiduk commented on a change in pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
ndimiduk commented on a change in pull request #1597: URL: https://github.com/apache/hbase/pull/1597#discussion_r416190611 ## File path: conf/hbase-site.xml ## @@ -21,4 +20,31 @@ */ --> +

[GitHub] [hbase] joshelser commented on a change in pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
joshelser commented on a change in pull request #1597: URL: https://github.com/apache/hbase/pull/1597#discussion_r416185036 ## File path: conf/hbase-site.xml ## @@ -21,4 +20,31 @@ */ --> +

[GitHub] [hbase] Apache-HBase commented on pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1597: URL: https://github.com/apache/hbase/pull/1597#issuecomment-620260785 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-620259164 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on a change in pull request #1591: HBASE-24267 add limit support for scan in rest api

2020-04-27 Thread GitBox
saintstack commented on a change in pull request #1591: URL: https://github.com/apache/hbase/pull/1591#discussion_r416175767 ## File path: hbase-protocol-shaded/src/main/protobuf/rest/ScannerMessage.proto ## @@ -28,6 +28,7 @@ message Scanner { optional int32 maxVersions =

[GitHub] [hbase] joshelser commented on pull request #1576: HBASE-24252 Implement proxyuser/doAs mechanism for hbase-http

2020-04-27 Thread GitBox
joshelser commented on pull request #1576: URL: https://github.com/apache/hbase/pull/1576#issuecomment-620252594 @ndimiduk that the class you left some reviews on was a verbatim copy from Hadoop. It was taken at face-value. If we want to diverge from that, we can do so.

[GitHub] [hbase] ndimiduk commented on a change in pull request #1576: HBASE-24252 Implement proxyuser/doAs mechanism for hbase-http

2020-04-27 Thread GitBox
ndimiduk commented on a change in pull request #1576: URL: https://github.com/apache/hbase/pull/1576#discussion_r416165979 ## File path: hbase-http/src/main/java/org/apache/hadoop/hbase/http/ProxyUserAuthenticationFilter.java ## @@ -0,0 +1,219 @@ +/* + * Licensed to the

[jira] [Commented] (HBASE-24252) Implement proxyuser/doAs mechanism for hbase-http

2020-04-27 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093950#comment-17093950 ] Josh Elser commented on HBASE-24252: Well, the only anecdotal history I got via an off-hand question

[jira] [Commented] (HBASE-24252) Implement proxyuser/doAs mechanism for hbase-http

2020-04-27 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093943#comment-17093943 ] Nick Dimiduk commented on HBASE-24252: -- I just find it very strange (I won't say "non-standard"

[GitHub] [hbase] ndimiduk commented on a change in pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
ndimiduk commented on a change in pull request #1597: URL: https://github.com/apache/hbase/pull/1597#discussion_r416159617 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java ## @@ -348,19 +350,11 @@ public static void setWALRootDir(final

[GitHub] [hbase] ndimiduk commented on a change in pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
ndimiduk commented on a change in pull request #1597: URL: https://github.com/apache/hbase/pull/1597#discussion_r416159007 ## File path: conf/hbase-site.xml ## @@ -21,4 +20,31 @@ */ --> +

[jira] [Commented] (HBASE-24252) Implement proxyuser/doAs mechanism for hbase-http

2020-04-27 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093940#comment-17093940 ] Josh Elser commented on HBASE-24252: FWIW, it looks like Knox does actually have the ability to use

[GitHub] [hbase] ndimiduk commented on a change in pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
ndimiduk commented on a change in pull request #1597: URL: https://github.com/apache/hbase/pull/1597#discussion_r416158130 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java ## @@ -348,19 +350,11 @@ public static void setWALRootDir(final

[jira] [Commented] (HBASE-24252) Implement proxyuser/doAs mechanism for hbase-http

2020-04-27 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093936#comment-17093936 ] Josh Elser commented on HBASE-24252: Thanks Nick! {quote}After reading the release note, isn't this

[GitHub] [hbase] saintstack commented on a change in pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
saintstack commented on a change in pull request #1597: URL: https://github.com/apache/hbase/pull/1597#discussion_r416154005 ## File path: conf/hbase-site.xml ## @@ -21,4 +20,31 @@ */ --> + + +hbase.tmp.dir +./tmp + + +

[GitHub] [hbase] joshelser commented on a change in pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
joshelser commented on a change in pull request #1597: URL: https://github.com/apache/hbase/pull/1597#discussion_r416151806 ## File path: conf/hbase-site.xml ## @@ -21,4 +20,31 @@ */ --> +

[jira] [Commented] (HBASE-24252) Implement proxyuser/doAs mechanism for hbase-http

2020-04-27 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093932#comment-17093932 ] Nick Dimiduk commented on HBASE-24252: -- +1 for branch-2.3. After reading the release note, isn't

[GitHub] [hbase] saintstack commented on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …

2020-04-27 Thread GitBox
saintstack commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620234076 To be clear, I'm good on disabling a flakey test till it gets love. Doesn't mean I in favor of a purge of this hedging facility.

[GitHub] [hbase] saintstack commented on a change in pull request #1500: HBASE-24164 Retain the ReadRequests and WriteRequests of region on we…

2020-04-27 Thread GitBox
saintstack commented on a change in pull request #1500: URL: https://github.com/apache/hbase/pull/1500#discussion_r416144243 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -877,6 +877,19 @@ public HRegion(final

[jira] [Commented] (HBASE-24189) Regionserver recreates region folders in HDFS after replaying WAL with removed table entries

2020-04-27 Thread Andrey Elenskiy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093922#comment-17093922 ] Andrey Elenskiy commented on HBASE-24189: - Haven't planned on a patch, not exactly certain what

[GitHub] [hbase] ndimiduk commented on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …

2020-04-27 Thread GitBox
ndimiduk commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-620229998 I think >2 masters is a common deployment pattern. Typical ZooKeeper and HDFS HA deploy requires three coordinator hosts minimum, so it makes sense to deploy 3 masters across

[GitHub] [hbase] saintstack commented on a change in pull request #1482: HBASE-24152 Add ServerSsdLocalityCostFunction to StochasticLoadBalancer

2020-04-27 Thread GitBox
saintstack commented on a change in pull request #1482: URL: https://github.com/apache/hbase/pull/1482#discussion_r416139353 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java ## @@ -199,10 +225,23 @@ public long

[GitHub] [hbase] mkazia commented on pull request #1565: HBASE-24235 Wrap creation of NettyHBaseSaslRpcClient with ugi.doAs

2020-04-27 Thread GitBox
mkazia commented on pull request #1565: URL: https://github.com/apache/hbase/pull/1565#issuecomment-620229753 @joshelser Thanks for your continued indulgence in this. So far from IBM I have managed to find this example > The mechanism expects the calling threads Subject to

[GitHub] [hbase] saintstack commented on pull request #801: HBASE-23264 Resolve a TODO of BucketAllocator: "Why we add the extra …

2020-04-27 Thread GitBox
saintstack commented on pull request #801: URL: https://github.com/apache/hbase/pull/801#issuecomment-620225346 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HBASE-24250) CatalogJanitor resubmits GCMultipleMergedRegionsProcedure for the same region

2020-04-27 Thread Andrey Elenskiy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093918#comment-17093918 ] Andrey Elenskiy commented on HBASE-24250: - Yes, GCMultipleMergedRegionsProcedure and 

[GitHub] [hbase] ndimiduk commented on pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
ndimiduk commented on pull request #1597: URL: https://github.com/apache/hbase/pull/1597#issuecomment-620221766 I tried to include everyone who brought opinions to the previous PRs, Jiras, and [dev

[GitHub] [hbase] ndimiduk opened a new pull request #1597: HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box

2020-04-27 Thread GitBox
ndimiduk opened a new pull request #1597: URL: https://github.com/apache/hbase/pull/1597 Simplify the new user experience shipping a configuration that enables a fresh checkout or tarball distribution to run in standalone mode without direct user configuration. This change restores

[jira] [Updated] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Andrey Elenskiy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Elenskiy updated HBASE-24273: Description: This issue came up after merging regions. MergeTableRegionsProcedure removes

[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093904#comment-17093904 ] Michael Stack commented on HBASE-24273: --- Made it critical against 2.3.0 (and for 2.2.5 too I

[jira] [Commented] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093901#comment-17093901 ] Michael Stack commented on HBASE-24273: --- Good find [~timoha]. I can give this a go unless you want

[jira] [Updated] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24273: -- Priority: Critical (was: Major) > HBCK's "Orphan Regions on FileSystem" reports regions with

[jira] [Updated] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24273: -- Fix Version/s: 2.3.0 3.0.0 > HBCK's "Orphan Regions on FileSystem" reports

[jira] [Created] (HBASE-24273) HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles

2020-04-27 Thread Andrey Elenskiy (Jira)
Andrey Elenskiy created HBASE-24273: --- Summary: HBCK's "Orphan Regions on FileSystem" reports regions with referenced HFiles Key: HBASE-24273 URL: https://issues.apache.org/jira/browse/HBASE-24273

[jira] [Commented] (HBASE-24261) Redo all of our github notification integrations on new ASF infra feature

2020-04-27 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093878#comment-17093878 ] Wei-Chiu Chuang commented on HBASE-24261: - I think we have this problem in Hadoop as well. >

[GitHub] [hbase] Apache-HBase commented on pull request #1591: HBASE-24267 add limit support for scan in rest api

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1591: URL: https://github.com/apache/hbase/pull/1591#issuecomment-620187548 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1591: HBASE-24267 add limit support for scan in rest api

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1591: URL: https://github.com/apache/hbase/pull/1591#issuecomment-620182231 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1590: HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoC…

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1590: URL: https://github.com/apache/hbase/pull/1590#issuecomment-620181867 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1591: HBASE-24267 add limit support for scan in rest api

2020-04-27 Thread GitBox
Apache-HBase commented on pull request #1591: URL: https://github.com/apache/hbase/pull/1591#issuecomment-620180875 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24272) Backport "Implement proxyuser/doAs mechanism for hbase-http" to 2.1.x

2020-04-27 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093862#comment-17093862 ] Josh Elser commented on HBASE-24272: Looks like Hadoop 2.7.7 doesn't have the {{getPropsWithPrefix}}

[jira] [Resolved] (HBASE-24252) Implement proxyuser/doAs mechanism for hbase-http

2020-04-27 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-24252. Hadoop Flags: Reviewed Resolution: Fixed Spun out a child-task for the 2.1.x backport.

[jira] [Updated] (HBASE-24252) Implement proxyuser/doAs mechanism for hbase-http

2020-04-27 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-24252: --- Component/s: UI security > Implement proxyuser/doAs mechanism for hbase-http >

[jira] [Created] (HBASE-24272) Backport "Implement proxyuser/doAs mechanism for hbase-http" to 2.1.x

2020-04-27 Thread Josh Elser (Jira)
Josh Elser created HBASE-24272: -- Summary: Backport "Implement proxyuser/doAs mechanism for hbase-http" to 2.1.x Key: HBASE-24272 URL: https://issues.apache.org/jira/browse/HBASE-24272 Project: HBase

  1   2   3   >