[GitHub] [hbase] Apache-HBase commented on pull request #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #251: URL: https://github.com/apache/hbase/pull/251#issuecomment-697150208 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m 42s

[jira] [Commented] (HBASE-25068) Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space

2020-09-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200570#comment-17200570 ] Duo Zhang commented on HBASE-25068: --- Thank you sir. I think on a feature branch we could do changes

[GitHub] [hbase] Apache-HBase commented on pull request #2442: HBASE-25079 Upgrade Bootstrap to 3.3.7

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2442: URL: https://github.com/apache/hbase/pull/2442#issuecomment-697061543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] infraio commented on pull request #2444: HBASE-25086 Refactor Replication: move the default ReplicationSinkSer…

2020-09-22 Thread GitBox
infraio commented on pull request #2444: URL: https://github.com/apache/hbase/pull/2444#issuecomment-697122549 And I removed the ThreadPool and use RS's ChoreService instead. This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #2444: HBASE-25086 Refactor Replication: move the default ReplicationSinkSer…

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2444: URL: https://github.com/apache/hbase/pull/2444#issuecomment-697126009 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2443: Should not use XXXService.Interface.class.getSimpleName as stub key prefix in AsyncConnectionImpl

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2443: URL: https://github.com/apache/hbase/pull/2443#issuecomment-697112542 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] apurtell commented on pull request #2442: HBASE-25079 Upgrade Bootstrap to 3.3.7

2020-09-22 Thread GitBox
apurtell commented on pull request #2442: URL: https://github.com/apache/hbase/pull/2442#issuecomment-697081182 Will add RAT exclusions, back soon. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #2439: HBASE-25081 Up the container nproc uplimit to 30000

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2439: URL: https://github.com/apache/hbase/pull/2439#issuecomment-696786684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] saintstack closed pull request #2421: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-22 Thread GitBox
saintstack closed pull request #2421: URL: https://github.com/apache/hbase/pull/2421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2353: HBASE-24981 Enable table replication fails from 1.x to 2.x if table a…

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2353: URL: https://github.com/apache/hbase/pull/2353#issuecomment-696388232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2438: URL: https://github.com/apache/hbase/pull/2438#issuecomment-696703259 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] saintstack merged pull request #2435: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-22 Thread GitBox
saintstack merged pull request #2435: URL: https://github.com/apache/hbase/pull/2435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] virajjasani commented on pull request #2436: HBASE-25080 Should not use AssignmentManager to test whether a table …

2020-09-22 Thread GitBox
virajjasani commented on pull request #2436: URL: https://github.com/apache/hbase/pull/2436#issuecomment-696557272 +1 for the change, but test failures seem relevant? This is an automated message from the Apache Git Service.

[GitHub] [hbase] saintstack merged pull request #2434: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-22 Thread GitBox
saintstack merged pull request #2434: URL: https://github.com/apache/hbase/pull/2434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2437: HBASE-25053 WAL replay should ignore 0-length files

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2437: URL: https://github.com/apache/hbase/pull/2437#issuecomment-696496119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] infraio merged pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-22 Thread GitBox
infraio merged pull request #2430: URL: https://github.com/apache/hbase/pull/2430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack commented on pull request #2421: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-22 Thread GitBox
saintstack commented on pull request #2421: URL: https://github.com/apache/hbase/pull/2421#issuecomment-696858663 Merged to branch-2 manually. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2440: URL: https://github.com/apache/hbase/pull/2440#issuecomment-696933888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] saintstack commented on pull request #2434: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-22 Thread GitBox
saintstack commented on pull request #2434: URL: https://github.com/apache/hbase/pull/2434#issuecomment-696921949 Ran the failed test locally w/ jdk8 and jdk11 and it passed. It fails 10% of the time according to flakey dashboard. Let me merge. Will keep an eye on it.

[GitHub] [hbase] saintstack merged pull request #2439: HBASE-25081 Up the container nproc uplimit to 30000

2020-09-22 Thread GitBox
saintstack merged pull request #2439: URL: https://github.com/apache/hbase/pull/2439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-696697458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2441: HBASE-25085 Add support for java properties to hbase-vote.sh

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2441: URL: https://github.com/apache/hbase/pull/2441#issuecomment-697002166 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] gjacoby126 commented on a change in pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
gjacoby126 commented on a change in pull request #2440: URL: https://github.com/apache/hbase/pull/2440#discussion_r493012475 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWAL.java ## @@ -58,9 +59,10 @@ public void postSync(final long

[GitHub] [hbase] Apache9 commented on pull request #2437: HBASE-25053 WAL replay should ignore 0-length files

2020-09-22 Thread GitBox
Apache9 commented on pull request #2437: URL: https://github.com/apache/hbase/pull/2437#issuecomment-696734732 This is just a simple optimization or something related to correctness? I'm not sure whether at this step we have finished recoverLease for all the WAL files? I mean

[GitHub] [hbase] Apache-HBase commented on pull request #2436: HBASE-25080 Should not use AssignmentManager to test whether a table …

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2436: URL: https://github.com/apache/hbase/pull/2436#issuecomment-696483579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] bharathv commented on a change in pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
bharathv commented on a change in pull request #2440: URL: https://github.com/apache/hbase/pull/2440#discussion_r493099034 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWAL.java ## @@ -58,9 +59,10 @@ public void postSync(final long

[GitHub] [hbase] Apache-HBase commented on pull request #2434: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2434: URL: https://github.com/apache/hbase/pull/2434#issuecomment-696375809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2435: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2435: URL: https://github.com/apache/hbase/pull/2435#issuecomment-696402037 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2326: URL: https://github.com/apache/hbase/pull/2326#issuecomment-696554325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] bsglz commented on a change in pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-22 Thread GitBox
bsglz commented on a change in pull request #2326: URL: https://github.com/apache/hbase/pull/2326#discussion_r492441835 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -1741,9 +1741,10 @@ RegionLoad createRegionLoad(final

[GitHub] [hbase] nkalmar commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-09-22 Thread GitBox
nkalmar commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-696685975 Rebased to current master This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] wchevreuil commented on a change in pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-22 Thread GitBox
wchevreuil commented on a change in pull request #2430: URL: https://github.com/apache/hbase/pull/2430#discussion_r492588627 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java ## @@ -63,7 +121,7 @@ protected synchronized

[GitHub] [hbase] joshelser commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-09-22 Thread GitBox
joshelser commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-696870760 Some subtle changes I'm noticing, the prompt is different. Now.. ``` hbase(#):003:0> ``` and before... ``` hbase(main):001:0> ``` Timestamps are also

[GitHub] [hbase] Apache-HBase commented on pull request #2419: HBASE-25050 - We initialize Filesystems more than once.

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2419: URL: https://github.com/apache/hbase/pull/2419#issuecomment-696690164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2430: URL: https://github.com/apache/hbase/pull/2430#issuecomment-696477637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] infraio commented on a change in pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-22 Thread GitBox
infraio commented on a change in pull request #2430: URL: https://github.com/apache/hbase/pull/2430#discussion_r493111540 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java ## @@ -63,7 +121,7 @@ protected synchronized

[GitHub] [hbase] Apache-HBase commented on pull request #2385: HBASE-24950 Another solution for Splittable Meta

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2385: URL: https://github.com/apache/hbase/pull/2385#issuecomment-696786699 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache9 commented on a change in pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-22 Thread GitBox
Apache9 commented on a change in pull request #2326: URL: https://github.com/apache/hbase/pull/2326#discussion_r492448370 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -3907,4 +3909,51 @@ public MetaRegionLocationCache

[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica

2020-09-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200499#comment-17200499 ] Michael Stack commented on HBASE-18070: --- Made a HBASE-18070 branch just now from master at

[jira] [Commented] (HBASE-25068) Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space

2020-09-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200498#comment-17200498 ] Michael Stack commented on HBASE-25068: --- Pushed master branch patch on to HBASE-18070 which I just

[jira] [Updated] (HBASE-25068) Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space

2020-09-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25068: -- Fix Version/s: (was: 2.4.0) (was: 3.0.0-alpha-1)

[jira] [Updated] (HBASE-25068) Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space

2020-09-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25068: -- Attachment: 0001-HBASE-25068-Pass-WALFactory-to-Replication-so-it-kno.patch.master > Pass

[jira] [Updated] (HBASE-25068) Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space

2020-09-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25068: -- Attachment: 0001-HBASE-25068-Pass-WALFactory-to-Replication-so-it-kno.patch.2 > Pass

[GitHub] [hbase] infraio opened a new pull request #2444: HBASE-25086 Refactor Replication: move the default ReplicationSinkSer…

2020-09-22 Thread GitBox
infraio opened a new pull request #2444: URL: https://github.com/apache/hbase/pull/2444 …vice implementation out This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HBASE-25068) Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space

2020-09-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200494#comment-17200494 ] Michael Stack commented on HBASE-25068: --- OK. No problem. Will revert and make a HBASE-18070

[jira] [Updated] (HBASE-25086) Refactor Replication: move the default ReplicationSinkService implementation out

2020-09-22 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-25086: --- Description: Now the Replication implements both ReplicationSourceService and

[jira] [Created] (HBASE-25086) Refactor Replication: move the default ReplicationSinkService implementation out

2020-09-22 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-25086: -- Summary: Refactor Replication: move the default ReplicationSinkService implementation out Key: HBASE-25086 URL: https://issues.apache.org/jira/browse/HBASE-25086

[GitHub] [hbase] Apache-HBase commented on pull request #2442: HBASE-25079 Upgrade Bootstrap to 3.3.7

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2442: URL: https://github.com/apache/hbase/pull/2442#issuecomment-697114351 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2443: Should not use XXXService.Interface.class.getSimpleName as stub key prefix in AsyncConnectionImpl

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2443: URL: https://github.com/apache/hbase/pull/2443#issuecomment-697113046 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2443: Should not use XXXService.Interface.class.getSimpleName as stub key prefix in AsyncConnectionImpl

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2443: URL: https://github.com/apache/hbase/pull/2443#issuecomment-697112703 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2443: Should not use XXXService.Interface.class.getSimpleName as stub key prefix in AsyncConnectionImpl

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2443: URL: https://github.com/apache/hbase/pull/2443#issuecomment-697112542 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] wwmandy opened a new pull request #2443: Should not use XXXService.Interface.class.getSimpleName as stub key prefix in AsyncConnectionImpl

2020-09-22 Thread GitBox
wwmandy opened a new pull request #2443: URL: https://github.com/apache/hbase/pull/2443 It will just return "Interface" for all services. This is not a bug for AsyncConnectionImpl as we have different maps for ClientService and AdminService, but it is still a bit confusing to developers.

[GitHub] [hbase] apurtell commented on pull request #2442: HBASE-25079 Upgrade Bootstrap to 3.3.7

2020-09-22 Thread GitBox
apurtell commented on pull request #2442: URL: https://github.com/apache/hbase/pull/2442#issuecomment-697081182 Will add RAT exclusions, back soon. This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (HBASE-25079) Upgrade Bootstrap to 3.3.7

2020-09-22 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25079: Status: Patch Available (was: Open) > Upgrade Bootstrap to 3.3.7 >

[jira] [Commented] (HBASE-25068) Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space

2020-09-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200465#comment-17200465 ] Duo Zhang commented on HBASE-25068: --- Hi, sir, you missed my comments on the PR? {quote} Let's change

[GitHub] [hbase] Apache-HBase commented on pull request #2442: HBASE-25079 Upgrade Bootstrap to 3.3.7

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2442: URL: https://github.com/apache/hbase/pull/2442#issuecomment-697061543 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell opened a new pull request #2442: HBASE-25079 Upgrade Bootstrap to 3.3.7

2020-09-22 Thread GitBox
apurtell opened a new pull request #2442: URL: https://github.com/apache/hbase/pull/2442 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] infraio commented on a change in pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-22 Thread GitBox
infraio commented on a change in pull request #2430: URL: https://github.com/apache/hbase/pull/2430#discussion_r493111540 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java ## @@ -63,7 +121,7 @@ protected synchronized

[GitHub] [hbase] Apache-HBase commented on pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2440: URL: https://github.com/apache/hbase/pull/2440#issuecomment-697056723 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2440: URL: https://github.com/apache/hbase/pull/2440#issuecomment-697053207 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] infraio merged pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-22 Thread GitBox
infraio merged pull request #2430: URL: https://github.com/apache/hbase/pull/2430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] bharathv commented on a change in pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
bharathv commented on a change in pull request #2440: URL: https://github.com/apache/hbase/pull/2440#discussion_r493099034 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWAL.java ## @@ -58,9 +59,10 @@ public void postSync(final long

[GitHub] [hbase] Apache-HBase commented on pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2440: URL: https://github.com/apache/hbase/pull/2440#issuecomment-697015514 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2441: HBASE-25085 Add support for java properties to hbase-vote.sh

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2441: URL: https://github.com/apache/hbase/pull/2441#issuecomment-697003597 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2441: HBASE-25085 Add support for java properties to hbase-vote.sh

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2441: URL: https://github.com/apache/hbase/pull/2441#issuecomment-697002166 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2440: URL: https://github.com/apache/hbase/pull/2440#issuecomment-697001679 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25084) RegexStringComparator in ParseFilter should support case-insensitive regexes

2020-09-22 Thread Scott Hunt (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200401#comment-17200401 ] Scott Hunt commented on HBASE-25084: I've added a very simple patch, as a potential starting point.

[jira] [Updated] (HBASE-25084) RegexStringComparator in ParseFilter should support case-insensitive regexes

2020-09-22 Thread Scott Hunt (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Hunt updated HBASE-25084: --- Attachment: HBASE-25084.v0.patch > RegexStringComparator in ParseFilter should support

[GitHub] [hbase] ndimiduk opened a new pull request #2441: HBASE-25085 Add support for java properties to hbase-vote.sh

2020-09-22 Thread GitBox
ndimiduk opened a new pull request #2441: URL: https://github.com/apache/hbase/pull/2441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (HBASE-25085) Add support for java properties to hbase-vote.sh

2020-09-22 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-25085: Summary: Add support for java properties to hbase-vote.sh Key: HBASE-25085 URL: https://issues.apache.org/jira/browse/HBASE-25085 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2440: URL: https://github.com/apache/hbase/pull/2440#issuecomment-696998814 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25084) RegexStringComparator in ParseFilter should support case-insensitive regexes

2020-09-22 Thread Scott Hunt (Jira)
Scott Hunt created HBASE-25084: -- Summary: RegexStringComparator in ParseFilter should support case-insensitive regexes Key: HBASE-25084 URL: https://issues.apache.org/jira/browse/HBASE-25084 Project:

[GitHub] [hbase] gjacoby126 commented on a change in pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
gjacoby126 commented on a change in pull request #2440: URL: https://github.com/apache/hbase/pull/2440#discussion_r493012475 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWAL.java ## @@ -58,9 +59,10 @@ public void postSync(final long

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-09-22 Thread Vladimir Rodionov (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200361#comment-17200361 ] Vladimir Rodionov commented on HBASE-23887: --- {quote} Thats why this feature will work when the

[jira] [Created] (HBASE-25083) make sure the next hbase 1.y release has Hadoop 2.10 as a minimum version

2020-09-22 Thread Sean Busbey (Jira)
Sean Busbey created HBASE-25083: --- Summary: make sure the next hbase 1.y release has Hadoop 2.10 as a minimum version Key: HBASE-25083 URL: https://issues.apache.org/jira/browse/HBASE-25083 Project:

[GitHub] [hbase] Apache-HBase commented on pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2440: URL: https://github.com/apache/hbase/pull/2440#issuecomment-696933888 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25068) Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space

2020-09-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25068. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Pushed to

[GitHub] [hbase] saintstack merged pull request #2434: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-22 Thread GitBox
saintstack merged pull request #2434: URL: https://github.com/apache/hbase/pull/2434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #2434: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-22 Thread GitBox
saintstack commented on pull request #2434: URL: https://github.com/apache/hbase/pull/2434#issuecomment-696921949 Ran the failed test locally w/ jdk8 and jdk11 and it passed. It fails 10% of the time according to flakey dashboard. Let me merge. Will keep an eye on it.

[GitHub] [hbase] bharathv opened a new pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread GitBox
bharathv opened a new pull request #2440: URL: https://github.com/apache/hbase/pull/2440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (HBASE-25082) Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread Bharath Vissapragada (Jira)
Bharath Vissapragada created HBASE-25082: Summary: Per table WAL metrics: appendCount and appendSize Key: HBASE-25082 URL: https://issues.apache.org/jira/browse/HBASE-25082 Project: HBase

[jira] [Updated] (HBASE-25082) Per table WAL metrics: appendCount and appendSize

2020-09-22 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-25082: - Affects Version/s: 2.4.0 1.7.0

[GitHub] [hbase] Apache-HBase commented on pull request #2385: HBASE-24950 Another solution for Splittable Meta

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2385: URL: https://github.com/apache/hbase/pull/2385#issuecomment-696909317 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2385: HBASE-24950 Another solution for Splittable Meta

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2385: URL: https://github.com/apache/hbase/pull/2385#issuecomment-696905133 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-09-22 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200283#comment-17200283 ] Josh Elser commented on HBASE-23887: bq. While looking at the patch, I was wondering if we should

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-696874037 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] joshelser commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-09-22 Thread GitBox
joshelser commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-696870760 Some subtle changes I'm noticing, the prompt is different. Now.. ``` hbase(#):003:0> ``` and before... ``` hbase(main):001:0> ``` Timestamps are also

[jira] [Resolved] (HBASE-25067) Edit of log messages around async WAL Replication; checkstyle fixes; and a bugfix

2020-09-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25067. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Pushed to

[GitHub] [hbase] saintstack closed pull request #2421: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-22 Thread GitBox
saintstack closed pull request #2421: URL: https://github.com/apache/hbase/pull/2421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #2421: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-22 Thread GitBox
saintstack commented on pull request #2421: URL: https://github.com/apache/hbase/pull/2421#issuecomment-696858663 Merged to branch-2 manually. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] saintstack merged pull request #2435: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-22 Thread GitBox
saintstack merged pull request #2435: URL: https://github.com/apache/hbase/pull/2435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (HBASE-25081) Up the container nproc uplimit to 30000

2020-09-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25081. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Release Note: Ups the nproc

[jira] [Commented] (HBASE-25081) Up the container nproc uplimit to 30000

2020-09-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200193#comment-17200193 ] Michael Stack commented on HBASE-25081: --- No hurry [~stoty]  Come back when you need it applied

[jira] [Commented] (HBASE-25081) Up the container nproc uplimit to 30000

2020-09-22 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200178#comment-17200178 ] Istvan Toth commented on HBASE-25081: - Thank you [~stack] . I am not sure if Yetus (re)loads the

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-696812697 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25081) Up the container nproc uplimit to 30000

2020-09-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200171#comment-17200171 ] Michael Stack commented on HBASE-25081: --- Merged on master. See if it helps? If it does, then we

[GitHub] [hbase] saintstack merged pull request #2439: HBASE-25081 Up the container nproc uplimit to 30000

2020-09-22 Thread GitBox
saintstack merged pull request #2439: URL: https://github.com/apache/hbase/pull/2439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2439: HBASE-25081 Up the container nproc uplimit to 30000

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2439: URL: https://github.com/apache/hbase/pull/2439#issuecomment-696788682 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2439: HBASE-25081 Up the container nproc uplimit to 30000

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2439: URL: https://github.com/apache/hbase/pull/2439#issuecomment-696788235 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2439: HBASE-25081 Up the container nproc uplimit to 30000

2020-09-22 Thread GitBox
Apache-HBase commented on pull request #2439: URL: https://github.com/apache/hbase/pull/2439#issuecomment-696787889 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   >