[GitHub] [hbase] sunhelly edited a comment on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

sunhelly edited a comment on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-733530907 > Looks like it just adding a try/finally so we always unbuffer. Thats good. We weren't calling unbuffer ever? Thanks. Otherwise patch looks good to me. Thanks for

[GitHub] [hbase] sunhelly commented on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

sunhelly commented on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-733530907 > Looks like it just adding a try/finally so we always unbuffer. Thats good. We weren't calling unbuffer ever? Thanks. Otherwise patch looks good to me. Thanks for

[GitHub] [hbase] sunhelly commented on pull request #2699: HBASE-25287 Forgetting to unbuffer streams results in many CLOSE_WAIT…

sunhelly commented on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-733527278 > I see that in HFile.createReader we will call context.getInputStreamWrapper().unbuffer()? It is not enough to solve the problem here? Mind explaining a bit more? Thanks

[GitHub] [hbase] Apache-HBase commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

Apache-HBase commented on pull request #2695: URL: https://github.com/apache/hbase/pull/2695#issuecomment-733526610 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25323) Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

[ https://issues.apache.org/jira/browse/HBASE-25323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-25323. Fix Version/s: 2.3.4 2.2.7 2.4.0

[jira] [Resolved] (HBASE-25281) Bulkload split hfile too many times due to unreasonable split point

[ https://issues.apache.org/jira/browse/HBASE-25281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-25281. Fix Version/s: 2.4.0 3.0.0-alpha-1 Resolution: Fixed Pushed to

[GitHub] [hbase] Apache-HBase commented on pull request #2708: HBASE-25330 RSGroupInfoManagerImpl#moveServers return is not set of servers moved

Apache-HBase commented on pull request #2708: URL: https://github.com/apache/hbase/pull/2708#issuecomment-733521574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25325) Remove unused class ClusterSchemaException

[ https://issues.apache.org/jira/browse/HBASE-25325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-25325. Fix Version/s: 2.4.0 3.0.0-alpha-1 Resolution: Fixed Pushed to

[GitHub] [hbase] infraio merged pull request #2692: Backport HBASE-25281 Bulkload split hfile too many times due to unreasonable split point

infraio merged pull request #2692: URL: https://github.com/apache/hbase/pull/2692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (HBASE-25282) Remove processingServers in DeadServer as we can get this information by Procedure of master

[ https://issues.apache.org/jira/browse/HBASE-25282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-25282. Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed Pushed to master. Thanks [~yuqi] 

[GitHub] [hbase] infraio merged pull request #2657: HBASE-25282 Remove processingServers in DeadServer as we can get this…

infraio merged pull request #2657: URL: https://github.com/apache/hbase/pull/2657 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] infraio commented on pull request #2657: HBASE-25282 Remove processingServers in DeadServer as we can get this…

infraio commented on pull request #2657: URL: https://github.com/apache/hbase/pull/2657#issuecomment-733515557 The failed ut not related. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] infraio merged pull request #2702: HBASE-25323 Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

infraio merged pull request #2702: URL: https://github.com/apache/hbase/pull/2702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-733514137 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] infraio merged pull request #2704: HBASE-25325 Remove unused class ClusterSchemaException

infraio merged pull request #2704: URL: https://github.com/apache/hbase/pull/2704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] virajjasani commented on a change in pull request #2705: HBASE-25237 : 'hbase master stop' shuts down the cluster, not the master only

virajjasani commented on a change in pull request #2705: URL: https://github.com/apache/hbase/pull/2705#discussion_r530146588 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java ## @@ -139,7 +148,15 @@ public int run(String args[])

[GitHub] [hbase] Apache-HBase commented on pull request #2702: HBASE-25323 Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

Apache-HBase commented on pull request #2702: URL: https://github.com/apache/hbase/pull/2702#issuecomment-733507284 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] lokiore commented on pull request #2705: HBASE-25237 : 'hbase master stop' shuts down the cluster, not the master only

lokiore commented on pull request #2705: URL: https://github.com/apache/hbase/pull/2705#issuecomment-733501869 @virajjasani @saintstack please take a look! This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #2704: HBASE-25325 Remove unused class ClusterSchemaException

Apache-HBase commented on pull request #2704: URL: https://github.com/apache/hbase/pull/2704#issuecomment-733496095 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-733495328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2692: Backport HBASE-25281 Bulkload split hfile too many times due to unreasonable split point

Apache-HBase commented on pull request #2692: URL: https://github.com/apache/hbase/pull/2692#issuecomment-733494990 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

Apache-HBase commented on pull request #2695: URL: https://github.com/apache/hbase/pull/2695#issuecomment-733494332 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

Apache9 commented on pull request #2707: URL: https://github.com/apache/hbase/pull/2707#issuecomment-733493026 These classes are all implementation class, so in general I do not think it is a good idea to make them public to others. I did a simple search on

[GitHub] [hbase] Apache-HBase commented on pull request #2708: HBASE-25330 RSGroupInfoManagerImpl#moveServers return is not set of servers moved

Apache-HBase commented on pull request #2708: URL: https://github.com/apache/hbase/pull/2708#issuecomment-733492281 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2657: HBASE-25282 Remove processingServers in DeadServer as we can get this…

Apache-HBase commented on pull request #2657: URL: https://github.com/apache/hbase/pull/2657#issuecomment-733483665 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2702: HBASE-25323 Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

Apache-HBase commented on pull request #2702: URL: https://github.com/apache/hbase/pull/2702#issuecomment-733483438 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-733475403 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] anoopsjohn commented on a change in pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

anoopsjohn commented on a change in pull request #2675: URL: https://github.com/apache/hbase/pull/2675#discussion_r530116513 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java ## @@ -299,6 +304,11 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #2692: Backport HBASE-25281 Bulkload split hfile too many times due to unreasonable split point

Apache-HBase commented on pull request #2692: URL: https://github.com/apache/hbase/pull/2692#issuecomment-733469091 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2696: HBASE-24640 [branch-2] Purge use of VisibleForTesting

Apache-HBase commented on pull request #2696: URL: https://github.com/apache/hbase/pull/2696#issuecomment-733468242 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] anoopsjohn commented on pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

anoopsjohn commented on pull request #2707: URL: https://github.com/apache/hbase/pull/2707#issuecomment-733467473 We should not be exposing entire PrivateCellUtil even for CPs. There is a Cell util public and CP exposed version. For CPs to handle tags, if we need new APIs, lets target

[GitHub] [hbase] Apache-HBase commented on pull request #2704: HBASE-25325 Remove unused class ClusterSchemaException

Apache-HBase commented on pull request #2704: URL: https://github.com/apache/hbase/pull/2704#issuecomment-733465858 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2657: HBASE-25282 Remove processingServers in DeadServer as we can get this…

Apache-HBase commented on pull request #2657: URL: https://github.com/apache/hbase/pull/2657#issuecomment-733461389 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2696: HBASE-24640 [branch-2] Purge use of VisibleForTesting

Apache-HBase commented on pull request #2696: URL: https://github.com/apache/hbase/pull/2696#issuecomment-733460121 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…

Apache-HBase commented on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-733455199 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…

Apache-HBase commented on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-733451198 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…

Apache-HBase commented on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-733449748 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2708: HBASE-25330 RSGroupInfoManagerImpl#moveServers return is not set of servers moved

Apache-HBase commented on pull request #2708: URL: https://github.com/apache/hbase/pull/2708#issuecomment-733449501 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] sguggilam commented on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…

sguggilam commented on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-733443216 @Apache9 Updated the PR to read the unsafe usage system property as well. Please review and provide your feedback

[GitHub] [hbase] Apache-HBase commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

Apache-HBase commented on pull request #2695: URL: https://github.com/apache/hbase/pull/2695#issuecomment-733442821 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2702: HBASE-25323 Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

Apache-HBase commented on pull request #2702: URL: https://github.com/apache/hbase/pull/2702#issuecomment-733440916 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

Apache-HBase commented on pull request #2703: URL: https://github.com/apache/hbase/pull/2703#issuecomment-733436682 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2692: Backport HBASE-25281 Bulkload split hfile too many times due to unreasonable split point

Apache-HBase commented on pull request #2692: URL: https://github.com/apache/hbase/pull/2692#issuecomment-733434920 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ZhaoBQ opened a new pull request #2708: HBASE-25330 RSGroupInfoManagerImpl#moveServers return is not set of servers moved

ZhaoBQ opened a new pull request #2708: URL: https://github.com/apache/hbase/pull/2708 [HBASE-25330](https://issues.apache.org/jira/browse/HBASE-25330) This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on pull request #2697: HBASE-24640 [branch-1] Purge use of VisibleForTesting

Apache-HBase commented on pull request #2697: URL: https://github.com/apache/hbase/pull/2697#issuecomment-733433007 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25330) RSGroupInfoManagerImpl#moveServers return is not set of servers moved

Baiqiang Zhao created HBASE-25330: - Summary: RSGroupInfoManagerImpl#moveServers return is not set of servers moved Key: HBASE-25330 URL: https://issues.apache.org/jira/browse/HBASE-25330 Project:

[GitHub] [hbase] Apache-HBase commented on pull request #2704: HBASE-25325 Remove unused class ClusterSchemaException

Apache-HBase commented on pull request #2704: URL: https://github.com/apache/hbase/pull/2704#issuecomment-733428991 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2657: HBASE-25282 Remove processingServers in DeadServer as we can get this…

Apache-HBase commented on pull request #2657: URL: https://github.com/apache/hbase/pull/2657#issuecomment-733428939 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] yuqi1129 commented on a change in pull request #2702: HBASE-25323 Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

yuqi1129 commented on a change in pull request #2702: URL: https://github.com/apache/hbase/pull/2702#discussion_r530070666 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java ## @@ -297,7 +297,7 @@ public static boolean

[GitHub] [hbase] yuqi1129 commented on a change in pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

yuqi1129 commented on a change in pull request #2703: URL: https://github.com/apache/hbase/pull/2703#discussion_r530065240 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java ## @@ -242,11 +242,11 @@ public long

[GitHub] [hbase] yuqi1129 commented on a change in pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

yuqi1129 commented on a change in pull request #2703: URL: https://github.com/apache/hbase/pull/2703#discussion_r530067556 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -220,17 +218,16 @@ public static boolean splitLogFile(Path

[GitHub] [hbase] Apache-HBase commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

Apache-HBase commented on pull request #2695: URL: https://github.com/apache/hbase/pull/2695#issuecomment-733420181 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] yuqi1129 commented on a change in pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

yuqi1129 commented on a change in pull request #2703: URL: https://github.com/apache/hbase/pull/2703#discussion_r530065240 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java ## @@ -242,11 +242,11 @@ public long

[GitHub] [hbase] Apache-HBase commented on pull request #2696: HBASE-24640 [branch-2] Purge use of VisibleForTesting

Apache-HBase commented on pull request #2696: URL: https://github.com/apache/hbase/pull/2696#issuecomment-733419206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] yuqi1129 commented on a change in pull request #2704: HBASE-25325 Remove unused class ClusterSchemaException

yuqi1129 commented on a change in pull request #2704: URL: https://github.com/apache/hbase/pull/2704#discussion_r530062216 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterSchema.java ## @@ -82,8 +82,7 @@ * @param nonceKey A unique identifier

[GitHub] [hbase] yuqi1129 commented on a change in pull request #2704: HBASE-25325 Remove unused class ClusterSchemaException

yuqi1129 commented on a change in pull request #2704: URL: https://github.com/apache/hbase/pull/2704#discussion_r530061935 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterSchema.java ## @@ -105,8 +103,7 @@ long

[GitHub] [hbase] Apache9 commented on a change in pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

Apache9 commented on a change in pull request #2630: URL: https://github.com/apache/hbase/pull/2630#discussion_r530057114 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -972,11 +1001,44 @@ private void doBatchOp(final

[GitHub] [hbase] apurtell commented on pull request #2697: HBASE-24640 [branch-1] Purge use of VisibleForTesting

apurtell commented on pull request #2697: URL: https://github.com/apache/hbase/pull/2697#issuecomment-733404029 Rebased. Pushed checkstyle fixes. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #2696: HBASE-24640 [branch-2] Purge use of VisibleForTesting

Apache-HBase commented on pull request #2696: URL: https://github.com/apache/hbase/pull/2696#issuecomment-733398521 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] apurtell commented on pull request #2696: HBASE-24640 [branch-2] Purge use of VisibleForTesting

apurtell commented on pull request #2696: URL: https://github.com/apache/hbase/pull/2696#issuecomment-733398258 Pushed checkstyle fixes This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] apurtell commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

apurtell commented on pull request #2695: URL: https://github.com/apache/hbase/pull/2695#issuecomment-733398228 Pushed checkstyle fixes This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

Apache-HBase commented on pull request #2695: URL: https://github.com/apache/hbase/pull/2695#issuecomment-733397054 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2696: HBASE-24640 [branch-2] Purge use of VisibleForTesting

Apache-HBase commented on pull request #2696: URL: https://github.com/apache/hbase/pull/2696#issuecomment-733395447 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] brfrn169 commented on pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

brfrn169 commented on pull request #2630: URL: https://github.com/apache/hbase/pull/2630#issuecomment-733347321 Thank you @apurtell Can you please review this? @Apache9 This is an automated message from the Apache

[jira] [Resolved] (HBASE-25213) Should request Compaction when bulkLoadHFiles is done

[ https://issues.apache.org/jira/browse/HBASE-25213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-25213. Resolution: Fixed Pushed the addendum patch to branch-2 and master. > Should request

[GitHub] [hbase] infraio merged pull request #2701: HBASE-25213 Should request Compaction when bulkLoadHFiles is done (addendum)

infraio merged pull request #2701: URL: https://github.com/apache/hbase/pull/2701 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] infraio commented on a change in pull request #2703: HBASE-25324 Remove unnecessary array to list conversion in SplitLogManager

infraio commented on a change in pull request #2703: URL: https://github.com/apache/hbase/pull/2703#discussion_r530017786 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -220,17 +218,16 @@ public static boolean splitLogFile(Path

[GitHub] [hbase] infraio commented on a change in pull request #2702: HBASE-25323 Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start

infraio commented on a change in pull request #2702: URL: https://github.com/apache/hbase/pull/2702#discussion_r530016823 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java ## @@ -297,7 +297,7 @@ public static boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2706: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2706: URL: https://github.com/apache/hbase/pull/2706#issuecomment-733292667 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2706: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2706: URL: https://github.com/apache/hbase/pull/2706#issuecomment-733290592 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2706: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2706: URL: https://github.com/apache/hbase/pull/2706#issuecomment-733290467 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 commented on pull request #2706: [HBASE-25246] Backup/Restore hbase cell tags.

shahrs87 commented on pull request #2706: URL: https://github.com/apache/hbase/pull/2706#issuecomment-733274700 @apurtell @gjacoby126 @virajjasani Could you please help reviewing this change ? Thank you ! This is an

[GitHub] [hbase] apurtell commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

apurtell commented on pull request #2695: URL: https://github.com/apache/hbase/pull/2695#issuecomment-733274059 Aha, now the checkstyle warns show up here as in the branch-1 precommit. These are expected and legacy and related to import order. Let me make a pass over them.

[GitHub] [hbase] Apache-HBase commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

Apache-HBase commented on pull request #2695: URL: https://github.com/apache/hbase/pull/2695#issuecomment-733273655 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 commented on pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

shahrs87 commented on pull request #2707: URL: https://github.com/apache/hbase/pull/2707#issuecomment-733272721 @apurtell @gjacoby126 @virajjasani Could you please help reviewing this change ? Thank you ! This is an

[GitHub] [hbase] Apache-HBase commented on pull request #2696: HBASE-24640 [branch-2] Purge use of VisibleForTesting

Apache-HBase commented on pull request #2696: URL: https://github.com/apache/hbase/pull/2696#issuecomment-733271743 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

Apache-HBase commented on pull request #2707: URL: https://github.com/apache/hbase/pull/2707#issuecomment-733270649 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

Apache-HBase commented on pull request #2707: URL: https://github.com/apache/hbase/pull/2707#issuecomment-733268241 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2706: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2706: URL: https://github.com/apache/hbase/pull/2706#issuecomment-733267463 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2706: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2706: URL: https://github.com/apache/hbase/pull/2706#issuecomment-733266630 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

Apache-HBase commented on pull request #2707: URL: https://github.com/apache/hbase/pull/2707#issuecomment-733265418 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2706: [HBASE-25246] Backup/Restore hbase cell tags.

Apache-HBase commented on pull request #2706: URL: https://github.com/apache/hbase/pull/2706#issuecomment-733264852 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] shahrs87 opened a new pull request #2707: [HBASE-25328] Make some Tag related classes annotation as LimitatePrivate.

shahrs87 opened a new pull request #2707: URL: https://github.com/apache/hbase/pull/2707 Need to make the following classes LP since we want to use some api's in Phoenix Coproc: https://issues.apache.org/jira/browse/PHOENIX-6213 ArrayBackedTag ByteBufferTag PrivateCellUtil

[GitHub] [hbase] shahrs87 opened a new pull request #2706: [HBASE-25246] Backup/Restore hbase cell tags.

shahrs87 opened a new pull request #2706: URL: https://github.com/apache/hbase/pull/2706 Added support for tags to import and export tool. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] apurtell commented on pull request #2696: HBASE-24640 [branch-2] Purge use of VisibleForTesting

apurtell commented on pull request #2696: URL: https://github.com/apache/hbase/pull/2696#issuecomment-733239288 @Reidd Approved the master version of this PR, merging down the line. This is an automated message from the

[GitHub] [hbase] apurtell commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

apurtell commented on pull request #2695: URL: https://github.com/apache/hbase/pull/2695#issuecomment-733239058 Thanks @Reidd ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache-HBase commented on pull request #2705: HBASE-25237 : 'hbase master stop' shuts down the cluster, not the master only

Apache-HBase commented on pull request #2705: URL: https://github.com/apache/hbase/pull/2705#issuecomment-733231916 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2705: HBASE-25237 : 'hbase master stop' shuts down the cluster, not the master only

Apache-HBase commented on pull request #2705: URL: https://github.com/apache/hbase/pull/2705#issuecomment-733227793 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

Apache-HBase commented on pull request #2685: URL: https://github.com/apache/hbase/pull/2685#issuecomment-733196559 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-733196305 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

Apache-HBase commented on pull request #2685: URL: https://github.com/apache/hbase/pull/2685#issuecomment-733191809 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

Apache-HBase commented on pull request #2685: URL: https://github.com/apache/hbase/pull/2685#issuecomment-733190213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline reassigned HBASE-25329: Assignee: Caroline > Dump region hashes in logs for the regions that are stuck in transition for

[jira] [Created] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

Caroline created HBASE-25329: Summary: Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time Key: HBASE-25329 URL:

[GitHub] [hbase-connectors] LucaCanali commented on pull request #75: [HBASE-25326] Allow running and building hbase-connectors with Apache Spark 3.0

LucaCanali commented on pull request #75: URL: https://github.com/apache/hbase-connectors/pull/75#issuecomment-733172592 Thanks @saintstack for looking at this. I am not sure I understand yet how the build errors relate to the patch. Could it be an issue with jenkins or am I missing

[GitHub] [hbase] Apache-HBase commented on pull request #2705: HBASE-25237 : 'hbase master stop' shuts down the cluster, not the master only

Apache-HBase commented on pull request #2705: URL: https://github.com/apache/hbase/pull/2705#issuecomment-733171123 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25187) Improve SizeCachedKV variants initialization

[ https://issues.apache.org/jira/browse/HBASE-25187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238309#comment-17238309 ] Hudson commented on HBASE-25187: Results for branch branch-2.2 [build #122 on

[GitHub] [hbase] busbey commented on a change in pull request #2685: HBASE-25307 ThreadLocal pooling leads to NullPointerException

busbey commented on a change in pull request #2685: URL: https://github.com/apache/hbase/pull/2685#discussion_r529793609 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/util/TestRoundRobinPoolMap.java ## @@ -45,58 +52,104 @@ protected PoolType getPoolType() {

[GitHub] [hbase] Apache-HBase commented on pull request #2676: HBASE-25263 Change encryption key generation algorithm used in the HBase shell

Apache-HBase commented on pull request #2676: URL: https://github.com/apache/hbase/pull/2676#issuecomment-733152866 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25237) 'hbase master stop' shuts down the cluster, not the master only

[ https://issues.apache.org/jira/browse/HBASE-25237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Khurana updated HBASE-25237: --- Attachment: HBASE-25237.patch Status: Patch Available (was: In Progress) > 'hbase

  1   2   3   >