[GitHub] [hbase] Reidddddd commented on pull request #2138: HBASE-20717 Implement CCSMap - a better concurrent map with compacted data structure

Reidd commented on pull request #2138: URL: https://github.com/apache/hbase/pull/2138#issuecomment-664858010 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] Reidddddd commented on pull request #2138: HBASE-20717 Implement CCSMap - a better concurrent map with compacted data structure

Reidd commented on pull request #2138: URL: https://github.com/apache/hbase/pull/2138#issuecomment-664180870 Hi @tedyu (waving), long time no see! I addressed parts of your reviews, some of them I'm not sure as well. Most of codes can't explain itself, and as we get deep, I

[GitHub] [hbase] Reidddddd commented on pull request #2138: HBASE-20717 Implement CCSMap - a better concurrent map with compacted data structure

Reidd commented on pull request #2138: URL: https://github.com/apache/hbase/pull/2138#issuecomment-663487900 TestCompactedConcurrentSkipList.java passed on local, while TestCompactedTypeHelper failed This is an

[GitHub] [hbase] Reidddddd commented on pull request #2138: HBASE-20717 Implement CCSMap - a better concurrent map with compacted data structure

Reidd commented on pull request #2138: URL: https://github.com/apache/hbase/pull/2138#issuecomment-663473781 In fact, I haven't go through the details yet. I'm thinking let's make v1 draft first, so members can review the details together.

[GitHub] [hbase] Reidddddd commented on pull request #2138: HBASE-20717 Implement CCSMap - a better concurrent map with compacted data structure

Reidd commented on pull request #2138: URL: https://github.com/apache/hbase/pull/2138#issuecomment-663473317 First draft: 1. Split the fat CompactedConcurrentSkipListMap class to several small classes. 2. Make the package under hbase-server ccsmap instead of hbase-common utils.