bbeaudreault commented on PR #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1091960402
Sounds good, thanks for the process clarification!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
bbeaudreault commented on PR #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1091876266
We should let the commit hooks run on that PR before merging, it's been a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bbeaudreault commented on PR #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1091875973
No worries, and thanks! I have PR up for branch-2:
https://github.com/apache/hbase/pull/4273. I just updated it with the last
change from here. Let me check if it applies cleanly to
bbeaudreault commented on pull request #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1085119735
@ndimiduk I pushed a fix for the one concern I had above. Let me know what
you think -- this could be one of those cases where I'm over thinking it and
actually it would be
bbeaudreault commented on pull request #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1083438588
Thanks for your review nick! I'll push a commit with the minor tweaks
discussed above later today or tomorrow, to give Andrew time to chime in if he
has any other feedback
bbeaudreault commented on pull request #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1081936776
I forgot to address one of your questions:
> I agree that "call queue too big/full" is actually an error message (an
explanation of the server detailed state that we
bbeaudreault commented on pull request #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1081912070
@ndimiduk great feedback as well, thanks! I agree with you on the relative
ambiguity here. I'm wondering how we can make incremental progress though. In
my opinion this PR
bbeaudreault commented on pull request #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1081778706
There is 1 test failure, `TestFuzzyRowFilterEndToEnd`, which looks to be
timeout/flake-related. I ran it locally against this branch and it succeeded.
--
This is an
bbeaudreault commented on pull request #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1080925690
@apurtell @ndimiduk for your consideration, my latest commit applies the
above todos that I came up with:
- Make CallQueueTooBigException extend CallDroppedException
bbeaudreault commented on pull request #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1079399239
Great feedback @apurtell. I hadn't thought of it like that, I mostly
considered ServerOverloaded to be a far better name than literally "cqtbe" :).
Now that I think about
bbeaudreault commented on pull request #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1078974977
Trying to be thorough here -- I've been doing some testing of the new
Configuration.addDeprecation. If we want to rely on the functionality it
provides,unfortunately I
bbeaudreault commented on pull request #4180:
URL: https://github.com/apache/hbase/pull/4180#issuecomment-1077802490
Thank you for the review @ndimiduk. My latest commits resolve all of your
comments.
--
This is an automated message from the Apache Git Service.
To respond to the
12 matches
Mail list logo
