[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797385#comment-17797385
]
Duo Zhang commented on HBASE-16458:
---
[~bbeaudreault] Do you think we still need this forthe
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613949#comment-16613949
]
Vladimir Rodionov commented on HBASE-16458:
---
Yes, with tearDown it took 63 min, w/o - 44 min.
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613941#comment-16613941
]
Josh Elser commented on HBASE-16458:
{quote}each test is executed in a separate JVM instance
{quote}
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608533#comment-16608533
]
Vladimir Rodionov commented on HBASE-16458:
---
[~ted_yu], cleanup must be done after *all* unit
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608470#comment-16608470
]
Ted Yu commented on HBASE-16458:
HBASE-16458-v2.patch was the last one from Vlad.
Patch v5 is from me.
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608468#comment-16608468
]
Mike Drob commented on HBASE-16458:
---
I'd like to review this patch but I'm confused which file I
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608182#comment-16608182
]
Ted Yu commented on HBASE-16458:
>From the test console, you would see:
{code}
17:01:53 | +1 |
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608164#comment-16608164
]
Vladimir Rodionov commented on HBASE-16458:
---
[~te...@apache.org], you did not need to install
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608136#comment-16608136
]
Hadoop QA commented on HBASE-16458:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608078#comment-16608078
]
Hadoop QA commented on HBASE-16458:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608029#comment-16608029
]
Ted Yu commented on HBASE-16458:
16458.v4.txt for checkstyle warnings.
> Shorten backup / restore test
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607939#comment-16607939
]
Hadoop QA commented on HBASE-16458:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607893#comment-16607893
]
Ted Yu commented on HBASE-16458:
Vlad:
Can you take a look at 16458.v2.txt ?
This is based on your
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607860#comment-16607860
]
Hadoop QA commented on HBASE-16458:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607807#comment-16607807
]
Vladimir Rodionov commented on HBASE-16458:
---
Patch v2 addresses checkstyle warnings.
>
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607779#comment-16607779
]
Hadoop QA commented on HBASE-16458:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607755#comment-16607755
]
Hadoop QA commented on HBASE-16458:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607737#comment-16607737
]
Ted Yu commented on HBASE-16458:
On Linux, with patch, from first test output:
{code}
2018-09-07
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607699#comment-16607699
]
Vladimir Rodionov commented on HBASE-16458:
---
With some tweak TestBackupBase and pom.xml now we
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606490#comment-16606490
]
Vladimir Rodionov commented on HBASE-16458:
---
Reopened.
Every test class starts a new HBase
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435796#comment-15435796
]
Hadoop QA commented on HBASE-16458:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435685#comment-15435685
]
Hadoop QA commented on HBASE-16458:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434053#comment-15434053
]
Ted Yu commented on HBASE-16458:
I forgot to record the runtime without patch - on Linux.
There were
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434048#comment-15434048
]
Vladimir Rodionov commented on HBASE-16458:
---
Without patch - 34 minutes
With patch - 29
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433396#comment-15433396
]
Vladimir Rodionov commented on HBASE-16458:
---
Sure, will do it today.
> Shorten backup /
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433175#comment-15433175
]
Ted Yu commented on HBASE-16458:
[~vrodionov]:
Mind taking another look ?
> Shorten backup / restore
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431828#comment-15431828
]
Vladimir Rodionov commented on HBASE-16458:
---
Some tests can be simplified, others can be
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431794#comment-15431794
]
Ted Yu commented on HBASE-16458:
Mind being a bit more specific on the optimizations ?
Thanks
> Shorten
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431787#comment-15431787
]
Vladimir Rodionov commented on HBASE-16458:
---
lgtm, but you can optimize more, I think,
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431498#comment-15431498
]
Ted Yu commented on HBASE-16458:
[~vrodionov]:
Can you take a look ?
> Shorten backup / restore test
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431224#comment-15431224
]
Ted Yu commented on HBASE-16458:
TestBackupAdmin took 490 seconds in the above run.
BackupAdmin
[
https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428984#comment-15428984
]
Vladimir Rodionov commented on HBASE-16458:
---
Interesting, last time I have run all tests they
32 matches
Mail list logo
