[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783105#comment-16783105
]
Guanghao Zhang commented on HBASE-20734:
Resolve as Fixed.
> Colocate recovered edits directory
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721181#comment-16721181
]
Hudson commented on HBASE-20734:
Results for branch branch-1.3
[build #576 on
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710957#comment-16710957
]
Hudson commented on HBASE-20734:
Results for branch branch-2.0
[build #1139 on
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629136#comment-16629136
]
Hudson commented on HBASE-20734:
Results for branch branch-2.1
[build #380 on
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628899#comment-16628899
]
Reid Chan commented on HBASE-20734:
---
Improvement as it is, can we add one more sentence about the what
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628832#comment-16628832
]
Zach York commented on HBASE-20734:
---
Thanks [~reidchan]! Sorry this had drifted off my radar before I
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628649#comment-16628649
]
Hudson commented on HBASE-20734:
Results for branch master
[build #511 on
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628640#comment-16628640
]
Reid Chan commented on HBASE-20734:
---
bq. will run hbase-2.0.0 on AWS? Or will they do 2.1.x?
This
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628580#comment-16628580
]
Hudson commented on HBASE-20734:
Results for branch branch-1.4
[build #478 on
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628565#comment-16628565
]
Hudson commented on HBASE-20734:
Results for branch branch-1
[build #476 on
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628539#comment-16628539
]
Hudson commented on HBASE-20734:
Results for branch branch-2
[build #1303 on
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628359#comment-16628359
]
Duo Zhang commented on HBASE-20734:
---
If we have committed it into 1.4 then I think it may be worth to
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628249#comment-16628249
]
stack commented on HBASE-20734:
---
[~reidchan] Needs a release note with how to configure new facility.
You
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628236#comment-16628236
]
Reid Chan commented on HBASE-20734:
---
Pushed to master, branch-2, branch-1 and branch-1.4.
ping
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628222#comment-16628222
]
Reid Chan commented on HBASE-20734:
---
Conflicts in branch-2,
{code}
<<< HEAD
51 *
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627578#comment-16627578
]
Reid Chan commented on HBASE-20734:
---
Will commit it late this day if no other comments.
> Colocate
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622755#comment-16622755
]
Andrew Purtell commented on HBASE-20734:
+1 for branch-1 too
> Colocate recovered edits
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621424#comment-16621424
]
Reid Chan commented on HBASE-20734:
---
Good to go by my judge, other committers may not have enough
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620581#comment-16620581
]
Zach York commented on HBASE-20734:
---
Thanks [~reidchan]!
What is the next step here? Are we still
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618408#comment-16618408
]
Reid Chan commented on HBASE-20734:
---
Unrelated failed UTs, *{color:green}+1{color}* for branch-1 v5.
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618352#comment-16618352
]
Hadoop QA commented on HBASE-20734:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618256#comment-16618256
]
Zach York commented on HBASE-20734:
---
[~apurtell] I have updated the patch for branch-1, can you take a
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614288#comment-16614288
]
Reid Chan commented on HBASE-20734:
---
I think it is ok to go.
Please provide a patch for branch-1 and
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614222#comment-16614222
]
Ted Yu commented on HBASE-20734:
I wouldn't have big chunk of time to review - working on WAL
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614219#comment-16614219
]
Zach York commented on HBASE-20734:
---
[~yuzhih...@gmail.com] any further thoughts?
> Colocate
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614121#comment-16614121
]
Zach York commented on HBASE-20734:
---
Oh weird, I didn't notice the indenting... I'll remove this.
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612976#comment-16612976
]
Reid Chan commented on HBASE-20734:
---
bq. Would you prefer I submit a separate patch for style changes?
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610095#comment-16610095
]
Hadoop QA commented on HBASE-20734:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609988#comment-16609988
]
Hadoop QA commented on HBASE-20734:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609851#comment-16609851
]
Zach York commented on HBASE-20734:
---
[~reidchan] Thanks for the review, sorry I'm slow updating.
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606132#comment-16606132
]
Reid Chan commented on HBASE-20734:
---
* {CommonFSUtils}#constructWALRegionDirFromRegionInfo
This name
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605048#comment-16605048
]
Zach York commented on HBASE-20734:
---
That'd be great, thanks [~reidchan]!
> Colocate recovered edits
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603850#comment-16603850
]
Reid Chan commented on HBASE-20734:
---
Please allow me to take a look.
> Colocate recovered edits
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603537#comment-16603537
]
Zach York commented on HBASE-20734:
---
Regarding Ted's call for more reviewers, Andrew already reviewed,
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599436#comment-16599436
]
Hadoop QA commented on HBASE-20734:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599350#comment-16599350
]
Ted Yu commented on HBASE-20734:
I would go over the latest patch once more.
It would be good to get
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599345#comment-16599345
]
Zach York commented on HBASE-20734:
---
[~yuzhih...@gmail.com] any more comments? Latest diff is up.
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595779#comment-16595779
]
Hadoop QA commented on HBASE-20734:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595644#comment-16595644
]
Zach York commented on HBASE-20734:
---
Also FYI [~apurtell], the branch-1 patch contains the backwards
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595641#comment-16595641
]
Hadoop QA commented on HBASE-20734:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595631#comment-16595631
]
Zach York commented on HBASE-20734:
---
[~yuzhih...@gmail.com] Thanks for the review. I'll change those
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594475#comment-16594475
]
Hadoop QA commented on HBASE-20734:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594390#comment-16594390
]
Hadoop QA commented on HBASE-20734:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594373#comment-16594373
]
Hadoop QA commented on HBASE-20734:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594333#comment-16594333
]
Ted Yu commented on HBASE-20734:
Took a quick look at patch v6.
{code}
+ public HRegionFileSystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594323#comment-16594323
]
Zach York commented on HBASE-20734:
---
[~yuzhih...@gmail.com] did you have any comments on the master
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594319#comment-16594319
]
Zach York commented on HBASE-20734:
---
Attached a rebased patch since the checkstyle didn't seem related
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592067#comment-16592067
]
Andrew Purtell commented on HBASE-20734:
Modulo the compatibility question the changes lgtm, for
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592056#comment-16592056
]
Zach York commented on HBASE-20734:
---
I haven't updated the branch-1 patch for that yet, I was waiting
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592029#comment-16592029
]
Andrew Purtell commented on HBASE-20734:
I looked at the branch-1 patch.
I don't see where we
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584629#comment-16584629
]
Hadoop QA commented on HBASE-20734:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584509#comment-16584509
]
Zach York commented on HBASE-20734:
---
Latest patch fixes the tests.
> Colocate recovered edits
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584486#comment-16584486
]
Hadoop QA commented on HBASE-20734:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584280#comment-16584280
]
Zach York commented on HBASE-20734:
---
New patch fixes TestHeapSize
> Colocate recovered edits
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583571#comment-16583571
]
Hadoop QA commented on HBASE-20734:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583205#comment-16583205
]
Zach York commented on HBASE-20734:
---
Got it now, RB up!
> Colocate recovered edits directory with
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583202#comment-16583202
]
Zach York commented on HBASE-20734:
---
Apparently I lost my reviewboard password... let me try to
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578406#comment-16578406
]
Ted Yu commented on HBASE-20734:
Agree with implementing existence check per region.
> Colocate
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575480#comment-16575480
]
Zach York commented on HBASE-20734:
---
Finally have some time to work on this again. I guess a single
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560069#comment-16560069
]
Andrew Purtell commented on HBASE-20734:
I don't like the idea of doing an extra check at every
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559368#comment-16559368
]
Zach York commented on HBASE-20734:
---
{quote}I don't seem to find the code where, if recovered edits
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559009#comment-16559009
]
Zach York commented on HBASE-20734:
---
PR [https://github.com/apache/hbase/pull/86] contains the master
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558921#comment-16558921
]
Zach York commented on HBASE-20734:
---
Sorry it took so long to get the master patch up. I'll be
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542259#comment-16542259
]
Zach York commented on HBASE-20734:
---
Thanks for reviewing [~yuzhih...@gmail.com]. I am trying to
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542168#comment-16542168
]
Ted Yu commented on HBASE-20734:
I ran the unit tests touched by the patch.
There were a few test
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542158#comment-16542158
]
Ted Yu commented on HBASE-20734:
{code}
+ private FileSystem walFS;
{code}
Maybe put the above field
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540796#comment-16540796
]
Zach York commented on HBASE-20734:
---
Yep, I'll work on getting a patch for master branch. It was just
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540750#comment-16540750
]
Hadoop QA commented on HBASE-20734:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540733#comment-16540733
]
Ted Yu commented on HBASE-20734:
If it is not too much trouble, can you base patch on master branch ?
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519544#comment-16519544
]
Ted Yu commented on HBASE-20734:
In WALSplitter#finishSplitLogFile :
Path rootdir =
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515979#comment-16515979
]
Ted Yu commented on HBASE-20734:
WALSplitter is annotated @InterfaceAudience.Private
It has information
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514190#comment-16514190
]
Zach York commented on HBASE-20734:
---
I looked into the code for this and the challenge is that Region
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513205#comment-16513205
]
Ted Yu commented on HBASE-20734:
After HBASE-17437 was incorporated into 1.4 release, the recovered
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513169#comment-16513169
]
Zach York commented on HBASE-20734:
---
Before HBASE-20723 goes in, there is no chance of this happening,
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513150#comment-16513150
]
Ted Yu commented on HBASE-20734:
Suppose the new region server only knows about the recovered edits dir
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513097#comment-16513097
]
Zach York commented on HBASE-20734:
---
doesn't split log only run before region opening so shouldn't
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513077#comment-16513077
]
Ted Yu commented on HBASE-20734:
Moving recovered edits dir over to under wal.dir is the obvious action
77 matches
Mail list logo
