[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631708#comment-16631708
]
Hudson commented on HBASE-21228:
Results for branch branch-1.4
[build #482 on
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631702#comment-16631702
]
Hudson commented on HBASE-21228:
Results for branch branch-1
[build #480 on
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631667#comment-16631667
]
Hudson commented on HBASE-21228:
Results for branch branch-1.3
[build #483 on
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631646#comment-16631646
]
Hudson commented on HBASE-21228:
Results for branch branch-1.2
[build #490 on
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631251#comment-16631251
]
Hudson commented on HBASE-21228:
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1167 (See
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631249#comment-16631249
]
Hudson commented on HBASE-21228:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #485 (See
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631240#comment-16631240
]
Andrew Purtell commented on HBASE-21228:
This applies to branch-1.2, branch-1.3, and branch-1.4
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630782#comment-16630782
]
Hudson commented on HBASE-21228:
Results for branch branch-2
[build #1310 on
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630580#comment-16630580
]
Hudson commented on HBASE-21228:
Results for branch master
[build #514 on
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630344#comment-16630344
]
Hudson commented on HBASE-21228:
Results for branch branch-2.1
[build #384 on
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630271#comment-16630271
]
Hudson commented on HBASE-21228:
Results for branch branch-2.0
[build #871 on
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629953#comment-16629953
]
Allan Yang commented on HBASE-21228:
Pushed to branch-1+, thanks all for reviewing!
> Memory leak
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629628#comment-16629628
]
Allan Yang commented on HBASE-21228:
{quote}
This comment is no longer relevant, I think? Can delete
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629252#comment-16629252
]
Mike Drob commented on HBASE-21228:
---
bq. // Presize our map of SyncFutures by handler objects.
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629021#comment-16629021
]
Hadoop QA commented on HBASE-21228:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628794#comment-16628794
]
Allan Yang commented on HBASE-21228:
Uploaded a v3 patch to simplify getSyncFuture() method.
>
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628725#comment-16628725
]
Duo Zhang commented on HBASE-21228:
---
+1.
> Memory leak since AbstractFSWAL caches Thread object and
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628717#comment-16628717
]
Hadoop QA commented on HBASE-21228:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628417#comment-16628417
]
Allan Yang commented on HBASE-21228:
Uploaded a new patch addressed [~mdrob],[~xucang],[~Apache9]'s
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628163#comment-16628163
]
Duo Zhang commented on HBASE-21228:
---
IIRC ThreadLocal has a initialValue method to create the first
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627788#comment-16627788
]
Hadoop QA commented on HBASE-21228:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627742#comment-16627742
]
Xu Cang commented on HBASE-21228:
-
nit: Remove the line after TODO you've removed.
[~allan163]
>
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627611#comment-16627611
]
Mike Drob commented on HBASE-21228:
---
I was under the impression that initialValue was well known in
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627575#comment-16627575
]
Allan Yang commented on HBASE-21228:
{quote}
If we override initialValue method on the ThreadLocal,
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627558#comment-16627558
]
Mike Drob commented on HBASE-21228:
---
If we override {{initialValue}} method on the ThreadLocal, then
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627554#comment-16627554
]
Ted Yu commented on HBASE-21228:
+1, pending QA
> Memory leak since AbstractFSWAL caches Thread object
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627553#comment-16627553
]
Allan Yang commented on HBASE-21228:
{quote}
You're suggesting to replace the map with ThreadLocal?
[
https://issues.apache.org/jira/browse/HBASE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627533#comment-16627533
]
Mike Drob commented on HBASE-21228:
---
You're suggesting to replace the map with {{ThreadLocal}}? Yea,
28 matches
Mail list logo
