[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646813#comment-16646813
]
Sean Busbey commented on HBASE-21247:
-
that sounds like a bug. fix the bug instead of adding a
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646788#comment-16646788
]
Ted Yu commented on HBASE-21247:
Stepping thru the code a few times, I kept coming to the code in
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646773#comment-16646773
]
Ted Yu commented on HBASE-21247:
I tried another way of initializing WALFactory :
{code}
final
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646742#comment-16646742
]
Josh Elser commented on HBASE-21247:
[~busbey], sorry about that, too. Seems I was negligent in
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646724#comment-16646724
]
Ted Yu commented on HBASE-21247:
[~busbey]:
Please take a look at the attached 21247.v4.tst
Running
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646681#comment-16646681
]
Ted Yu commented on HBASE-21247:
Reverted to allow time for more discussion.
> Allow WAL Provider to be
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646663#comment-16646663
]
Sean Busbey commented on HBASE-21247:
-
Ted, please re-read my comment and the javadoc I copied all
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646466#comment-16646466
]
Ted Yu commented on HBASE-21247:
We are aware of the above (existing) config.
However, it is an enum.
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646222#comment-16646222
]
Hudson commented on HBASE-21247:
Results for branch master
[build #537 on
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645099#comment-16645099
]
Ted Yu commented on HBASE-21247:
If there is no further review comment, I plan to integrate this.
>
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633487#comment-16633487
]
Josh Elser commented on HBASE-21247:
v4 looks good.
> Allow WAL Provider to be specified by
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632670#comment-16632670
]
Hadoop QA commented on HBASE-21247:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631354#comment-16631354
]
Hadoop QA commented on HBASE-21247:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631216#comment-16631216
]
Ted Yu commented on HBASE-21247:
>From https://builds.apache.org/job/PreCommit-HBASE-Build/14515/console
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631100#comment-16631100
]
Josh Elser commented on HBASE-21247:
You resubmit it? Maybe a problem with that specific host?
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631058#comment-16631058
]
Ted Yu commented on HBASE-21247:
>From https://builds.apache.org/job/PreCommit-HBASE-Build/14513/console
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631035#comment-16631035
]
Ted Yu commented on HBASE-21247:
In patch v3, there are two new subtests.
* when only
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631000#comment-16631000
]
Josh Elser commented on HBASE-21247:
{code:java}
+assertEquals(IOTestProvider.class.getName(),
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630991#comment-16630991
]
Josh Elser commented on HBASE-21247:
{quote}The user doesn't need to specify two WAL classes in the
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630925#comment-16630925
]
Ted Yu commented on HBASE-21247:
w.r.t. first comment above,
{code}
boolean metaWALProvPresent =
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630906#comment-16630906
]
Josh Elser commented on HBASE-21247:
{code:java}
- provider =
[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630893#comment-16630893
]
Josh Elser commented on HBASE-21247:
[~sergey.soldatov] made the suggestion offline today that this
22 matches
Mail list logo
