[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663227#comment-16663227
]
Hadoop QA commented on HBASE-21265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639716#comment-16639716
]
Hudson commented on HBASE-21265:
Results for branch master
[build #527 on
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639692#comment-16639692
]
Hudson commented on HBASE-21265:
Results for branch branch-1.4
[build #494 on
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639650#comment-16639650
]
Hudson commented on HBASE-21265:
Results for branch branch-1
[build #491 on
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639316#comment-16639316
]
Hudson commented on HBASE-21265:
Results for branch branch-2
[build #1343 on
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639233#comment-16639233
]
Andrew Purtell commented on HBASE-21265:
File an issue for that. I’d prefer to remove it as last
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639225#comment-16639225
]
Ted Yu commented on HBASE-21265:
{code}
public class IntegrationTestRSGroup extends TestRSGroupsBase {
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639080#comment-16639080
]
Andrew Purtell commented on HBASE-21265:
I looped TestRSGroupsKillRS on branch-2 10 times. It
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639051#comment-16639051
]
Andrew Purtell commented on HBASE-21265:
Test results on old branch-2 not valid
> Split up
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639044#comment-16639044
]
Hadoop QA commented on HBASE-21265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639040#comment-16639040
]
Andrew Purtell commented on HBASE-21265:
Normal concurrent "second part" testing looks better.
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639031#comment-16639031
]
Andrew Purtell commented on HBASE-21265:
Checkstyle and javac warning fixes
> Split up
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639011#comment-16639011
]
Andrew Purtell commented on HBASE-21265:
Results from the branch-2 version
{noformat}
[INFO]
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639014#comment-16639014
]
Andrew Purtell commented on HBASE-21265:
I see the checkstyle nits, fixing
> Split up
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639010#comment-16639010
]
Hadoop QA commented on HBASE-21265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638978#comment-16638978
]
Andrew Purtell commented on HBASE-21265:
Attached the same refactor to master branch. Not a port
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637768#comment-16637768
]
Andrew Purtell commented on HBASE-21265:
Thanks for the reviews. I see the checkstyle report and
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637746#comment-16637746
]
Vikas Vishwakarma commented on HBASE-21265:
---
looks good +1
few minor checkstyle and
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637685#comment-16637685
]
Ted Yu commented on HBASE-21265:
+1
> Split up TestRSGroups
> -
>
>
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637649#comment-16637649
]
Hadoop QA commented on HBASE-21265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637615#comment-16637615
]
Andrew Purtell commented on HBASE-21265:
Here's a patch for branch-1. Patch for master and later
21 matches
Mail list logo
